Subject: Re: pg_amcheck contrib application
To: Mark Dilger <mark.dilger@enterprisedb.com>,
 Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Thomas Munro <thomas.munro@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
 Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>,
 Amul Sul <sulamul@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <BA592F2D-F928-46FF-9516-2B827F067F57@enterprisedb.com>
 <CA+TgmoZtTZRE6Mzmwt8VEZD0G5NVbhiJEsHW2YGmmqzJUR_KwA@mail.gmail.com>
 <130B2AED-8322-47E6-AD3F-1263E5E18C80@enterprisedb.com>
 <CA+TgmoZgdsVo9ji_Bc7GVvEqGMapC1Hqyuy6CLV-3oyE7HapRA@mail.gmail.com>
 <BC7728FA-C21D-4E25-A266-E94873637354@enterprisedb.com>
 <CA+TgmobwDwvqbpc0OF8MNzQuwAJ2X1D0qEMdBEXXbmmFfzP9+Q@mail.gmail.com>
 <E8A89327-C1B1-4AE2-AEC6-871D39843627@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <b724e2a1-d925-0718-a51a-44ad7039b8cc@enterprisedb.com>
Date: Thu, 11 Mar 2021 09:12:22 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0)
 Gecko/20100101 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <E8A89327-C1B1-4AE2-AEC6-871D39843627@enterprisedb.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b724e2a1-d925-0718-a51a-44ad7039b8cc%40enterprisedb.com>
Precedence: bulk

(I'm still not a fan of adding more client-side tools whose sole task is 
to execute server-side functionality in a slightly filtered way, but it 
seems people are really interested in this, so ...)

I want to register, if we are going to add this, it ought to be in 
src/bin/.  If we think it's a useful tool, it should be there with all 
the other useful tools.

I realize there is a dependency on a module in contrib, and it's 
probably now not the time to re-debate reorganizing contrib.  But if we 
ever get to that, this program should be the prime example why the 
current organization is problematic, and we should be prepared to make 
the necessary moves then.