MIME-Version: 1.0
Date: Mon, 23 Dec 2024 15:14:05 +0300
From: Vladlen Popolitov <v.popolitov@postgrespro.ru>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Kane <andrew@ankane.org>,
 Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
Subject: Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on
 Windows
In-Reply-To: <f5b7611e-01a8-4f24-89e4-381687a4a966@iki.fi>
References: <CAOdR5yF0krWrxycA04rgUKCgKugRvGWzzGLAhDZ9bzNv8g0Lag@mail.gmail.com>
 <138233.1726261100@sss.pgh.pa.us> <ZuSxg3CKsIBhzZhn@nathan>
 <CAOdR5yFQUEC4P6m4XORC77DP_kK2m_CpZTj8fbByBSGmGrAamg@mail.gmail.com>
 <ZuTVneZ4lmdExCyR@paquier.xyz>
 <1e2ba5ae7380fdb947e5bfcb6200063e@postgrespro.ru>
 <f5b7611e-01a8-4f24-89e4-381687a4a966@iki.fi>
Message-ID: <b78bfb4f512a015f0df1489a19a5adbe@postgrespro.ru>
Content-Type: multipart/mixed;
 boundary="=_ddeacb75166508d8dfd41233bc1a74a4"
Archived-At: <https://www.postgresql.org/message-id/b78bfb4f512a015f0df1489a19a5adbe%40postgrespro.ru>
Precedence: bulk

--=_ddeacb75166508d8dfd41233bc1a74a4
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8;
 format=flowed

Heikki Linnakangas писал(а) 2024-12-23 14:05:
> On 23/12/2024 12:32, Vladlen Popolitov wrote:
>> I found the reason of this bug and the fix for it.
> 
> Cool!
> 
>> Fortunatelly meson has option to force put all object files to
>> library - add dependency with the flag link_whole .
>> 
>> I made the one-line patch and it fixes this issue.
>> 
>> -        'dependencies': opts['dependencies'] + [ssl],
>> +        'dependencies': opts['dependencies'] + [ssl] + 
>> [declare_dependency( link_whole  : cflag_libs)],
> 
> I'm no meson expert and don't have a Windows system to test on, but 
> this seems like a weird place to add the option. Could you do this 
> instead:
> 
> diff --git a/src/common/meson.build b/src/common/meson.build
> index 538e0f43d55..76a7f68fe30 100644
> --- a/src/common/meson.build
> +++ b/src/common/meson.build
> @@ -184,6 +184,7 @@ foreach name, opts : pgcommon_variants
> 
>    lib = static_library('libpgcommon@0@'.format(name),
>        link_with: cflag_libs,
> +      link_whole: cflag_libs,
>        c_pch: pch_c_h,
>        kwargs: opts + {
>          'include_directories': [

  Yes, it is also working option. I applied it and tested in the current 
master under Windows,
it works.

Attached patch changes this line in meson.build
>        link_with: cflag_libs,
> +      link_whole: cflag_libs,
>        c_pch: pch_c_h,


-- 
Best regards,

Vladlen Popolitov.

--=_ddeacb75166508d8dfd41233bc1a74a4
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=v2-0001-Fix-meson.build-to-prevent-missed-obj-files-in-li.patch
Content-Disposition: attachment;
 filename=v2-0001-Fix-meson.build-to-prevent-missed-obj-files-in-li.patch;
 size=757

RnJvbSAwNmExZmUwYzBkODE5NzRlYmNjYmQyZjAzMWRmNjIxNTRiZDFjMjlkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWbGFkbGVuIFBvcG9saXRvdiA8di5wb3BvbGl0b3ZAcG9zdGdy
ZXNwcm8ucnU+CkRhdGU6IE1vbiwgMjMgRGVjIDIwMjQgMTU6MDk6MTMgKzAzMDAKU3ViamVjdDog
W1BBVENIIHYyXSBGaXggbWVzb24uYnVpbGQgdG8gcHJldmVudCBtaXNzZWQgb2JqIGZpbGVzIGlu
IGxpYiB1bmRlcgogV2luZG93cwoKLS0tCiBzcmMvY29tbW9uL21lc29uLmJ1aWxkIHwgMSArCiAx
IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKCmRpZmYgLS1naXQgYS9zcmMvY29tbW9uL21l
c29uLmJ1aWxkIGIvc3JjL2NvbW1vbi9tZXNvbi5idWlsZAppbmRleCA1MzhlMGY0M2Q1Li43NmE3
ZjY4ZmUzIDEwMDY0NAotLS0gYS9zcmMvY29tbW9uL21lc29uLmJ1aWxkCisrKyBiL3NyYy9jb21t
b24vbWVzb24uYnVpbGQKQEAgLTE4NCw2ICsxODQsNyBAQCBmb3JlYWNoIG5hbWUsIG9wdHMgOiBw
Z2NvbW1vbl92YXJpYW50cwogCiAgIGxpYiA9IHN0YXRpY19saWJyYXJ5KCdsaWJwZ2NvbW1vbkAw
QCcuZm9ybWF0KG5hbWUpLAogICAgICAgbGlua193aXRoOiBjZmxhZ19saWJzLAorICAgICAgbGlu
a193aG9sZTogY2ZsYWdfbGlicywKICAgICAgIGNfcGNoOiBwY2hfY19oLAogICAgICAga3dhcmdz
OiBvcHRzICsgewogICAgICAgICAnaW5jbHVkZV9kaXJlY3Rvcmllcyc6IFsKLS0gCjIuMzkuNSAo
QXBwbGUgR2l0LTE1NCkKCg==
--=_ddeacb75166508d8dfd41233bc1a74a4--