Content-Type: multipart/mixed; boundary="------------kXqoLyOunNloAn0Kwlj7unPz"
Message-ID: <b7ae9117-3b94-05f4-4813-05ee9ea5cce2@xs4all.nl>
Date: Fri, 22 Sep 2023 10:26:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: Row pattern recognition
Content-Language: en-US
From: Erik Rijkers <er@xs4all.nl>
To: Tatsuo Ishii <ishii@sraoss.co.jp>, vik@postgresfriends.org
Cc: pgsql-hackers@postgresql.org
References: <CAAWbhmjq3NY1+Am-QHJ4AFh7mi=2eiiGqj518f3-j-C3EfffPg@mail.gmail.com>
 <20230912.151843.1810014897541305662.t-ishii@sranhm.sra.co.jp>
 <20230912.174457.1842965393591953201.t-ishii@sranhm.sra.co.jp>
 <20230922.141640.288673971790249857.t-ishii@sranhm.sra.co.jp>
 <f1b24ec2-9b36-90f3-8c58-83c70991f9d8@xs4all.nl>
In-Reply-To: <f1b24ec2-9b36-90f3-8c58-83c70991f9d8@xs4all.nl>
Archived-At: <https://www.postgresql.org/message-id/b7ae9117-3b94-05f4-4813-05ee9ea5cce2%40xs4all.nl>
Precedence: bulk

This is a multi-part message in MIME format.
--------------kXqoLyOunNloAn0Kwlj7unPz
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Op 9/22/23 om 10:23 schreef Erik Rijkers:
> Op 9/22/23 om 07:16 schreef Tatsuo Ishii:
>>> Attached is the fix against v6 patch. I will include this in upcoming 
>>> v7 patch.
>>
>> Attached is the v7 patch. It includes the fix mentioned above.  Also
> (Champion's address bounced; removed)
> 

Sorry, I forgot to re-attach the regression.diffs with resend...

Erik

> Hi,
> 
> In my hands, make check fails on the rpr test; see attached .diff file.
> In these two statements:
> -- using NEXT
> -- using AFTER MATCH SKIP TO NEXT ROW
>    result of first_value(price) and next_value(price) are empty.
> 
> Erik Rijkers
> 
> 
>> this time the pattern matching engine is enhanced: previously it
>> recursed to row direction, which means if the number of rows in a
>> frame is large, it could exceed the limit of stack depth.  The new
>> version recurses over matched pattern variables in a row, which is at
>> most 26 which should be small enough.
>>
>> Best reagards,
>> -- 
>> Tatsuo Ishii
>> SRA OSS LLC
>> English: http://www.sraoss.co.jp/index_en/
>> Japanese:http://www.sraoss.co.jp
> 
> 
--------------kXqoLyOunNloAn0Kwlj7unPz
Content-Type: text/plain; charset=UTF-8; name="regression.diffs"
Content-Disposition: attachment; filename="regression.diffs"
Content-Transfer-Encoding: base64

ZGlmZiAtVTMgL2hvbWUvYWFyZHZhcmsvcGdfc3R1ZmYvcGdfc2FuZGJveC9wZ3NxbC5ycHIv
c3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ycHIub3V0IC9ob21lL2FhcmR2YXJrL3BnX3N0
dWZmL3BnX3NhbmRib3gvcGdzcWwucnByL3NyYy90ZXN0L3JlZ3Jlc3MvcmVzdWx0cy9ycHIu
b3V0Ci0tLSAvaG9tZS9hYXJkdmFyay9wZ19zdHVmZi9wZ19zYW5kYm94L3Bnc3FsLnJwci9z
cmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3Jwci5vdXQJMjAyMy0wOS0yMiAwOTowNDoxNy43
NzAzOTI2MzUgKzAyMDAKKysrIC9ob21lL2FhcmR2YXJrL3BnX3N0dWZmL3BnX3NhbmRib3gv
cGdzcWwucnByL3NyYy90ZXN0L3JlZ3Jlc3MvcmVzdWx0cy9ycHIub3V0CTIwMjMtMDktMjIg
MDk6Mzg6MjMuODI2NDU4MTA5ICswMjAwCkBAIC0yNTMsMjMgKzI1MywyMyBAQAogKTsKICBj
b21wYW55ICB8ICAgdGRhdGUgICAgfCBwcmljZSB8IGZpcnN0X3ZhbHVlIHwgbGFzdF92YWx1
ZSAKIC0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0rLS0tLS0tLS0tLS0tLSstLS0t
LS0tLS0tLS0KLSBjb21wYW55MSB8IDA3LTAxLTIwMjMgfCAgIDEwMCB8ICAgICAgICAgMTAw
IHwgICAgICAgIDIwMAorIGNvbXBhbnkxIHwgMDctMDEtMjAyMyB8ICAgMTAwIHwgICAgICAg
ICAgICAgfCAgICAgICAgICAgCiAgY29tcGFueTEgfCAwNy0wMi0yMDIzIHwgICAyMDAgfCAg
ICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MSB8IDA3LTAzLTIwMjMgfCAgIDE1
MCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAotIGNvbXBhbnkxIHwgMDctMDQtMjAyMyB8
ICAgMTQwIHwgICAgICAgICAxNDAgfCAgICAgICAgMTUwCisgY29tcGFueTEgfCAwNy0wNC0y
MDIzIHwgICAxNDAgfCAgICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MSB8IDA3
LTA1LTIwMjMgfCAgIDE1MCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNvbXBhbnkx
IHwgMDctMDYtMjAyMyB8ICAgIDkwIHwgICAgICAgICAgICAgfCAgICAgICAgICAgCi0gY29t
cGFueTEgfCAwNy0wNy0yMDIzIHwgICAxMTAgfCAgICAgICAgIDExMCB8ICAgICAgICAxMzAK
KyBjb21wYW55MSB8IDA3LTA3LTIwMjMgfCAgIDExMCB8ICAgICAgICAgICAgIHwgICAgICAg
ICAgIAogIGNvbXBhbnkxIHwgMDctMDgtMjAyMyB8ICAgMTMwIHwgICAgICAgICAgICAgfCAg
ICAgICAgICAgCiAgY29tcGFueTEgfCAwNy0wOS0yMDIzIHwgICAxMjAgfCAgICAgICAgICAg
ICB8ICAgICAgICAgICAKICBjb21wYW55MSB8IDA3LTEwLTIwMjMgfCAgIDEzMCB8ICAgICAg
ICAgICAgIHwgICAgICAgICAgIAotIGNvbXBhbnkyIHwgMDctMDEtMjAyMyB8ICAgIDUwIHwg
ICAgICAgICAgNTAgfCAgICAgICAyMDAwCisgY29tcGFueTIgfCAwNy0wMS0yMDIzIHwgICAg
NTAgfCAgICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MiB8IDA3LTAyLTIwMjMg
fCAgMjAwMCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNvbXBhbnkyIHwgMDctMDMt
MjAyMyB8ICAxNTAwIHwgICAgICAgICAgICAgfCAgICAgICAgICAgCi0gY29tcGFueTIgfCAw
Ny0wNC0yMDIzIHwgIDE0MDAgfCAgICAgICAgMTQwMCB8ICAgICAgIDE1MDAKKyBjb21wYW55
MiB8IDA3LTA0LTIwMjMgfCAgMTQwMCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNv
bXBhbnkyIHwgMDctMDUtMjAyMyB8ICAxNTAwIHwgICAgICAgICAgICAgfCAgICAgICAgICAg
CiAgY29tcGFueTIgfCAwNy0wNi0yMDIzIHwgICAgNjAgfCAgICAgICAgICAgICB8ICAgICAg
ICAgICAKLSBjb21wYW55MiB8IDA3LTA3LTIwMjMgfCAgMTEwMCB8ICAgICAgICAxMTAwIHwg
ICAgICAgMTMwMAorIGNvbXBhbnkyIHwgMDctMDctMjAyMyB8ICAxMTAwIHwgICAgICAgICAg
ICAgfCAgICAgICAgICAgCiAgY29tcGFueTIgfCAwNy0wOC0yMDIzIHwgIDEzMDAgfCAgICAg
ICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MiB8IDA3LTA5LTIwMjMgfCAgMTIwMCB8
ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNvbXBhbnkyIHwgMDctMTAtMjAyMyB8ICAx
MzAwIHwgICAgICAgICAgICAgfCAgICAgICAgICAgCkBAIC0yOTAsMjMgKzI5MCwyMyBAQAog
KTsKICBjb21wYW55ICB8ICAgdGRhdGUgICAgfCBwcmljZSB8IGZpcnN0X3ZhbHVlIHwgbGFz
dF92YWx1ZSAKIC0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0rLS0tLS0tLS0tLS0t
LSstLS0tLS0tLS0tLS0KLSBjb21wYW55MSB8IDA3LTAxLTIwMjMgfCAgIDEwMCB8ICAgICAg
ICAgMTAwIHwgICAgICAgIDIwMAorIGNvbXBhbnkxIHwgMDctMDEtMjAyMyB8ICAgMTAwIHwg
ICAgICAgICAgICAgfCAgICAgICAgICAgCiAgY29tcGFueTEgfCAwNy0wMi0yMDIzIHwgICAy
MDAgfCAgICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MSB8IDA3LTAzLTIwMjMg
fCAgIDE1MCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAotIGNvbXBhbnkxIHwgMDctMDQt
MjAyMyB8ICAgMTQwIHwgICAgICAgICAxNDAgfCAgICAgICAgMTUwCisgY29tcGFueTEgfCAw
Ny0wNC0yMDIzIHwgICAxNDAgfCAgICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55
MSB8IDA3LTA1LTIwMjMgfCAgIDE1MCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNv
bXBhbnkxIHwgMDctMDYtMjAyMyB8ICAgIDkwIHwgICAgICAgICAgICAgfCAgICAgICAgICAg
Ci0gY29tcGFueTEgfCAwNy0wNy0yMDIzIHwgICAxMTAgfCAgICAgICAgIDExMCB8ICAgICAg
ICAxMzAKKyBjb21wYW55MSB8IDA3LTA3LTIwMjMgfCAgIDExMCB8ICAgICAgICAgICAgIHwg
ICAgICAgICAgIAogIGNvbXBhbnkxIHwgMDctMDgtMjAyMyB8ICAgMTMwIHwgICAgICAgICAg
ICAgfCAgICAgICAgICAgCiAgY29tcGFueTEgfCAwNy0wOS0yMDIzIHwgICAxMjAgfCAgICAg
ICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MSB8IDA3LTEwLTIwMjMgfCAgIDEzMCB8
ICAgICAgICAgICAgIHwgICAgICAgICAgIAotIGNvbXBhbnkyIHwgMDctMDEtMjAyMyB8ICAg
IDUwIHwgICAgICAgICAgNTAgfCAgICAgICAyMDAwCisgY29tcGFueTIgfCAwNy0wMS0yMDIz
IHwgICAgNTAgfCAgICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MiB8IDA3LTAy
LTIwMjMgfCAgMjAwMCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNvbXBhbnkyIHwg
MDctMDMtMjAyMyB8ICAxNTAwIHwgICAgICAgICAgICAgfCAgICAgICAgICAgCi0gY29tcGFu
eTIgfCAwNy0wNC0yMDIzIHwgIDE0MDAgfCAgICAgICAgMTQwMCB8ICAgICAgIDE1MDAKKyBj
b21wYW55MiB8IDA3LTA0LTIwMjMgfCAgMTQwMCB8ICAgICAgICAgICAgIHwgICAgICAgICAg
IAogIGNvbXBhbnkyIHwgMDctMDUtMjAyMyB8ICAxNTAwIHwgICAgICAgICAgICAgfCAgICAg
ICAgICAgCiAgY29tcGFueTIgfCAwNy0wNi0yMDIzIHwgICAgNjAgfCAgICAgICAgICAgICB8
ICAgICAgICAgICAKLSBjb21wYW55MiB8IDA3LTA3LTIwMjMgfCAgMTEwMCB8ICAgICAgICAx
MTAwIHwgICAgICAgMTMwMAorIGNvbXBhbnkyIHwgMDctMDctMjAyMyB8ICAxMTAwIHwgICAg
ICAgICAgICAgfCAgICAgICAgICAgCiAgY29tcGFueTIgfCAwNy0wOC0yMDIzIHwgIDEzMDAg
fCAgICAgICAgICAgICB8ICAgICAgICAgICAKICBjb21wYW55MiB8IDA3LTA5LTIwMjMgfCAg
MTIwMCB8ICAgICAgICAgICAgIHwgICAgICAgICAgIAogIGNvbXBhbnkyIHwgMDctMTAtMjAy
MyB8ICAxMzAwIHwgICAgICAgICAgICAgfCAgICAgICAgICAgCg==

--------------kXqoLyOunNloAn0Kwlj7unPz--