Feedback-ID: id4a34324:Fastmail
Date: Thu, 22 May 2025 10:47:06 -0400
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
Message-ID: <b7angm4wz2ln2wsqvsb3bwl4pqa4xxgcawn36o5kweu5pgpl6s@ofhhrgl5ouwb>
References: <208054.1663534665@sss.pgh.pa.us>
 <CA+hUKGK=xCw9_V7tCMvpT5D83AH8ArotTw3W4s70Vhqr7VgZkg@mail.gmail.com>
 <CA+hUKG+FVo16ReJa5qWU84h4wpN7w32FG1PUWDcsgQviL-2QEA@mail.gmail.com>
 <334554.1663596005@sss.pgh.pa.us>
 <508012.1663611012@sss.pgh.pa.us>
 <722832.1663690513@sss.pgh.pa.us>
 <CA+hUKGJvX+L3aMN84ksT-cGy08VHErRNip3nV-WmTx7f6Pqhyw@mail.gmail.com>
 <1914802.1670814425@sss.pgh.pa.us>
 <CA+hUKGKtrz0S1NjAf=e76ZyvPi+JNvtJptgEdFFdtK7r4b2jnA@mail.gmail.com>
 <CA+hUKG+F_5qqne+z+dirf5N3hinFsf=7=EygwEynpwq09OcEzQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+hUKG+F_5qqne+z+dirf5N3hinFsf=7=EygwEynpwq09OcEzQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/b7angm4wz2ln2wsqvsb3bwl4pqa4xxgcawn36o5kweu5pgpl6s%40ofhhrgl5ouwb>
Precedence: bulk

Hi,

On 2022-12-13 14:18:48 +1300, Thomas Munro wrote:
> On Mon, Dec 12, 2022 at 4:43 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > On Mon, Dec 12, 2022 at 4:07 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > > I'm for "turn the warning off".  Per previous discussion, adhering
> > > strictly to that rule would make our code worse (less legible AND
> > > less safe), not better.
> >
> > Alright, this seems to do the trick here.
> 
> That did fix that problem.  But... seawasp also just recompiled its
> compiler and picked up new opaque pointer API changes.  So no green
> today.  I have more work to do to fix that, which might take some time
> to get back to.

Presumably due to conflict resolution, this commit added an empty meson.build
to REL_13_STABLE. I'll remove that...

Greetings,

Andres Freund