Message-ID: <b7b274c7-971f-909f-dd7a-b88a7ee650b3@gmail.com>
Date: Fri, 30 Jun 2023 08:09:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: Synchronizing slots from primary to standby
Content-Language: en-US
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: Andres Freund <andres@anarazel.de>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Bruce Momjian <bruce@momjian.us>, Ashutosh Sharma <ashu.coek88@gmail.com>,
 Amit Kapila <amit.kapila16@gmail.com>
References: <514f6f2f-6833-4539-39f1-96cd1e011f23@enterprisedb.com>
 <18dbc929-a281-8552-4f1d-7e4d0e4eedba@enterprisedb.com>
 <646acd8d-9896-ed8d-2ab4-0bf11b3285d4@enterprisedb.com>
 <20220205195944.drwc3psrb5udt2cw@alap3.anarazel.de>
 <CAE9k0PnGmQ97ikLy2oBDoom72FsV_x+H9JuptJ4ysx=CFM-+kQ@mail.gmail.com>
 <20220207203222.22aktwxrt3fcllru@alap3.anarazel.de>
 <CAE9k0Pn80FMhkUZAPyPCLWDYnOcTmxKN3Q3TNNv1m4V99qG-Ew@mail.gmail.com>
 <YgWH4/4tK1AMIOYG@momjian.us>
 <ac40e8f8-46f5-7bb4-c08b-df3c9e6f1599@enterprisedb.com>
 <aa626ffb-2cb1-8683-5188-dad6031a4623@gmail.com>
 <b5cc7fd2-ebbc-512f-40fc-5c7ce93b8bdf@gmail.com>
 <aeab9f12-93a6-743d-4ac6-5f2c73f9bfea@gmail.com>
 <TYAPR01MB58660162840428B320AE4087F525A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <TYAPR01MB58660162840428B320AE4087F525A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/b7b274c7-971f-909f-dd7a-b88a7ee650b3%40gmail.com>
Precedence: bulk

Hi Kuroda-san,

On 6/29/23 12:22 PM, Hayato Kuroda (Fujitsu) wrote:
> Dear Drouvot,
> 
> Hi, I'm also interested in the feature. Followings are my high-level comments.
> I did not mention some detailed notations because this patch is not at the stage.
> And very sorry that I could not follow all of this discussions.
> 

Thanks for looking at it and your feedback!

All I've done so far is to provide a re-based version in April of the existing patch.

I'll have a closer look at the code, at your feedback and Amit's one while working on the new version that will:

- take care of slot invalidation
- ensure that synchronized slot cant' be consumed until the standby gets promoted

as discussed up-thread.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com