Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2qFw-0013eC-FE for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Nov 2023 10:02:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r2qFu-006OoD-GL for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Nov 2023 10:02:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2qFs-006On8-Mn for pgsql-hackers@lists.postgresql.org; Tue, 14 Nov 2023 10:02:50 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2qFp-005VzT-PL for pgsql-hackers@lists.postgresql.org; Tue, 14 Nov 2023 10:02:47 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B355E320015C; Tue, 14 Nov 2023 05:02:43 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 14 Nov 2023 05:02:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1699956163; x=1700042563; bh=XUlmsH03mQ1saON9eNrnYfL1v 3V6Sn2hZMULSmYYZ54=; b=j8J0RuSAoKlPLJgi8oKXf9KMWa+qgRRMJWimrIORh SFZVDe0NCTDj7S5CXesbXHA85u6CFhRAp02fPwVWeUF88HAt6BZCzPrnX0AUmtxB xa6kg6OEIG6pW/6f3q1CXqersRrU26QEoG5SoMVhHuowxaJu/OaT1z/LgqXKZsNT FCAY99wh377mzvVxeV0gTXhyjoRpxSFvBoj1QEJLPBia+gMb8674pOJnEetQ2zox rQwLqvBDRzqPTGGxoN0ugGvyM0zZNdLQAUMLY5xmiHB91is3goLzsEnKJar1JUYS pHts+SvqsMdeMypxIqiOb31yk1HFPi7SUj3ZaPqWPPYZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1699956163; x=1700042563; bh=XUlmsH03mQ1saON9eNrnYfL1v3V6Sn2hZMU LSmYYZ54=; b=i+ahgpi7d97wc09I/djmww793omZXOniVv335IPhFcN3c3W32/q nkiw4xzIys6xF5JTCx+OmJdJ6rpGNE6J7N9+gGRCG1fv7Eg/J3cZxvtgeDhwLrnp a0CR6T4RxMFFyOZsLFgWOY+ihfowG4hute7TnByd4kqxz0Ha3er+wzVBmvkh0ZDq FXunlyff+NX4FTBpOVuBD85cwF9v7pNnagZ7JiVFOkvpgTw6hefAEIRYRBfOjTAb 7Ed+HmnyfCYB8aGag2XBfeNCBzRUywzMLkUAEVhK1MEA06OFJJmpqQm+uFza0FbM B9uMtZQRWUBk2BMgPrW/L98BIQAYF9Lz/8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudefvddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileehteeljeeghfeuledthfeu tedvffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Nov 2023 05:02:42 -0500 (EST) Message-ID: Date: Tue, 14 Nov 2023 11:02:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Remove MSVC scripts from the tree Content-Language: en-US To: Michael Paquier Cc: Postgres hackers References: <3fd0f1bc-4483-4ba9-8aa0-64765b052039@eisentraut.org> <9f37249d-d159-46a5-afe0-b5eecd7ff6c2@eisentraut.org> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 13.11.23 06:30, Michael Paquier wrote: > On Fri, Nov 10, 2023 at 08:38:21AM +0100, Peter Eisentraut wrote: >> How about this patch as a comprehensive solution? >> 8 files changed, 26 insertions(+), 339 deletions(-) > > Thanks for the patch. The numbers are here, and the patch looks > sensible. > > The contents of probes.h without --enable-trace are exactly the same > before and after the patch. > > In short, +1 to switch to what you are proposing here. done