Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbLPa-0004Cg-PU for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Mar 2023 13:06:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pbLPZ-0003p9-LR for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Mar 2023 13:06:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbLPZ-0003p0-C6 for pgsql-hackers@lists.postgresql.org; Sun, 12 Mar 2023 13:06:53 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbLPW-0001CK-He for pgsql-hackers@lists.postgresql.org; Sun, 12 Mar 2023 13:06:52 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id F407960003; Sun, 12 Mar 2023 13:06:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------GK9i5Isf3v1DuYwh5U1sq6KU" Message-ID: Date: Sun, 12 Mar 2023 09:06:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: unsafe_tests module Content-Language: en-US To: Andres Freund Cc: PostgreSQL Hackers References: <20230312001221.q6dgdnvj33uxik5x@awork3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20230312001221.q6dgdnvj33uxik5x@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------GK9i5Isf3v1DuYwh5U1sq6KU Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-03-11 Sa 19:12, Andres Freund wrote: > Hi, > > On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote: >> Given its nature and purpose as a module we don't want to run against an >> installed instance, shouldn't src/test/modules/unsafe_tests have >> NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build? > Seems like a good idea to me. > Thanks, done. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------GK9i5Isf3v1DuYwh5U1sq6KU Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2023-03-11 Sa 19:12, Andres Freund wrote:
Hi,

On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:

Given its nature and purpose as a module we don't want to run against an
installed instance, shouldn't src/test/modules/unsafe_tests have
NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?

Seems like a good idea to me.


Thanks, done.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------GK9i5Isf3v1DuYwh5U1sq6KU--