Message-ID: <b7e1cbbf-d4dd-8c33-42be-c1a81b162363@enterprisedb.com>
Date: Thu, 9 Dec 2021 16:51:17 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.3.2
Subject: Re: Readd use of TAP subtests
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>, =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?=
 <ilmari@ilmari.org>
Cc: Andrew Dunstan <andrew@dunslane.net>, Daniel Gustafsson
 <daniel@yesql.se>, pgsql-hackers <pgsql-hackers@postgresql.org>
References: <9878e1e2-2ce3-6df0-3498-07d967534f5e@enterprisedb.com>
 <87zgpbnr59.fsf@wibble.ilmari.org>
 <6131CFD1-EC47-41ED-999E-AB28B40DDEAA@yesql.se>
 <87wnkfnq9m.fsf@wibble.ilmari.org>
 <7e67b831-9eae-cd19-c96c-c1e59d916498@dunslane.net>
 <87tufjnodg.fsf@wibble.ilmari.org> <3662434.1638984660@sss.pgh.pa.us>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <3662434.1638984660@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/b7e1cbbf-d4dd-8c33-42be-c1a81b162363%40enterprisedb.com>
Precedence: bulk

On 08.12.21 18:31, Tom Lane wrote:
> A question that seems pretty relevant here is: what exactly is the
> point of using the subtest feature, if we aren't especially interested
> in its effect on the overall test count?  I can see that it'd have
> value when you wanted to use skip_all to control a subset of a test
> run, but I'm not detecting where is the value-added in the cases in
> Peter's proposed patch.

It's useful if you edit a test file and add (what would appear to be) N 
tests and want to update the number.

But I'm also OK with the done_testing() style, if there are no drawbacks 
to that.

Does that call into question why we raised the Test::More version to 
begin with?  Or were there other reasons?