Subject: Re: snapbuild woes
To: Erik Rijkers <er@xs4all.nl>
References: <f37e975c-908f-858e-707f-058d3b1eb214@2ndquadrant.com>
 <20161212214227.qxspxdqqrprfvnz3@alap3.anarazel.de>
 <194608bf-d403-b566-3578-4439e70a8119@2ndquadrant.com>
 <20161212223338.bmhswrdaipttvcve@alap3.anarazel.de>
 <7023017e-8b08-eaba-396c-80baf0a793c0@2ndquadrant.com>
 <7286ebe9-cb1b-cf1a-f85b-fbe3402ea0bf@2ndquadrant.com>
 <9a897b86-46e1-9915-ee4c-da02e4ff6a95@2ndquadrant.com>
 <51f65289-54f8-2256-d107-937d662d69f1@2ndquadrant.com>
 <f41d64c7-1ae2-fac7-bf7f-f24dfe2d33bd@2ndquadrant.com>
 <edd7316a312a869c6548d20439be3708@xs4all.nl>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Robert Haas <robertmhaas@gmail.com>, Craig Ringer <craig@2ndquadrant.com>
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Message-ID: <b81b0426-68e3-aea3-eb3f-e56d53f0779c@2ndquadrant.com>
Date: Fri, 3 Mar 2017 01:54:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <edd7316a312a869c6548d20439be3708@xs4all.nl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 03/03/17 01:53, Erik Rijkers wrote:
> On 2017-03-03 01:30, Petr Jelinek wrote:
> 
> With these patches:
> 
> 0001-Use-asynchronous-connect-API-in-libpqwalreceiver.patch
> 0002-Fix-after-trigger-execution-in-logical-replication.patch
> 0003-Add-RENAME-support-for-PUBLICATIONs-and-SUBSCRIPTION.patch
> snapbuild-v5-0001-Reserve-global-xmin-for-create-slot-snasphot-export.patch
> snapbuild-v5-0002-Don-t-use-on-disk-snapshots-for-snapshot-export-in-l.patch
> 
> snapbuild-v5-0003-Prevent-snapshot-builder-xmin-from-going-backwards.patch
> snapbuild-v5-0004-Fix-xl_running_xacts-usage-in-snapshot-builder.patch
> snapbuild-v5-0005-Skip-unnecessary-snapshot-builds.patch
> 0001-Logical-replication-support-for-initial-data-copy-v6.patch
> 
> I get:
> 
> subscriptioncmds.c:47:12: error: static declaration of ‘oid_cmp’ follows
> non-static declaration
>  static int oid_cmp(const void *p1, const void *p2);
>             ^~~~~~~
> In file included from subscriptioncmds.c:42:0:
> ../../../src/include/utils/builtins.h:70:12: note: previous declaration
> of ‘oid_cmp’ was here
>  extern int oid_cmp(const void *p1, const void *p2);
>             ^~~~~~~
> make[3]: *** [subscriptioncmds.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [commands-recursive] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [all-backend-recurse] Error 2
> make: *** [all-src-recurse] Error 2
> 

Yes the copy patch needs rebase as well. But these ones are fine.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers