Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Tue, 26 May 2026 12:39:01 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
 "Michael Paquier" <michael@paquier.xyz>
Cc: "Kyotaro Horiguchi" <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Message-Id: <b8ff6a67-8742-4527-b99d-ff33dd11f56c@app.fastmail.com>
In-Reply-To: <ahV9KzLOqvOw78C3@alvherre.pgsql>
References: <ahV9KzLOqvOw78C3@alvherre.pgsql>
Subject: Re: NULL pointer dereference in syslogger with load_libraries() and
 -DEXEC_BACKEND at startup
Content-Type: multipart/mixed;
 boundary=55ed71fe34de31344b078c9141945028b2f6152d
Archived-At: 
 <https://www.postgresql.org/message-id/b8ff6a67-8742-4527-b99d-ff33dd11f56c%40app.fastmail.com>
Precedence: bulk

--55ed71fe34de31344b078c9141945028b2f6152d
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Tue, May 26, 2026, at 8:09 AM, Alvaro Herrera wrote:
> On 2026-May-26, Michael Paquier wrote:
>
>> This issue is different, it is a Postgres logic bug, so adding an
>> exception like the one you are suggesting is just a shortcut hiding
>> the real issue: the log file is not ready yet, but the syslogger is
>> invoked at a point when it thinks the log file exists.
>
> I think we can solve this easily by flipping a new Boolean value at the
> same point were MyBackendType was previously set.  The attached POC
> fixes the scenario you described; can you confirm?  It needs some
> additional comments, of course.
>

It fixes the issue for me. However, I'm wondering if we can avoid adding a new
boolean for it. We already have redirection_done that guarantees the syslogger
is working properly. Couldn't we use it? (SysLogger_Start() opens the file --
logfile_open -- and a few lines below it sets the redirection_done. If we adopt
this approach, a comment should be added to avoid breaking it in the future.)

> (There is one more place in elog.c where we check that MyBackendType is
> _not_ B_LOGGER, but I think that one is correct as-is; and I'm wondering
> if that would behave correctly before 0c8e082fba8d.)
>

Yes. The redirection_done guarantees that the file is open.


PS> this patch does not allow writes to syslogger as soon as possible like your
patch but it seems acceptable to me.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/
--55ed71fe34de31344b078c9141945028b2f6152d
Content-Disposition: attachment;
	filename*0="0001-syslogger-try-to-write-messages-only-after-setup.patch"
Content-Type: text/x-patch;
	name="=?UTF-8?Q?0001-syslogger-try-to-write-messages-only-after-setup.patch?="
Content-Transfer-Encoding: base64

RnJvbSA2NWRlY2ZkY2I3ZjczZWY5MzU0YzU1OTQ5NzY3Y2RiZWI1NmYyNGFiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBFdWxlciBUYXZlaXJhIDxldWxlckBldWxlcnRvLmNv
bT4KRGF0ZTogVHVlLCAyNiBNYXkgMjAyNiAxMTo0OToyOCAtMDMwMApTdWJqZWN0OiBbUEFU
Q0hdIHN5c2xvZ2dlcjogdHJ5IHRvIHdyaXRlIG1lc3NhZ2VzIG9ubHkgYWZ0ZXIgc2V0dXAK
ClNpbmNlIGNvbW1pdCAwYzhlMDgyZmJhOGQgdGhlcmUgaXMgbm8gZ3VhcmFudGVlIHRoYXQg
c3lzbG9nZ2VyIGZpbmlzaGVzCml0cyBzZXR1cCBiZWZvcmUgYW55IHByb2Nlc3MgY2FuIHVz
ZSBpdC4gQWRkIGFuIGV4dHJhIGNoZWNrIHRoYXQgaXMgb25seQpzZXQgYWZ0ZXIgdGhlIHNl
dHVwIGlzIGRvbmUuCgpEaXNjdXNzaW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL2FoUC1KVDRa
UlB5b2JuTGJAcGFxdWllci54eXoKLS0tCiBzcmMvYmFja2VuZC91dGlscy9lcnJvci9lbG9n
LmMgfCA3ICsrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVs
ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5j
IGIvc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5jCmluZGV4IDUwYzUzYjU3MWEwLi44
ZTE3OTZjZTVmZiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvdXRpbHMvZXJyb3IvZWxvZy5j
CisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL2Vycm9yL2Vsb2cuYwpAQCAtMzg4NCw4ICszODg0
LDExIEBAIHNlbmRfbWVzc2FnZV90b19zZXJ2ZXJfbG9nKEVycm9yRGF0YSAqZWRhdGEpCiAJ
CQl3cml0ZV9jb25zb2xlKGJ1Zi5kYXRhLCBidWYubGVuKTsKIAl9CiAKLQkvKiBJZiBpbiB0
aGUgc3lzbG9nZ2VyIHByb2Nlc3MsIHRyeSB0byB3cml0ZSBtZXNzYWdlcyBkaXJlY3QgdG8g
ZmlsZSAqLwotCWlmIChNeUJhY2tlbmRUeXBlID09IEJfTE9HR0VSKQorCS8qCisJICogSWYg
aW4gdGhlIHN5c2xvZ2dlciBwcm9jZXNzIChhbmQgaXRzIHNldHVwIGlzIGRvbmUpLCB0cnkg
dG8gd3JpdGUKKwkgKiBtZXNzYWdlcyBkaXJlY3QgdG8gZmlsZS4KKwkgKi8KKwlpZiAocmVk
aXJlY3Rpb25fZG9uZSAmJiBNeUJhY2tlbmRUeXBlID09IEJfTE9HR0VSKQogCQl3cml0ZV9z
eXNsb2dnZXJfZmlsZShidWYuZGF0YSwgYnVmLmxlbiwgTE9HX0RFU1RJTkFUSU9OX1NUREVS
Uik7CiAKIAkvKiBObyBtb3JlIG5lZWQgb2YgdGhlIG1lc3NhZ2UgZm9ybWF0dGVkIGZvciBz
dGRlcnIgKi8KLS0gCjIuMzkuNQoK

--55ed71fe34de31344b078c9141945028b2f6152d--