Message-ID: <b903792ab7ca37af4be6d959ce1ea5b548f19391.camel@j-davis.com>
Subject: Re: Improve error message for ICU libraries if pkg-config is absent
From: Jeff Davis <pgsql@j-davis.com>
To: Michael Banck <mbanck@gmx.net>, Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Holger Jakobs
	 <holger@jakobs.com>, Jeff Davis <jdavis@postgresql.org>
Date: Wed, 14 Aug 2024 18:05:19 -0700
In-Reply-To: <66b5e4e4.170a0220.3cbf42.a1a2@mx.google.com>
References: <66b5d05c.050a0220.7c8ce.a951@mx.google.com>
	 <b0523547-4222-4838-869a-aaa0e9fe53ab@iki.fi>
	 <66b5e4e4.170a0220.3cbf42.a1a2@mx.google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/b903792ab7ca37af4be6d959ce1ea5b548f19391.camel%40j-davis.com>
Precedence: bulk

On Fri, 2024-08-09 at 11:44 +0200, Michael Banck wrote:
> So maybe the better change is to just remove the explicit error
> message
> again and depend on PKG_CHECK_MODULES erroring out helpfully?=C2=A0 The
> downside would be that the hint about specifying --without-icu to get
> around this would disappear, but I think somebody building from
> source
> can figure that out more easily than the subtle issue that pkg-config
> is
> not installed.

That looks good to me. Does anyone have a different opinion? If not,
I'll go ahead and commit (but not backport) this change.

Regards,
	Jeff Davis