Subject: Re: PATCH: Exclude unlogged tables from base backups
To: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Michael Paquier <michael.paquier@gmail.com>
References: <04791bab-cb04-ba43-e9c0-664a4c1ffb2c@pgmasters.net>
 <20171212225234.jqdwd4sp663l4znp@alap3.anarazel.de>
 <5e428ad7-f37f-6479-aabf-2c8b9318fb79@pgmasters.net>
 <20171212230740.evr7rvkzz5bztdg6@alap3.anarazel.de>
 <20171213014804.GH4628@tamriel.snowman.net>
 <d3f60151-03b3-9443-e07c-aaaf42e9dd55@pgmasters.net>
 <20171213150456.GI4628@tamriel.snowman.net>
From: David Steele <david@pgmasters.net>
Message-ID: <b947f3a1-cc9d-2aec-da43-ce19c06c22a2@pgmasters.net>
Date: Wed, 13 Dec 2017 10:44:38 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171213150456.GI4628@tamriel.snowman.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/13/17 10:04 AM, Stephen Frost wrote:
> 
> Just to be clear- the new base backup code doesn't actually *do* the
> non-init fork removal, it simply doesn't include the non-init fork in
> the backup when there is an init fork, right?

It does *not* do the unlogged non-init fork removal.  The code I 
refactored in reinit.c is about identifying the forks, not removing 
them.  That code is reused to determine what to exclude from the backup.

I added the regression tests to ensure that the behavior of reinit.c is 
unchanged after the refactor.

> We certainly wouldn't want a basebackup actually running around removing
> the main fork for unlogged tables on a running and otherwise healthy
> system. ;)

That would not be good.

-- 
-David
david@pgmasters.net