Feedback-ID: ie0a040ee:Fastmail
Message-ID: <b983b970-2666-4e89-aa6c-ec372603a984@eisentraut.org>
Date: Fri, 3 May 2024 11:17:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: tablecmds.c/MergeAttributes() cleanup
To: Robert Haas <robertmhaas@gmail.com>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
References: <20230829112028.qhzse7chs3swqwqh@alvherre.pgsql>
 <60beec03-f14c-ea46-8e5f-f68773ce83f9@eisentraut.org>
 <a7bee080-ca35-f49e-1ef1-41484f529c37@eisentraut.org>
 <dd2a1ed7-7a8b-435c-a11d-99275eca18dc@eisentraut.org>
 <12e27bdb-1a3d-450f-923b-c36feea24f01@eisentraut.org>
 <CAExHW5vz7A-skzt05=4frFx9-VPjfjK4jKQZT7ufRNh4J7=xmQ@mail.gmail.com>
 <ad822409-c1c9-400a-b214-9d7e15b4a426@eisentraut.org>
 <b22a6834-aacb-7b18-0424-a3f5fe889667@gmail.com>
 <CAExHW5uskiHd7A34XbA+0PbW3_modiLGUt-oiP5zBumS-eUb8g@mail.gmail.com>
 <4da47c8d-c234-ee1e-f8a4-4ca9a3a81aec@gmail.com>
 <CAExHW5uLe1_W+PN=LwfEO+VFbDRxMuge8MaQ4q09KqNR23D_Bw@mail.gmail.com>
 <CA+TgmobMuo4XXA_NMKcPUyvRNCpShNs5j-OJmvdPkq9mvkMfUA@mail.gmail.com>
 <CAExHW5t=N+8DzjDgze_WY0Uf6umJGa0L+yTpc432sZ=5pGyfQw@mail.gmail.com>
 <CA+Tgmob8UXbqzX6mGPZrPQyJH0rvDdgV_ohyqUfU4qoZrroP8g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CA+Tgmob8UXbqzX6mGPZrPQyJH0rvDdgV_ohyqUfU4qoZrroP8g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/b983b970-2666-4e89-aa6c-ec372603a984%40eisentraut.org>
Precedence: bulk

On 30.04.24 21:48, Robert Haas wrote:
> I took a look at this patch. Currently this case crashes:
> 
> CREATE TABLE cmdata(f1 text COMPRESSION pglz);
> CREATE TABLE cmdata3(f1 text);
> CREATE TABLE cminh() INHERITS (cmdata, cmdata3);
> 
> The patch makes this succeed, but I was initially unclear why it
> didn't make it fail with an error instead: you can argue that cmdata
> has pglz and cmdata3 has default and those are different. It seems
> that prior precedent goes both ways -- we treat the absence of a
> STORAGE specification as STORAGE EXTENDED and it conflicts with an
> explicit storage specification on some other inheritance parent - but
> on the other hand, we treat the absence of a default as compatible
> with any explicit default, similar to what happens here.

The actual behavior here is arguably not ideal.  It was the purpose of 
the other thread mentioned upthread to improve that, but that was not 
successful for the time being.

> So now I think this is committable, but I can't do it now because I
> won't be around for the next few hours in case the buildfarm blows up.
> I can do it tomorrow, or perhaps Peter would like to handle it since
> it seems to have been his commit that introduced the issue.

I have committed it now.