Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iiCmx-0002U3-Ov for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Dec 2019 07:33:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iiCmw-0000aI-Ai for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Dec 2019 07:33:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iiCmw-0000aB-1W for pgsql-hackers@lists.postgresql.org; Fri, 20 Dec 2019 07:33:30 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iiCms-0006GC-NJ for pgsql-hackers@postgresql.org; Fri, 20 Dec 2019 07:33:29 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 19DAE81A; Fri, 20 Dec 2019 02:33:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 20 Dec 2019 02:33:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=riZ35Pw40nb0LsyibrFmLtCnrO+Oa3gTyD698t7+M Bw=; b=LjAsjRak7LXbO84pGTPONrQ3U7Iv9MVWmVbNMN4kYmOWBDPXZx8DFonq/ uFWwEb9yNaRxngGh6Y8tO05Th7UyPKUUbS5ovucrsD8X4x6NNt7UGD9DB7AAJJHK 46rnGOkPBegrpYPwIWhaNElXmtX0JSpFL5Rqo2O02ND/M6Hej4upJaXH3pVs8CzD E2dT39rVz5Gid5nxCGgGE2tq5AEYpKb8z3hF4je/34kkJ5jo+WAL5IOY4AjowyfT AJjTc4m0fP+V/ZWHH7KMzjNkBIAz9p9oW/GzrR4ygWZVxy4/tXl6BsSRYaEIT4Q9 GAqHcmYFvlXFyXD/Sle+omsEf7iIg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdduvddguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhfhokffffgggjggtgfesthejredttdefjeenucfhrhhomheprfgv thgvrhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsedvnh guqhhurggurhgrnhhtrdgtohhmqeenucffohhmrghinhepvdhnughquhgrughrrghnthdr tghomhenucfkphepleefrddvgedvrdduiedurddufedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehpvghtvghrrdgvihhsvghnthhrrghuthesvdhnughquhgrughrrghnthdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from april.pezone.net (p5df2a182.dip0.t-ipconnect.de [93.242.161.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 7DE498005A; Fri, 20 Dec 2019 02:33:22 -0500 (EST) Subject: Re: allow_system_table_mods and DROP RULE To: Robert Haas References: Cc: pgsql-hackers From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Fri, 20 Dec 2019 08:33:21 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-12-18 16:53, Robert Haas wrote: > On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut > wrote: >> As a curious omission, DROP RULE does not check allow_system_table_mods. >> Creating and renaming a rule does, and also creating, renaming, and >> dropping a trigger does. The impact of this is probably nil in >> practice, but for consistency we should probably add that. The patch is >> pretty simple. > > +1. LGTM. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services