Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1q6N-00084u-PZ for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Dec 2021 13:31:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n1q6L-0006NW-9u for pgsql-hackers@arkaria.postgresql.org; Mon, 27 Dec 2021 13:31:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1q6K-0006NM-K4 for pgsql-hackers@lists.postgresql.org; Mon, 27 Dec 2021 13:31:45 +0000 Received: from mail-qk1-x731.google.com ([2607:f8b0:4864:20::731]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1n1q6A-0000CX-KM for pgsql-hackers@postgresql.org; Mon, 27 Dec 2021 13:31:43 +0000 Received: by mail-qk1-x731.google.com with SMTP id de30so14453349qkb.0 for ; Mon, 27 Dec 2021 05:31:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qwsmjh7iTKMqJAz4fvwi/m7o1RkD1xPGkU1jZrWiXGw=; b=dGWTx6pUzJr42xan4wqRG0y1j5eNs4gaMYY8Is4kiiQD87wLIMlXNkPYv3/ilYysme tLEmwTM9TbzYufddoQoi02C3PqiEPLVF4GyhwSMfzOCF/ECzCLKv9oA4Vnrc5Q8NseKH wv7bfeLddnC8vutzRlPXi/CjmvQOjq77ylaMJyBONHJpMwCBkVBPYTwgrqnm4CoWGqaC YeJvTtCDFZNGK6rEQYGJgAotVUHxI+ZhNGtUe4z5Rka2c2FBVVwHYK9WuO64kkovhYXR g4ITavl/V1UV9hlTo7KGS0QZwBlQWuNhRtDW6ZrVWIFvRXzg7lD6zyQbnoxJe5k6Ehyd muVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qwsmjh7iTKMqJAz4fvwi/m7o1RkD1xPGkU1jZrWiXGw=; b=yrHfXn1gGv8SXZSuXJXL7ObW4JfZYyPQm1EngzGp/DmbjZZIjXxy6E+hTxunCHGq4I DdKCVWOTUzGByu8SlalE3QgUd2CLATZncQ/poURvcBXWfJHpTXiHX+F43xydoogTKwlz XtKUlzkwSeK6DYDeDGTuLDbBJVg6udzCAxW0JWjP51TiVJ7I1dcoeNHhEofE54Leu3Qj r2oT5M7d2Y6rhxSmI388uV9zShGDoGiNF+R/fXCRpsq4uNW4AU3W86MqZ1afS0OvPuRl PrRkjUgzWxvePLqSRyJFi72O0mtSMExu7sJ/mNGb0+Q52bV4co4Rk1ssZZ9yCYWAfbGa SeXw== X-Gm-Message-State: AOAM533bQnhrVb0Yqkzwp3XbZw32OFhCVq9nPy4c8qVR/QLVkSBBp+hP vaszs0qkTaws925/MzBtrVcmzXXZLDC5OVXNlkekvqvYVfbNOq5QXxeJJviJgtBPyBSL5BZJRkO Ey+yqqwqrdBnj38TjBTkZ/wZLt/a5GOiVyRHDgn3i0mubgGyhkmzBIJBtz8w+2n+X6PEF77Hvzj ZedOANg0uTI4K7EmjVw4rHlIPB5datlcCPu4BclhSXECypwwrWI4+WR47lEJToHYF1M9WMROHTX D/xxz7sP9Ah5ySN+NBQxIHC6joQZC3Mt/+tXg== X-Google-Smtp-Source: ABdhPJzJrumrrbStSGDs8YI5aWKVc0FszERRhqQFIs6xfl2zxh+Tv/12Oh9NLIlPv7XVnxW6iDIeaA== X-Received: by 2002:a05:620a:2487:: with SMTP id i7mr12046015qkn.234.1640611891677; Mon, 27 Dec 2021 05:31:31 -0800 (PST) Received: from localhost.localdomain ([45.113.251.168]) by smtp.gmail.com with ESMTPSA id l13sm13732454qkp.109.2021.12.27.05.31.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Dec 2021 05:31:30 -0800 (PST) Subject: Re: refactoring basebackup.c To: Jeevan Ladhe , Robert Haas Cc: Dmitry Dolgov <9erthalion6@gmail.com>, Mark Dilger , "pgsql-hackers@postgresql.org" References: <20211115162641.dmo6l32fklh64gnw@localhost> From: tushar Message-ID: Date: Mon, 27 Dec 2021 19:01:26 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/22/21 11:05 PM, Jeevan Ladhe wrote: > Please find the lz4 compression patch here that basically has: Thanks, Could you please rebase your patch, it is failing at my end - [edb@centos7tushar pg15_lz]$ git apply /tmp/v8-0001-LZ4-compression.patch error: patch failed: doc/src/sgml/ref/pg_basebackup.sgml:230 error: doc/src/sgml/ref/pg_basebackup.sgml: patch does not apply error: patch failed: src/backend/replication/Makefile:19 error: src/backend/replication/Makefile: patch does not apply error: patch failed: src/backend/replication/basebackup.c:64 error: src/backend/replication/basebackup.c: patch does not apply error: patch failed: src/include/replication/basebackup_sink.h:285 error: src/include/replication/basebackup_sink.h: patch does not apply -- regards,tushar EnterpriseDB https://www.enterprisedb.com/ The Enterprise PostgreSQL Company