Feedback-ID: ie0a040ee:Fastmail
Message-ID: <b9b949be-dff6-e75f-c95b-71afc70cfa5d@eisentraut.org>
Date: Wed, 9 Aug 2023 17:19:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: Using defines for protocol characters
Content-Language: en-US
To: Dave Cramer <davecramer@gmail.com>, Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com,
 alvherre@alvh.no-ip.org, smithpb2250@gmail.com,
 pgsql-hackers@lists.postgresql.org
References: <CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com>
 <859245.1691438528@sss.pgh.pa.us> <20230807214714.GA1284531@nathanxps13>
 <20230808.074954.718352835768755597.t-ishii@sranhm.sra.co.jp>
 <CADK3HHJgZWCh8Kwvc41=B3nAXyP_iX0bFewe7+7q6qp1hXiW5g@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CADK3HHJgZWCh8Kwvc41=B3nAXyP_iX0bFewe7+7q6qp1hXiW5g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/b9b949be-dff6-e75f-c95b-71afc70cfa5d%40eisentraut.org>
Precedence: bulk

1. As was discussed, these definitions should go into 
src/include/libpq/pqcomm.h, not a new file.

2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest, 
so it's easier to visually locate the start of the actual message name.

3. IMO, the names of the protocol messages in protocol.sgml are 
canonical.  Your patch appends "Request" and "Response" in cases where 
that is not part of the actual name.  Also, some messages are documented 
to go both ways, so this separation doesn't make sense strictly 
speaking.  Please use the names as in protocol.sgml without augmenting them.