Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRw1n-00078Q-7C for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Apr 2021 12:02:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lRw1l-0001D1-Vp for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Apr 2021 12:02:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRw1l-0001Cu-1E for pgsql-hackers@lists.postgresql.org; Thu, 01 Apr 2021 12:02:21 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRw1e-0001L5-9n for pgsql-hackers@lists.postgresql.org; Thu, 01 Apr 2021 12:02:19 +0000 Received: from hnk.local (p2350207-ipbf2126funabasi.chiba.ocn.ne.jp [114.167.184.207]) by oss.nttdata.com (Postfix) with ESMTPSA id 89BAC62829; Thu, 1 Apr 2021 21:02:10 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: Failed assertion on standby while shutdown To: Maxim Orlov , pgsql-hackers@lists.postgresql.org References: <161712624344.1180.1891286647778019120.pgcf@coridan.postgresql.org> From: Fujii Masao Message-ID: Date: Thu, 1 Apr 2021 21:02:09 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------7DBB63347227619C03973A07" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------7DBB63347227619C03973A07 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 2021/03/31 19:51, Maxim Orlov wrote: > On 2021-03-30 20:44, Maxim Orlov wrote: >> The following review has been posted through the commitfest application: >> make installcheck-world:  tested, passed >> Implements feature:       tested, passed >> Spec compliant:           not tested >> Documentation:            not tested >> >> All the tests passed successfully. >> >> The new status of this patch is: Ready for Committer > > The patch is good. One note, should we put a comment about ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce? +1 to add more comments into ShutdownRecoveryTransactionEnvironment(). I did that. What about the attached patch? Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------7DBB63347227619C03973A07 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="fix_assertion_failure_walreceiver_v2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="fix_assertion_failure_walreceiver_v2.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvc3RhcnR1cC5jIGIvc3JjL2Jh Y2tlbmQvcG9zdG1hc3Rlci9zdGFydHVwLmMKaW5kZXggMjIxMzVkNWUwNy4uNjkwNzdiZDIw NyAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9zdGFydHVwLmMKKysrIGIv c3JjL2JhY2tlbmQvcG9zdG1hc3Rlci9zdGFydHVwLmMKQEAgLTYyLDYgKzYyLDkgQEAgc3Rh dGljIHZvbGF0aWxlIHNpZ19hdG9taWNfdCBpbl9yZXN0b3JlX2NvbW1hbmQgPSBmYWxzZTsK IHN0YXRpYyB2b2lkIFN0YXJ0dXBQcm9jVHJpZ2dlckhhbmRsZXIoU0lHTkFMX0FSR1MpOwog c3RhdGljIHZvaWQgU3RhcnR1cFByb2NTaWdIdXBIYW5kbGVyKFNJR05BTF9BUkdTKTsKIAor LyogQ2FsbGJhY2tzICovCitzdGF0aWMgdm9pZCBTdGFydHVwUHJvY0V4aXQoaW50IGNvZGUs IERhdHVtIGFyZyk7CisKIAogLyogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K ICAqCQlzaWduYWwgaGFuZGxlciByb3V0aW5lcwpAQCAtMTgzLDYgKzE4NiwxOSBAQCBIYW5k bGVTdGFydHVwUHJvY0ludGVycnVwdHModm9pZCkKIH0KIAogCisvKiAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQorICoJCXNpZ25hbCBoYW5kbGVyIHJvdXRpbmVzCisgKiAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorICovCitzdGF0aWMgdm9pZAorU3Rh cnR1cFByb2NFeGl0KGludCBjb2RlLCBEYXR1bSBhcmcpCit7CisJLyogU2h1dGRvd24gdGhl IHJlY292ZXJ5IGVudmlyb25tZW50ICovCisJaWYgKHN0YW5kYnlTdGF0ZSAhPSBTVEFOREJZ X0RJU0FCTEVEKQorCQlTaHV0ZG93blJlY292ZXJ5VHJhbnNhY3Rpb25FbnZpcm9ubWVudCgp OworfQorCisKIC8qIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICAqCVN0 YXJ0dXAgUHJvY2VzcyBtYWluIGVudHJ5IHBvaW50CiAgKiAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCkBAIC0xOTAsNiArMjA2LDkgQEAgSGFuZGxlU3RhcnR1cFByb2NJ bnRlcnJ1cHRzKHZvaWQpCiB2b2lkCiBTdGFydHVwUHJvY2Vzc01haW4odm9pZCkKIHsKKwkv KiBBcnJhbmdlIHRvIGNsZWFuIHVwIGF0IHN0YXJ0dXAgcHJvY2VzcyBleGl0ICovCisJb25f c2htZW1fZXhpdChTdGFydHVwUHJvY0V4aXQsIDApOworCiAJLyoKIAkgKiBQcm9wZXJseSBh Y2NlcHQgb3IgaWdub3JlIHNpZ25hbHMgdGhlIHBvc3RtYXN0ZXIgbWlnaHQgc2VuZCB1cy4K IAkgKi8KZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3N0YW5kYnkuYyBi L3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3N0YW5kYnkuYwppbmRleCAxN2RlNWE2ZDBlLi4x NDY1ZWU0NGExIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9zdGFuZGJ5 LmMKKysrIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9pcGMvc3RhbmRieS5jCkBAIC0xMjcsMTAg KzEyNywyNSBAQCBJbml0UmVjb3ZlcnlUcmFuc2FjdGlvbkVudmlyb25tZW50KHZvaWQpCiAg KgogICogUHJlcGFyZSB0byBzd2l0Y2ggZnJvbSBob3Qgc3RhbmRieSBtb2RlIHRvIG5vcm1h bCBvcGVyYXRpb24uIFNodXQgZG93bgogICogcmVjb3ZlcnktdGltZSB0cmFuc2FjdGlvbiB0 cmFja2luZy4KKyAqCisgKiBUaGlzIG11c3QgYmUgY2FsbGVkIGV2ZW4gaW4gc2h1dGRvd24g b2Ygc3RhcnR1cCBwcm9jZXNzIGlmIHRyYW5zYWN0aW9uCisgKiB0cmFja2luZyBoYXMgYmVl biBpbml0aWFsaXplZC4gT3RoZXJ3aXNlIHNvbWUgbG9ja3MgdGhlIHRyYWNrZWQKKyAqIHRy YW5zYWN0aW9ucyB3ZXJlIGhvbGRpbmcgd2lsbCBub3QgYmUgcmVsZWFzZWQgYW5kIGFuZCBt YXkgaW50ZXJmZXJlIHdpdGgKKyAqIHRoZSBwcm9jZXNzZXMgc3RpbGwgcnVubmluZyAoYnV0 IHdpbGwgZXhpdCBzb29uIGxhdGVyKSBhdCB0aGUgZXhpdCBvZgorICogc3RhcnR1cCBwcm9j ZXNzLgogICovCiB2b2lkCiBTaHV0ZG93blJlY292ZXJ5VHJhbnNhY3Rpb25FbnZpcm9ubWVu dCh2b2lkKQogeworCS8qCisJICogRG8gbm90aGluZyBpZiBSZWNvdmVyeUxvY2tMaXN0cyBp cyBOVUxMIGJlY2F1c2Ugd2hpY2ggbWVhbnMgdGhhdAorCSAqIHRyYW5zYWN0aW9uIHRyYWNr aW5nIGhhcyBub3QgYmVlbiB5ZXQgaW5pdGlhbGl6ZWQgb3IgaGFzIGJlZW4gYWxyZWFkeQor CSAqIHNodXRkb3duZWQuIFRoaXMgcHJldmVudHMgdHJhbnNhY3Rpb24gdHJhY2tpbmcgZnJv bSBiZWluZyBzaHV0ZG93bmVkCisJICogdW5leHBlY3RlZGx5IG1vcmUgdGhhbiBvbmNlLgor CSAqLworCWlmIChSZWNvdmVyeUxvY2tMaXN0cyA9PSBOVUxMKQorCQlyZXR1cm47CisKIAkv KiBNYXJrIGFsbCB0cmFja2VkIGluLXByb2dyZXNzIHRyYW5zYWN0aW9ucyBhcyBmaW5pc2hl ZC4gKi8KIAlFeHBpcmVBbGxLbm93bkFzc2lnbmVkVHJhbnNhY3Rpb25JZHMoKTsKIAo= --------------7DBB63347227619C03973A07--