Content-Type: multipart/mixed; boundary="------------9j383dEtwX2OIPCLdrGDjCVn"
Message-ID: <ba567012-bff5-465a-8ee7-913b32f45d89@gmail.com>
Date: Mon, 6 Apr 2026 14:55:25 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: ru
To: pgsql-hackers <pgsql-hackers@postgresql.org>
From: =?UTF-8?B?0JjQu9GM0Y8g0KfQtdGA0LTQsNC60L7Qsg==?=
 <i.cherdakov.pg@gmail.com>
Subject: Environment variable to disable diffs file output
Cc: postgres@jeltef.nl
Archived-At: 
 <https://www.postgresql.org/message-id/ba567012-bff5-465a-8ee7-913b32f45d89%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------9j383dEtwX2OIPCLdrGDjCVn
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Greetings!

I'd like to add a environment variable to the patch to
disable diff output. Sometimes you have to be creative
with exploratory testing, modifying test files, etc.,
and multiple diff outputs can become a nuisance. This
doesn't change the default behavior, but it does give
you control over diff output in tests for specific
scenarios where a large number of failures are expected
(mass runs or exploratory testing with changing tests).

The env usage and implementation are somewhat similar
to PG_REGRESS_DIFF_OPTS
     PG_REGRESS_DISABLE_DIFFS_OUTPUT=1 make check -s.

For now, I suggest to simply disabling it, but I'm also
considering passing the number of lines to output via env
or via flag pg_regress instead of completely disabling it.
Something like
     PG_REGRESS_DIFFS_NUMBER_LINES_OUTPUT=20 make check
and then when an error occurs, 20 lines will be output
instead of the default 80. Setting it to 0 disables
diffs output.


I think this small addition will be useful for many
developers, especially testers.
---
This is my first patch. I welcome critique and comments.
Best regards,
Ilya Cherdakov, PostgresPro
--------------9j383dEtwX2OIPCLdrGDjCVn
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-Adding-env-disables-diff-output.patch"
Content-Disposition: attachment;
 filename="v1-0001-Adding-env-disables-diff-output.patch"
Content-Transfer-Encoding: base64

RnJvbSBhZWNlMzUyN2YyOWRjYWYyNzMxZWY5OWE0ZDk1Yzc5MmZhY2RmNjNkIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBJbHlhIENoZXJkYWtvdiA8aS5jaGVyZGFrb3ZAcG9z
dGdyZXNwcm8ucnU+CkRhdGU6IE1vbiwgNiBBcHIgMjAyNiAxMDoxODoyMiArMDMwMApTdWJq
ZWN0OiBbUEFUQ0ggdjFdIEFkZGluZy1lbnYtZGlzYWJsZXMtZGlmZi1vdXRwdXQKCi0tLQog
c3JjL3Rlc3QvcmVncmVzcy9wZ19yZWdyZXNzLmMgfCA3ICsrKysrKysKIDEgZmlsZSBjaGFu
Z2VkLCA3IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL3Bn
X3JlZ3Jlc3MuYyBiL3NyYy90ZXN0L3JlZ3Jlc3MvcGdfcmVncmVzcy5jCmluZGV4IDlhOTE4
MTU2NDM3Li4wNmFmMjQ2OTliNCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9wZ19y
ZWdyZXNzLmMKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9wZ19yZWdyZXNzLmMKQEAgLTE1NTAs
NiArMTU1MCwxMyBAQCByZXN1bHRzX2RpZmZlcihjb25zdCBjaGFyICp0ZXN0bmFtZSwgY29u
c3QgY2hhciAqcmVzdWx0c2ZpbGUsIGNvbnN0IGNoYXIgKmRlZmF1bAogCQkJCSBwcmV0dHlf
ZGlmZl9vcHRzLCBiZXN0X2V4cGVjdF9maWxlLCByZXN1bHRzZmlsZSwgZGlmZmZpbGVuYW1l
KTsKIAkJcnVuX2RpZmYoY21kLCBkaWZmZmlsZW5hbWUpOwogCisJCS8qIERpc2FibGluZyBk
aWZmZmlsZSBvdXRwdXQgdmlhIGFuIGVudmlyb25tZW50IHZhcmlhYmxlICovCisJCWlmIChn
ZXRlbnYoIlBHX1JFR1JFU1NfRElTQUJMRV9ESUZGU19PVVRQVVQiKSAhPSBOVUxMKQorCQl7
CisJCQl1bmxpbmsoZGlmZik7CisJCQlyZXR1cm4gdHJ1ZTsKKwkJfQorCiAJCS8qCiAJCSAq
IFJlb3BlbiB0aGUgZmlsZSBmb3IgcmVhZGluZyB0byBlbWl0IHRoZSBkaWZmIGFzIFRBUCBk
aWFnbm9zdGljcy4gV2UKIAkJICogY2FuJ3Qga2VlcCB0aGUgZmlsZSBvcGVuIHdoaWxlIGRp
ZmYgYXBwZW5kcyB0byBpdCwgYmVjYXVzZSBvbgotLSAKMi40Ny4zCgo=

--------------9j383dEtwX2OIPCLdrGDjCVn--