Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r18d4-009WAG-Nc for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Nov 2023 17:15:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r18d2-00FyJP-2o for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Nov 2023 17:15:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r18d1-00FyJH-L5 for pgsql-hackers@lists.postgresql.org; Thu, 09 Nov 2023 17:15:39 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r18cx-005Z7f-Ju for pgsql-hackers@lists.postgresql.org; Thu, 09 Nov 2023 17:15:38 +0000 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1cc394f4cdfso9292725ad.0 for ; Thu, 09 Nov 2023 09:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=illuminatedcomputing-com.20230601.gappssmtp.com; s=20230601; t=1699550133; x=1700154933; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rs3v58oiJ4UvIPAHmFhOin6H9GTNhdTdhaanNTNoJ7Y=; b=cW6F001cVadPrCeHt8+3S8B9L3GgmNujZeqeoG7DU5EMjq9WPAnHH4mF3P4ROb5yx0 RMgZ+KAazwE5NLhqodXeQ5D9XOaB7eqULXanOXakGGaDTMe2dE3yz4NmJYZ6GkQ+nVC1 ozVJmP6D2Z/2TzPjoLBf3Dlo+Nhcf0KjeqO4yDwPtuwx/ZEnzs+2xSPaQox84SKTu0Qn rXwlMij/gula8NjY7l6qoQSR/ViESD8o+SOvKhPuzV/eQ6NkQNUMJ9+L6+L0SG1UNfy0 y05xRfFHjpEbV49wG07Gas6KPa+A/JS8rpM2W9ncovRTAAnl7RPX/kE/h4s5qtBf/xZt GRXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699550133; x=1700154933; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rs3v58oiJ4UvIPAHmFhOin6H9GTNhdTdhaanNTNoJ7Y=; b=oz1nuZ/Vsvi7K0eTjiApT6LoIzEddV+kMQTkuA7YpacBK7egQ7qa7yibpQGqYFt2u2 iAZlR4knQQxSKz3B/3gl/Ae1ibK9fx6wS8hnFjkn5Mwn+eymyrg+WWJtzfeh57P8NBT0 oLS0W3ovzG2vli/LKX0/K3jnqKCRsjNCV789TLVoTGZUZVx3aILrucKKUgqmifHuB/0o yL5xXCCG9wHudDnoJ0V7ATE3UXpDm8EV/rfik7R5J0XXgzuwNSdaLBChFX95vQUyKZNE E2WM2Es5EHlkhgl6exArAAuntRbkUAqOIfBLE5d1g3qCKfroRHM5roOnHLYgTWRVRapT pAag== X-Gm-Message-State: AOJu0Yy+eMsE9jKsBcSkE8TgPoGbvTaTnpqOOVnM4hWcSv7dKY4KkdbM ZrAgBXQFES7ZHztQY6YNAPFsgw== X-Google-Smtp-Source: AGHT+IEMamonEQ2RT36KxKOktJ6VsHyuutrHxit4WMWJz7fa2DuWfZxQG1Hj7+CPgoAqWyVfJr5CGg== X-Received: by 2002:a17:903:124e:b0:1cc:636f:f376 with SMTP id u14-20020a170903124e00b001cc636ff376mr5698959plh.44.1699550133183; Thu, 09 Nov 2023 09:15:33 -0800 (PST) Received: from [192.168.2.139] ([50.53.98.191]) by smtp.googlemail.com with ESMTPSA id g19-20020a170902869300b001c9ccbb8fdasm3771058plo.260.2023.11.09.09.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 09:15:32 -0800 (PST) Message-ID: Date: Thu, 9 Nov 2023 09:15:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: SQL:2011 application time Content-Language: en-US To: Peter Eisentraut , jian he Cc: PostgreSQL Hackers References: <5157e85a-6007-27a7-853a-5601d9c3722f@illuminatedcomputing.com> <5a16a59a-d497-7d72-07aa-0afc09d5193a@illuminatedcomputing.com> <2d9740ad-3bb7-473c-8441-344351caa8ee@illuminatedcomputing.com> From: Paul Jungwirth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 11/9/23 05:47, Peter Eisentraut wrote: > I went over the patch > v17-0001-Add-temporal-PRIMARY-KEY-and-UNIQUE-constraints.patch in more > detail Thanks Peter! I'm about halfway through jian he's last two emails. I'll address your feedback also. I wanted to reply to this without waiting though: > Overall, with these fixes, I think this patch is structurally okay.  We > just need to make sure we have all the weird corner cases covered. One remaining issue I know about is with table partitions whose column order has changed. I've got an in-progress fix for that, but I've been prioritizing reviewer feedback the last few months. Just want to make sure you know about it for now. Thanks! -- Paul ~{:-) pj@illuminatedcomputing.com