Subject: Re: bugfix: when the blocksize is 32k, the function page_header of
 pageinspect returns negative numbers.
To: Michael Paquier <michael@paquier.xyz>,
 Justin Pryzby <pryzby@telsasoft.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 pgsql-hackers@postgresql.org
References: <8b8ec36e-61fe-14f9-005d-07bc85aa4eed@yeah.net>
 <CALj2ACVvmn7RsV9BmXLKv9M-7WZtabyyALECsY_iKbz4Cj1VtA@mail.gmail.com>
 <YOZ70IxyhdGzn6OE@paquier.xyz> <20210708042806.GA22043@telsasoft.com>
 <YOavSelqzR6bT1j+@paquier.xyz>
From: Quan Zongliang <quanzongliang@yeah.net>
Message-ID: <ba664e6a-1b83-e7a7-5f69-7dfd99a49e45@yeah.net>
Date: Thu, 8 Jul 2021 18:02:03 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <YOavSelqzR6bT1j+@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/ba664e6a-1b83-e7a7-5f69-7dfd99a49e45%40yeah.net>
Precedence: bulk


On 2021/7/8 3:54 下午, Michael Paquier wrote:
> On Wed, Jul 07, 2021 at 11:28:06PM -0500, Justin Pryzby wrote:
>> I think you can refer to this prior commit for guidance.
>>
>> commit f18aa1b203930ed28cfe42e82d3418ae6277576d
>> Author: Peter Eisentraut <peter@eisentraut.org>
>> Date:   Tue Jan 19 10:28:05 2021 +0100
>>
>>      pageinspect: Change block number arguments to bigint
> 
> Yes, thanks.  Peter's recent work is what I had in mind.  I agree that
> we could improve the situation, and the change is not complicated once
> you know what needs to be done.  It needs to be done as follows:
> - Create a new pageinspect--1.9--1.10.sql.
> - Provide a proper implementation for older extension version based on
> the output parameter types, with a lookup at the TupleDesc for the
> function to adapt.
> - Add tests to sql/oldextversions.sql to stress the old function based
> on smallint results.
> - Bump pageinspect.control.
> 
> Quan, would you like to produce a patch?  That's a good exercise to
> understand how the maintenance of extensions is done.

Ok. I'll do it.

> --
> Michael
>