Feedback-ID: i131946ab:Fastmail
Content-Type: multipart/mixed; boundary="------------6J9Sltw1uMY02Vvh0EdYd1dj"
Message-ID: <ba6d4fac-9e33-91f9-94fb-1e4c144a48b9@enterprisedb.com>
Date: Mon, 23 May 2022 11:53:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.0
Subject: Re: Frontend error logging style
Content-Language: en-US
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <YZMfMI3kTDw/RU0k@paquier.xyz>
 <CA+TgmoZy84orCfUNipEp+QzWwRuR2yrjsdcJN9ROHzPkXDRbxQ@mail.gmail.com>
 <a06f311b-18cd-ee56-ad4c-03ed0f93713f@enterprisedb.com>
 <CA+TgmoYaA1wtU91yNg1_C6oS8azAfp5dQ1YrfuNAm2=Yefrn1A@mail.gmail.com>
 <913687.1645572199@sss.pgh.pa.us>
 <6fdb3ab3-f093-27b9-dfdc-c391e69163fc@enterprisedb.com>
 <1346360.1645715441@sss.pgh.pa.us> <1895619.1645809325@sss.pgh.pa.us>
 <20220322015135.k4tcd3tsjq5xydqa@alap3.anarazel.de>
 <2446238.1647914437@sss.pgh.pa.us>
 <20220322021348.pvtvgrseyfohkxob@alap3.anarazel.de>
 <471299.1648412393@sss.pgh.pa.us>
 <6acbce27-3472-fc58-538b-ba6770ed0bfa@enterprisedb.com>
In-Reply-To: <6acbce27-3472-fc58-538b-ba6770ed0bfa@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ba6d4fac-9e33-91f9-94fb-1e4c144a48b9%40enterprisedb.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------6J9Sltw1uMY02Vvh0EdYd1dj
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 29.03.22 16:24, Peter Eisentraut wrote:
> I think I would want the program name/location also in front of the 
> detail and hint lines.  I need to think about this a bit more.  This 
> shouldn't hold up this patch; it would be a quick localized change.

After experiencing this for a bit now, I propose to make this change.
It lines up better and allows easier filtering of messages by program.

Example:

Before:

initdb: error: locale "zh_HK.Big5HKSCS" requires unsupported encoding "BIG5"
detail: Encoding "BIG5" is not allowed as a server-side encoding.
hint: Rerun initdb with a different locale selection.

After:

initdb: error: locale "zh_HK.Big5HKSCS" requires unsupported encoding "BIG5"
initdb: detail: Encoding "BIG5" is not allowed as a server-side encoding.
initdb: hint: Rerun initdb with a different locale selection.
--------------6J9Sltw1uMY02Vvh0EdYd1dj
Content-Type: text/plain; charset=UTF-8;
 name="0001-logging-Also-add-the-command-prefix-to-detail-and-hi.patch"
Content-Disposition: attachment;
 filename*0="0001-logging-Also-add-the-command-prefix-to-detail-and-hi.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA1NjVmZTU2ZWJmOTQ0OWNkOTE0MzQyNGVmMWI4MDgzZDk5MDE5ZDc1IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogTW9uLCAyMyBNYXkgMjAyMiAxMTo0NDozMiArMDIwMApTdWJqZWN0
OiBbUEFUQ0hdIGxvZ2dpbmc6IEFsc28gYWRkIHRoZSBjb21tYW5kIHByZWZpeCB0byBkZXRh
aWwgYW5kIGhpbnQKIG1lc3NhZ2VzCgpUaGlzIG1ha2VzIHRoZSBvdXRwdXQgbGluZSB1cCBi
ZXR0ZXIgYW5kIGFsbG93cyBmaWx0ZXJpbmcgbWVzc2FnZXMgYnkKY29tbWFuZC4KLS0tCiBz
cmMvYmluL3BnX2R1bXAvdC8wMDNfcGdfZHVtcF93aXRoX3NlcnZlci5wbCB8IDIgKy0KIHNy
Yy9jb21tb24vbG9nZ2luZy5jICAgICAgICAgICAgICAgICAgICAgICAgIHwgMyArLS0KIDIg
ZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAt
LWdpdCBhL3NyYy9iaW4vcGdfZHVtcC90LzAwM19wZ19kdW1wX3dpdGhfc2VydmVyLnBsIGIv
c3JjL2Jpbi9wZ19kdW1wL3QvMDAzX3BnX2R1bXBfd2l0aF9zZXJ2ZXIucGwKaW5kZXggYTBi
MjNhYWUwZi4uOGNjOWRhMDY1OSAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ19kdW1wL3QvMDAz
X3BnX2R1bXBfd2l0aF9zZXJ2ZXIucGwKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3QvMDAzX3Bn
X2R1bXBfd2l0aF9zZXJ2ZXIucGwKQEAgLTMwLDcgKzMwLDcgQEAKIAogY29tbWFuZF9mYWls
c19saWtlKAogCVsgInBnX2R1bXAiLCAnLXAnLCAkcG9ydCwgJy0taW5jbHVkZS1mb3JlaWdu
LWRhdGE9czAnLCAncG9zdGdyZXMnIF0sCi0JcXIvZm9yZWlnbi1kYXRhIHdyYXBwZXIgXCJk
dW1teVwiIGhhcyBubyBoYW5kbGVyXHI/XG5kZXRhaWw6IFF1ZXJ5IHdhczogLip0MC8sCisJ
cXIvZm9yZWlnbi1kYXRhIHdyYXBwZXIgXCJkdW1teVwiIGhhcyBubyBoYW5kbGVyXHI/XG5w
Z19kdW1wOiBkZXRhaWw6IFF1ZXJ5IHdhczogLip0MC8sCiAJImNvcnJlY3RseSBmYWlscyB0
byBkdW1wIGEgZm9yZWlnbiB0YWJsZSBmcm9tIGEgZHVtbXkgRkRXIik7CiAKIGNvbW1hbmRf
b2soCmRpZmYgLS1naXQgYS9zcmMvY29tbW9uL2xvZ2dpbmcuYyBiL3NyYy9jb21tb24vbG9n
Z2luZy5jCmluZGV4IDBiNWJjYjFhMTcuLjY0NjA0YzUyMDkgMTAwNjQ0Ci0tLSBhL3NyYy9j
b21tb24vbG9nZ2luZy5jCisrKyBiL3NyYy9jb21tb24vbG9nZ2luZy5jCkBAIC0yNDYsOCAr
MjQ2LDcgQEAgcGdfbG9nX2dlbmVyaWNfdihlbnVtIHBnX2xvZ19sZXZlbCBsZXZlbCwgZW51
bSBwZ19sb2dfcGFydCBwYXJ0LAogCiAJZm10ID0gXyhmbXQpOwogCi0JaWYgKHBhcnQgPT0g
UEdfTE9HX1BSSU1BUlkgJiYKLQkJKCEobG9nX2ZsYWdzICYgUEdfTE9HX0ZMQUdfVEVSU0Up
IHx8IGZpbGVuYW1lKSkKKwlpZiAoIShsb2dfZmxhZ3MgJiBQR19MT0dfRkxBR19URVJTRSkg
fHwgZmlsZW5hbWUpCiAJewogCQlpZiAoc2dyX2xvY3VzKQogCQkJZnByaW50ZihzdGRlcnIs
IEFOU0lfRVNDQVBFX0ZNVCwgc2dyX2xvY3VzKTsKLS0gCjIuMzYuMQoK

--------------6J9Sltw1uMY02Vvh0EdYd1dj--