Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1o9YhX-0002Ex-IH
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Jul 2022 21:06:19 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1o9YhV-0004vf-M5
	for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Jul 2022 21:06:17 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <david@pgmasters.net>)
	id 1o9YhV-0004vW-D8
	for pgsql-hackers@lists.postgresql.org; Thu, 07 Jul 2022 21:06:17 +0000
Received: from mail.thelabyrinth.net ([45.56.70.56])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <david@pgmasters.net>)
	id 1o9YhT-0008OU-31
	for pgsql-hackers@postgresql.org; Thu, 07 Jul 2022 21:06:16 +0000
Received: from [172.20.20.20] (c-24-126-12-194.hsd1.wv.comcast.net
 [24.126.12.194])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: dsteele)
	by mail.thelabyrinth.net (Postfix) with ESMTPSA id 117DF5466A;
	Thu,  7 Jul 2022 21:06:13 +0000 (UTC)
Message-ID: <ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net>
Date: Thu, 7 Jul 2022 17:06:13 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: remove more archiving overhead
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Fujii Masao <masao.fujii@oss.nttdata.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <20220222173711.GA3852671@nathanxps13>
 <20220222195229.GA42988@nathanxps13>
 <20220224.141349.1809640551882183816.horikyota.ntt@gmail.com>
 <20220224175553.GA660690@nathanxps13> <20220407222327.GA1363808@nathanxps13>
 <768e6cb3-256d-9c0b-1797-62420ffca7ae@oss.nttdata.com>
 <CA+TgmoaeTe4oUT39A4nt=8LD6UJ5u0vcmGc5+Aksn-4oKRb8-w@mail.gmail.com>
 <17147b74-5465-9a7a-ae27-305d1200482c@pgmasters.net>
 <20220707161825.GA2205004@nathanxps13> <20220707175142.GA2254092@nathanxps13>
 <20220707182251.GA2255242@nathanxps13>
From: David Steele <david@pgmasters.net>
In-Reply-To: <20220707182251.GA2255242@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/ba7e11b0-054d-1d26-bafd-7a2bc97f11f7%40pgmasters.net>
Precedence: bulk

On 7/7/22 14:22, Nathan Bossart wrote:
> On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
>> +    library to ensure that it indeed does not overwrite an existing file.  When
>> +    a pre-existing file is encountered, the archive library may return
>> +    <literal>true</literal> if the WAL file has identical contents to the
>> +    pre-existing archive.  Alternatively, the archive library can return
> 
> This should likely say something about ensuring the pre-existing file is
> persisted to disk before returning true.

Agreed.

Also, I'd prefer to remove "indeed" from this sentence (yes, I see that 
was in the original text):

+    library to ensure that it indeed does not overwrite an existing

Regards,
-David