public inbox for [email protected]
help / color / mirror / Atom feedFrom: Drouvot, Bertrand <[email protected]>
To: shveta malik <[email protected]>
To: Amit Kapila <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Ashutosh Sharma <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Ajin Cherian <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: Re: Synchronizing slots from primary to standby
Date: Tue, 28 Nov 2023 07:49:48 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJpy0uD+yYq+2F0N8hVGSjz6YwbScFGB_fME6E831Fbg0_hkMg@mail.gmail.com>
References: <CAJpy0uC+2agRtF3H=n-hW5JkoPfaZkjPXJr==y3_PRE04dQvhw@mail.gmail.com>
<OS0PR01MB5716CE0729CEB3B5994A954194B3A@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<[email protected]>
<CAJpy0uAT-oGsgmb4dC=dYYRNY7WXEAAWGWU2kL5phLz3Wcdifg@mail.gmail.com>
<CAA4eK1J=-kPHS1eHNBtzOQHZ64j6WSgSYQZ3fH=2vfiwy_48AA@mail.gmail.com>
<CAJpy0uB_y_1akXUWM9WnSdQ-NVWTnHTpmNu6gJQ5tnyuAMTUOg@mail.gmail.com>
<CAHut+Pv-yu71ogj_hRi6cCtmD55bsyw7XTxj1Nq8yVFKpY3NDQ@mail.gmail.com>
<OS0PR01MB571646B8186F6A06404BD50194BDA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<OS0PR01MB57161C27BCFAF04C2B48B47394BDA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<[email protected]>
<CAJpy0uDKPK537ZW8CAjDVmSjHtBKCzTUzq=it84SrA0PfoWFCg@mail.gmail.com>
<OS0PR01MB57161938A348977127D56A6694BDA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
<CAA4eK1+V_KQjdDzW8EivuhYNTqfNiH_zToU4yE1GYY_TKpQzRA@mail.gmail.com>
<CAJpy0uD+yYq+2F0N8hVGSjz6YwbScFGB_fME6E831Fbg0_hkMg@mail.gmail.com>
Hi,
On 11/28/23 4:13 AM, shveta malik wrote:
> On Mon, Nov 27, 2023 at 4:08 PM Amit Kapila <[email protected]> wrote:
>>
>> On Mon, Nov 27, 2023 at 2:27 PM Zhijie Hou (Fujitsu)
>> <[email protected]> wrote:
>>>
>>> Here is the updated version(v39_2) which include all the changes made in 0002.
>>> Please use for review, and sorry for the confusion.
>>>
>>
>> --- a/src/backend/replication/logical/launcher.c
>> +++ b/src/backend/replication/logical/launcher.c
>> @@ -8,20 +8,27 @@
>> * src/backend/replication/logical/launcher.c
>> *
>> * NOTES
>> - * This module contains the logical replication worker launcher which
>> - * uses the background worker infrastructure to start the logical
>> - * replication workers for every enabled subscription.
>> + * This module contains the replication worker launcher which
>> + * uses the background worker infrastructure to:
>> + * a) start the logical replication workers for every enabled subscription
>> + * when not in standby_mode.
>> + * b) start the slot sync worker for logical failover slots synchronization
>> + * from the primary server when in standby_mode.
>>
>> I was wondering do we really need a launcher on standby to invoke
>> sync-slot worker. If so, why? I guess it may be required for previous
>> versions where we were managing work for multiple slot-sync workers
>> which is also questionable in the sense of whether launcher is the
>> right candidate for the same but now with the single slot-sync worker,
>> it doesn't seem worth having it. What do you think?
>>
>> --
>
> Yes, earlier a manager process was needed to manage multiple slot-sync
> workers and distribute load among them, but now that does not seem
> necessary. I gave it a try (PoC) and it seems to work well. If there
> are no objections to this approach, I can share the patch soon.
>
+1 on this new approach, thanks!
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (108+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Synchronizing slots from primary to standby
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox