Feedback-ID: ie0a040ee:Fastmail
Message-ID: <bb56b5ce-7600-4815-a4ab-88c52c58fb81@eisentraut.org>
Date: Mon, 30 Mar 2026 23:50:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
 <44885d54-0376-46b3-b574-59e0e3098580@eisentraut.org>
 <dfb1373e-258f-42b7-ac76-0f5858936dfa@eisentraut.org>
 <4ab608af-2f90-47d8-88a5-6329f6630fff@eisentraut.org>
 <acI6X6YmtHnEURKL@ip-10-97-1-34.eu-west-3.compute.internal>
 <ff1b26a3-7f36-474a-93f1-bb9afcc7cf87@eisentraut.org>
 <acZW7FB/bB2Kh5j1@ip-10-97-1-34.eu-west-3.compute.internal>
 <7bf60ab1-2b5d-4a77-93ce-815072a0a014@eisentraut.org>
 <acaEwtP0sn0HAlLG@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <acaEwtP0sn0HAlLG@ip-10-97-1-34.eu-west-3.compute.internal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/bb56b5ce-7600-4815-a4ab-88c52c58fb81%40eisentraut.org>
Precedence: bulk

On 27.03.26 14:23, Bertrand Drouvot wrote:
> Hi,
> 
> On Fri, Mar 27, 2026 at 01:15:29PM +0100, Peter Eisentraut wrote:
>> On 27.03.26 11:07, Bertrand Drouvot wrote:
>>> That looks ok but I wonder if we should also add '-Werror=vla' to it (
>>> and remove it from common_warning_flags) to be in sync with what configure.ac
>>> is doing:
>>>
>>> "
>>>     PGAC_PROG_CC_CFLAGS_OPT([-Werror=vla])
>>>     # -Wvla is not applicable for C++
>>> "
>>
>> Hmm.  This comment is not actually fully correct.  With g++, you can write a
>> VLA and it will work, and also -Wvla will warn about it.  So we should
>> actually add that option to C++ as well.  (It is true that VLAs are not in
>> standard C++, and g++ with -pedantic will also warn about it.)
> 
> Oh right, just did a few tests and agree with your comment above. I agree that
> it should also be added for C++ in autoconf then.
> 
> What about the attached?
> 
> That said, your patch LGTM given that the VLA remark was not appropriate.

Ok, both committed.