Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tGCzV-001XIX-D1
	for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2024 08:01:41 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1tGCzT-00D3QO-Sy
	for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2024 08:01:39 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter@eisentraut.org>)
	id 1tGCzS-00D3O5-FJ
	for pgsql-hackers@lists.postgresql.org; Wed, 27 Nov 2024 08:01:39 +0000
Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter@eisentraut.org>)
	id 1tGCzL-0047Ih-JA
	for pgsql-hackers@postgresql.org; Wed, 27 Nov 2024 08:01:37 +0000
Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44])
	by mailfout.phl.internal (Postfix) with ESMTP id 1168413802B9;
	Wed, 27 Nov 2024 03:01:30 -0500 (EST)
Received: from phl-mailfrontend-01 ([10.202.2.162])
  by phl-compute-04.internal (MEProxy); Wed, 27 Nov 2024 03:01:30 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org;
	 h=cc:cc:content-transfer-encoding:content-type:content-type
	:date:date:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:subject:subject:to:to; s=fm3;
	 t=1732694490; x=1732780890; bh=norIofSWfAZG52zNO55J06b+bEizpwSy
	3hqruHyirNU=; b=Flc/Axzj7ZNNXLRc7VJ1opgjJgwvc3y713FUyN82chxxEh8S
	gAOCX+M7CxgIaN0gP6mlm4iE/cZvTnwJ1hRil0Y4YZx45vemGABr2bNd3uNNn7LE
	b7DVPoD1i3k+zV4q2vE1ank9lHiJiiwD9+/rEC+P9SCXtZmF8YoJR+ow7mZqXDDw
	tlFPj1SyGwpLdUxDXMXQUyVSAagsGqDUA2NaY9I2W8hLxogimFlLrmcvJsdzlROQ
	2Yh7UKmc/c073Rpi/1/VyhGDHcxwb7PLnqmgBJeMV3zwlW2V4amfOEb1p1/HSrQ+
	KZ138NWVA/MSyown9Q3jAbA7zZRd58fpBHa03Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:content-type:date:date:feedback-id:feedback-id
	:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:subject:subject:to:to:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1732694490; x=
	1732780890; bh=norIofSWfAZG52zNO55J06b+bEizpwSy3hqruHyirNU=; b=s
	T4HddNqdhKghjm8a1EBzQXRNka5mT5XuHw4pWvjVWNiTB1xzf8NPOKUtm7hNDmjC
	0YdWK1quwZSeWF1e4J+PUExRVAmmktZCyja3UUYvzKTO1czTRWtDo8OERrcRku5Z
	uK7nsy5aTY5XVqbbrAoTZJrA5H8BehKKV7RTvA3zG9IshvzWzFtetbiOJhuyg5Sa
	XJjUFN+xU/gryFLeVXq0DFyy5yqvhl9BwW94Fs6uJLs+OoGXEFyk0RsO8GSnc2mz
	ikOiaGL0bZPhRRIgFWywyLEluyFqBxE1vfkBFw8zBpZK0F267SkBlkcmZsJMo7OP
	FcU5k1nSwungNI99GWEjQ==
X-ME-Sender: <xms:2dFGZylK-YnG2uS4Xj3jqGf-GVztnmQIJevRiKAz9c3rK9oIyNU2xA>
    <xme:2dFGZ52Fh-sWN2-mcPE-1AcFZI3Sx8bgfQIwjOxDbZYJn_q917yBllKTnTmoSB9nK
    CiGC54FwCN4O0zE_w>
X-ME-Received: <xmr:2dFGZwpK21RplgnyQQ7MKVtxrQReaeiT_VB7ZZUWYaQN2m5fmrAHz4TAWUGZrD5VdXE1NVmcdjdUb7Q_Fn4SpmDLXtu_ffw7>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeekgdduudefucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu
    rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh
    htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej
    necuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvg
    hnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepgfejtdfhkeeftdeugfeileeh
    teeljeeghfeuledthfeutedvffdukeefjefhgeehnecuvehluhhsthgvrhfuihiivgeptd
    enucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdho
    rhhgpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphhtthhope
    hjihgrnhdruhhnihhvvghrshgrlhhithihsehgmhgrihhlrdgtohhmpdhrtghpthhtohep
    hhhlihhnnhgrkhgrsehikhhirdhfihdprhgtphhtthhopehjrggtohgsrdgthhgrmhhpih
    honhesvghnthgvrhhprhhishgvuggsrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgr
    tghkvghrshesphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepuggrnhhivghlse
    hmrghnihhtohhuqdhmrghilhdrohhrghdprhgtphhtthhopehpjhesihhllhhumhhinhgr
    thgvuggtohhmphhuthhinhhgrdgtohhm
X-ME-Proxy: <xmx:2dFGZ2nu_lelXrX565lVD4bzDLELGmI8lZW9MIMpZ_SbYnkGCeAjMw>
    <xmx:2dFGZw2dzZSDEvm-NeNxLODlxqGOfmR8_9XPDl8mryhItjpnqbCOVg>
    <xmx:2dFGZ9soiKWfB1zbA9gWZJ_bOV3QkxLCsruauobp227a-jbs-u37QQ>
    <xmx:2dFGZ8W4L9bQGgR8SEWM0lgO0RYZJblReBAq1A3u6RAfgMrMVNEE8A>
    <xmx:2tFGZ6qL4aAAVLdN8J_GXNxDKi8zWMMQy3l8YkKgdXrznHeLQn2eowIe>
Feedback-ID: ie0a040ee:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 27 Nov 2024 03:01:28 -0500 (EST)
Message-ID: <bb5c479c-abc8-483f-9bfb-18894dc23a90@eisentraut.org>
Date: Wed, 27 Nov 2024 09:01:26 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Support LIKE with nondeterministic collations
To: jian he <jian.universality@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
 Jacob Champion <jacob.champion@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Daniel Verite <daniel@manitou-mail.org>,
 Paul A Jungwirth <pj@illuminatedcomputing.com>
References: <a827cf68-608e-45cf-9b94-e46f5e9d4171@manitou-mail.org>
 <fdc379ce-4b88-4357-b622-2ae0ef08e295@eisentraut.org>
 <CA+renyWd-_sAj3YqBRaQVOOMr5uQoeBcA3tjCSyQFzvnbGrMYA@mail.gmail.com>
 <ba4dc9f5-fb14-433f-8d53-3dd291585161@eisentraut.org>
 <3104729e-1fbf-4368-ac21-1f670062de28@eisentraut.org>
 <CAOYmi+nqr4xCe9-g4BAupnu2rZmvLy1T3qq3ejOUWOCsoJ4ZdA@mail.gmail.com>
 <0ca761b5-7b62-42a1-bffd-8bedefad48dd@eisentraut.org>
 <bce1da9a-2975-462f-8946-c58c878ba82c@iki.fi>
 <62156cde-b2c5-4375-b47a-9730aa8f7b5e@eisentraut.org>
 <CACJufxFeOuBbkHfp=0-0rwamydjYY4ky1A+CPr6s3WUABC9_Rg@mail.gmail.com>
 <07fdbb85-c530-48d0-adc0-7d43d7951e1b@eisentraut.org>
 <CACJufxHVcgt6ybYLX+R6YYcK=Hc0ctTD_wFfJvrR37yrjYyrww@mail.gmail.com>
 <d57efd38-3db0-40b7-999c-d26bc9259616@eisentraut.org>
 <CACJufxGuBNQzx1LFBpEP01A1SuSndfzMWXHR9vr9bV3A6dB84g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CACJufxGuBNQzx1LFBpEP01A1SuSndfzMWXHR9vr9bV3A6dB84g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/bb5c479c-abc8-483f-9bfb-18894dc23a90%40eisentraut.org>
Precedence: bulk

On 20.11.24 08:29, jian he wrote:
> in match_pattern_prefix maybe change
>      if (expr_coll && !get_collation_isdeterministic(expr_coll))
>          return NIL;
> to
>      if (OidIsValid(expr_coll) && !get_collation_isdeterministic(expr_coll))
>          return NIL;

I left it like it was, because this was existing code that I'm just 
moving around.

> other than that, I didn't find any issue.

I have committed it, thanks.