Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k83mJ-00069n-0e for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Aug 2020 15:43:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1k83mH-0004sg-Ry for pgsql-hackers@arkaria.postgresql.org; Tue, 18 Aug 2020 15:43:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k83mH-0004sY-Gj for pgsql-hackers@lists.postgresql.org; Tue, 18 Aug 2020 15:43:57 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k83mE-0002vZ-Qo for pgsql-hackers@postgresql.org; Tue, 18 Aug 2020 15:43:56 +0000 Received: from hnk.local (p12054-ipngn2901funabasi.chiba.ocn.ne.jp [153.212.171.54]) by oss.nttdata.com (Postfix) with ESMTPSA id 2E54860135; Wed, 19 Aug 2020 00:43:50 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com Subject: Re: track_planning causing performance regression From: Fujii Masao To: Hamid Akhtar Cc: Pavel Stehule , Peter Geoghegan , Julien Rouhaud , "Tharakan, Robins" , "pgsql-hackers@postgresql.org" References: <2895b53b033c47ccb22972b589050dd9@EX13D05UWC001.ant.amazon.com> <42a13b4c-e60c-c6e7-3475-8eff8050bed4@oss.nttdata.com> <646e5cae-5e8b-feaa-43dc-014bf355bf08@oss.nttdata.com> <73b66e99-b4f3-9c4e-3b70-157ddbe81771@oss.nttdata.com> <773565c1-6508-063a-8872-20c16d283ee8@oss.nttdata.com> <94a5cda2-b814-d4a8-59d3-b5f00f889e71@oss.nttdata.com> Message-ID: Date: Wed, 19 Aug 2020 00:43:49 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <94a5cda2-b814-d4a8-59d3-b5f00f889e71@oss.nttdata.com> Content-Type: multipart/mixed; boundary="------------55529784A24B4389BBCF2A84" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------55529784A24B4389BBCF2A84 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > Yes, I pushed the document_overhead_by_track_planning.patch, but this > CF entry is for pgss_lwlock_v1.patch which replaces spinlocks with lwlocks > in pg_stat_statements. The latter patch has not been committed yet. > Probably attachding the different patches in the same thread would cause > this confusing thing... Anyway, thanks for your comment! To avoid further confusion, I attached the rebased version of the patch that was registered at CF. I'd appreciate it if you review this version. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION --------------55529784A24B4389BBCF2A84 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="pgss_lwlock_v2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pgss_lwlock_v2.patch" ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfc3RhdF9zdGF0ZW1lbnRzL3BnX3N0YXRfc3RhdGVt ZW50cy5jIGIvY29udHJpYi9wZ19zdGF0X3N0YXRlbWVudHMvcGdfc3RhdF9zdGF0ZW1lbnRz LmMKaW5kZXggNmI5MWM2MmMzMS4uMzAzNWMxNGVkNSAxMDA2NDQKLS0tIGEvY29udHJpYi9w Z19zdGF0X3N0YXRlbWVudHMvcGdfc3RhdF9zdGF0ZW1lbnRzLmMKKysrIGIvY29udHJpYi9w Z19zdGF0X3N0YXRlbWVudHMvcGdfc3RhdF9zdGF0ZW1lbnRzLmMKQEAgLTM5LDcgKzM5LDcg QEAKICAqIGluIGFuIGVudHJ5IGV4Y2VwdCB0aGUgY291bnRlcnMgcmVxdWlyZXMgdGhlIHNh bWUuICBUbyBsb29rIHVwIGFuIGVudHJ5LAogICogb25lIG11c3QgaG9sZCB0aGUgbG9jayBz aGFyZWQuICBUbyByZWFkIG9yIHVwZGF0ZSB0aGUgY291bnRlcnMgd2l0aGluCiAgKiBhbiBl bnRyeSwgb25lIG11c3QgaG9sZCB0aGUgbG9jayBzaGFyZWQgb3IgZXhjbHVzaXZlIChzbyB0 aGUgZW50cnkgZG9lc24ndAotICogZGlzYXBwZWFyISkgYW5kIGFsc28gdGFrZSB0aGUgZW50 cnkncyBtdXRleCBzcGlubG9jay4KKyAqIGRpc2FwcGVhciEpIGFuZCBhbHNvIHRha2UgdGhl IGVudHJ5J3MgcGFydGl0aW9uIGxvY2suCiAgKiBUaGUgc2hhcmVkIHN0YXRlIHZhcmlhYmxl IHBnc3MtPmV4dGVudCAodGhlIG5leHQgZnJlZSBzcG90IGluIHRoZSBleHRlcm5hbAogICog cXVlcnktdGV4dCBmaWxlKSBzaG91bGQgYmUgYWNjZXNzZWQgb25seSB3aGlsZSBob2xkaW5n IGVpdGhlciB0aGUKICAqIHBnc3MtPm11dGV4IHNwaW5sb2NrLCBvciBleGNsdXNpdmUgbG9j ayBvbiBwZ3NzLT5sb2NrLiAgV2UgdXNlIHRoZSBtdXRleCB0bwpAQCAtMTE1LDYgKzExNSwx MSBAQCBzdGF0aWMgY29uc3QgdWludDMyIFBHU1NfUEdfTUFKT1JfVkVSU0lPTiA9IFBHX1ZF UlNJT05fTlVNIC8gMTAwOwogCiAjZGVmaW5lIEpVTUJMRV9TSVpFCQkJCTEwMjQJLyogcXVl cnkgc2VyaWFsaXphdGlvbiBidWZmZXIgc2l6ZSAqLwogCisjZGVmaW5lCVBHU1NfTlVNX0xP Q0tfUEFSVElUSU9OUygpCQkocGdzc19tYXgpCisjZGVmaW5lCVBHU1NfSEFTSF9QQVJUSVRJ T05fTE9DSyhrZXkpCVwKKwkoJihwZ3NzLT5iYXNlICsJXAorCSAgIChnZXRfaGFzaF92YWx1 ZShwZ3NzX2hhc2gsIGtleSkgJSBQR1NTX05VTV9MT0NLX1BBUlRJVElPTlMoKSkpLT5sb2Nr KQorCiAvKgogICogRXh0ZW5zaW9uIHZlcnNpb24gbnVtYmVyLCBmb3Igc3VwcG9ydGluZyBv bGRlciBleHRlbnNpb24gdmVyc2lvbnMnIG9iamVjdHMKICAqLwpAQCAtMjA3LDcgKzIxMiw3 IEBAIHR5cGVkZWYgc3RydWN0IHBnc3NFbnRyeQogCVNpemUJCXF1ZXJ5X29mZnNldDsJLyog cXVlcnkgdGV4dCBvZmZzZXQgaW4gZXh0ZXJuYWwgZmlsZSAqLwogCWludAkJCXF1ZXJ5X2xl bjsJCS8qICMgb2YgdmFsaWQgYnl0ZXMgaW4gcXVlcnkgc3RyaW5nLCBvciAtMSAqLwogCWlu dAkJCWVuY29kaW5nOwkJLyogcXVlcnkgdGV4dCBlbmNvZGluZyAqLwotCXNsb2NrX3QJCW11 dGV4OwkJCS8qIHByb3RlY3RzIHRoZSBjb3VudGVycyBvbmx5ICovCisJTFdMb2NrCSAgIAkq bG9jazsJCQkvKiBwcm90ZWN0cyB0aGUgY291bnRlcnMgb25seSAqLwogfSBwZ3NzRW50cnk7 CiAKIC8qCkBAIC0yMTYsNiArMjIxLDcgQEAgdHlwZWRlZiBzdHJ1Y3QgcGdzc0VudHJ5CiB0 eXBlZGVmIHN0cnVjdCBwZ3NzU2hhcmVkU3RhdGUKIHsKIAlMV0xvY2sJICAgKmxvY2s7CQkJ LyogcHJvdGVjdHMgaGFzaHRhYmxlIHNlYXJjaC9tb2RpZmljYXRpb24gKi8KKwlMV0xvY2tQ YWRkZWQJKmJhc2U7CQkvKiBiYXNlIGFkZHJlc3Mgb2YgdGhpcyBMV0xvY2sgKi8KIAlkb3Vi bGUJCWN1cl9tZWRpYW5fdXNhZ2U7CS8qIGN1cnJlbnQgbWVkaWFuIHVzYWdlIGluIGhhc2h0 YWJsZSAqLwogCVNpemUJCW1lYW5fcXVlcnlfbGVuOyAvKiBjdXJyZW50IG1lYW4gZW50cnkg dGV4dCBsZW5ndGggKi8KIAlzbG9ja190CQltdXRleDsJCQkvKiBwcm90ZWN0cyBmb2xsb3dp bmcgZmllbGRzIG9ubHk6ICovCkBAIC00NjgsNyArNDc0LDggQEAgX1BHX2luaXQodm9pZCkK IAkgKiByZXNvdXJjZXMgaW4gcGdzc19zaG1lbV9zdGFydHVwKCkuCiAJICovCiAJUmVxdWVz dEFkZGluU2htZW1TcGFjZShwZ3NzX21lbXNpemUoKSk7Ci0JUmVxdWVzdE5hbWVkTFdMb2Nr VHJhbmNoZSgicGdfc3RhdF9zdGF0ZW1lbnRzIiwgMSk7CisJUmVxdWVzdE5hbWVkTFdMb2Nr VHJhbmNoZSgicGdfc3RhdF9zdGF0ZW1lbnRzIiwKKwkJCQkJCQkgIFBHU1NfTlVNX0xPQ0tf UEFSVElUSU9OUygpICsgMSk7CiAKIAkvKgogCSAqIEluc3RhbGwgaG9va3MuCkBAIC01NDcs NyArNTU0LDggQEAgcGdzc19zaG1lbV9zdGFydHVwKHZvaWQpCiAJaWYgKCFmb3VuZCkKIAl7 CiAJCS8qIEZpcnN0IHRpbWUgdGhyb3VnaCAuLi4gKi8KLQkJcGdzcy0+bG9jayA9ICYoR2V0 TmFtZWRMV0xvY2tUcmFuY2hlKCJwZ19zdGF0X3N0YXRlbWVudHMiKSktPmxvY2s7CisJCXBn c3MtPmJhc2UgPSBHZXROYW1lZExXTG9ja1RyYW5jaGUoInBnX3N0YXRfc3RhdGVtZW50cyIp OworCQlwZ3NzLT5sb2NrID0gJihwZ3NzLT5iYXNlICsgcGdzc19tYXgpLT5sb2NrOwogCQlw Z3NzLT5jdXJfbWVkaWFuX3VzYWdlID0gQVNTVU1FRF9NRURJQU5fSU5JVDsKIAkJcGdzcy0+ bWVhbl9xdWVyeV9sZW4gPSBBU1NVTUVEX0xFTkdUSF9JTklUOwogCQlTcGluTG9ja0luaXQo JnBnc3MtPm11dGV4KTsKQEAgLTEzODQsMTQgKzEzOTIsMTQgQEAgcGdzc19zdG9yZShjb25z dCBjaGFyICpxdWVyeSwgdWludDY0IHF1ZXJ5SWQsCiAJaWYgKCFqc3RhdGUpCiAJewogCQkv KgotCQkgKiBHcmFiIHRoZSBzcGlubG9jayB3aGlsZSB1cGRhdGluZyB0aGUgY291bnRlcnMg KHNlZSBjb21tZW50IGFib3V0Ci0JCSAqIGxvY2tpbmcgcnVsZXMgYXQgdGhlIGhlYWQgb2Yg dGhlIGZpbGUpCisJCSAqIEdyYWIgdGhlIHBhcnRpdGlvbiBsb2NrIHdoaWxlIHVwZGF0aW5n IHRoZSBjb3VudGVycyAoc2VlIGNvbW1lbnQKKwkJICogYWJvdXQgbG9ja2luZyBydWxlcyBh dCB0aGUgaGVhZCBvZiB0aGUgZmlsZSkKIAkJICovCiAJCXZvbGF0aWxlIHBnc3NFbnRyeSAq ZSA9ICh2b2xhdGlsZSBwZ3NzRW50cnkgKikgZW50cnk7CiAKIAkJQXNzZXJ0KGtpbmQgPT0g UEdTU19QTEFOIHx8IGtpbmQgPT0gUEdTU19FWEVDKTsKIAotCQlTcGluTG9ja0FjcXVpcmUo JmUtPm11dGV4KTsKKwkJTFdMb2NrQWNxdWlyZShlLT5sb2NrLCBMV19FWENMVVNJVkUpOwog CiAJCS8qICJVbnN0aWNrIiBlbnRyeSBpZiBpdCB3YXMgcHJldmlvdXNseSBzdGlja3kgKi8K IAkJaWYgKElTX1NUSUNLWShlLT5jb3VudGVycykpCkBAIC0xNDQzLDcgKzE0NTEsNyBAQCBw Z3NzX3N0b3JlKGNvbnN0IGNoYXIgKnF1ZXJ5LCB1aW50NjQgcXVlcnlJZCwKIAkJZS0+Y291 bnRlcnMud2FsX2ZwaSArPSB3YWx1c2FnZS0+d2FsX2ZwaTsKIAkJZS0+Y291bnRlcnMud2Fs X2J5dGVzICs9IHdhbHVzYWdlLT53YWxfYnl0ZXM7CiAKLQkJU3BpbkxvY2tSZWxlYXNlKCZl LT5tdXRleCk7CisJCUxXTG9ja1JlbGVhc2UoZS0+bG9jayk7CiAJfQogCiBkb25lOgpAQCAt MTc3MCw5ICsxNzc4LDkgQEAgcGdfc3RhdF9zdGF0ZW1lbnRzX2ludGVybmFsKEZ1bmN0aW9u Q2FsbEluZm8gZmNpbmZvLAogCQl7CiAJCQl2b2xhdGlsZSBwZ3NzRW50cnkgKmUgPSAodm9s YXRpbGUgcGdzc0VudHJ5ICopIGVudHJ5OwogCi0JCQlTcGluTG9ja0FjcXVpcmUoJmUtPm11 dGV4KTsKKwkJCUxXTG9ja0FjcXVpcmUoZS0+bG9jaywgTFdfU0hBUkVEKTsKIAkJCXRtcCA9 IGUtPmNvdW50ZXJzOwotCQkJU3BpbkxvY2tSZWxlYXNlKCZlLT5tdXRleCk7CisJCQlMV0xv Y2tSZWxlYXNlKGUtPmxvY2spOwogCQl9CiAKIAkJLyogU2tpcCBlbnRyeSBpZiB1bmV4ZWN1 dGVkIChpZSwgaXQncyBhIHBlbmRpbmcgInN0aWNreSIgZW50cnkpICovCkBAIC0xOTE2LDgg KzE5MjQsOCBAQCBlbnRyeV9hbGxvYyhwZ3NzSGFzaEtleSAqa2V5LCBTaXplIHF1ZXJ5X29m ZnNldCwgaW50IHF1ZXJ5X2xlbiwgaW50IGVuY29kaW5nLAogCQltZW1zZXQoJmVudHJ5LT5j b3VudGVycywgMCwgc2l6ZW9mKENvdW50ZXJzKSk7CiAJCS8qIHNldCB0aGUgYXBwcm9wcmlh dGUgaW5pdGlhbCB1c2FnZSBjb3VudCAqLwogCQllbnRyeS0+Y291bnRlcnMudXNhZ2UgPSBz dGlja3kgPyBwZ3NzLT5jdXJfbWVkaWFuX3VzYWdlIDogVVNBR0VfSU5JVDsKLQkJLyogcmUt aW5pdGlhbGl6ZSB0aGUgbXV0ZXggZWFjaCB0aW1lIC4uLiB3ZSBhc3N1bWUgbm8gb25lIHVz aW5nIGl0ICovCi0JCVNwaW5Mb2NrSW5pdCgmZW50cnktPm11dGV4KTsKKwkJLyogZGV0ZXJt aW5lIHdoaWNoIHBhcnRpdGlvbiBsb2NrIHRvIHVzZSBmb3IgdGhpcyBxdWVyeSAqLworCQll bnRyeS0+bG9jayA9IFBHU1NfSEFTSF9QQVJUSVRJT05fTE9DSyhrZXkpOwogCQkvKiAuLi4g YW5kIGRvbid0IGZvcmdldCB0aGUgcXVlcnkgdGV4dCBtZXRhZGF0YSAqLwogCQlBc3NlcnQo cXVlcnlfbGVuID49IDApOwogCQllbnRyeS0+cXVlcnlfb2Zmc2V0ID0gcXVlcnlfb2Zmc2V0 Owo= --------------55529784A24B4389BBCF2A84--