Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c49Qs-0005XS-0Q for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Nov 2016 16:39:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c49Qr-0004Vc-3Q for pgsql-hackers@arkaria.postgresql.org; Tue, 08 Nov 2016 16:39:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c49PS-0002pL-Pd for pgsql-hackers@postgresql.org; Tue, 08 Nov 2016 16:38:06 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c49PO-0001gj-SX for pgsql-hackers@postgresql.org; Tue, 08 Nov 2016 16:38:06 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 965122073F; Tue, 8 Nov 2016 11:38:01 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Tue, 08 Nov 2016 11:38:01 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= smtpout; bh=jYv3fubBsfTcL5AjygPq9+fhTHo=; b=UySy0VM2Tmnv0qjVenod vHjk0jxBQo1k9U1+r1ng3Y3mlIO4PRfLMTJ9HgpIo+IF/4I5L1mxLrx8pKcQZg8C 2wL6jeOJ6uBsqrqzsVOuZaX7Mx67eZorjHTxFsm93M0te/MPC7NEhiXtUxmgdvUu dZGfKJ9kDf6Gw95A2A4ijRw= X-ME-Sender: X-Sasl-enc: XQ53Rx4FLi6Aka12qnO1d2XpoF9UKmNQ5tVDS1XPTrXu 1478623079 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 226D7CC08D; Tue, 8 Nov 2016 11:37:59 -0500 (EST) Subject: Re: Radix tree for character conversion To: Daniel Gustafsson , Kyotaro HORIGUCHI References: <6d85d710-9554-a928-29ff-b2d3b80b01c9@iki.fi> <20161021.173321.105120238.horiguchi.kyotaro@lab.ntt.co.jp> <08e7892a-d55c-eefe-76e6-7910bc8dd1f3@iki.fi> <20161027.162337.204351475.horiguchi.kyotaro@lab.ntt.co.jp> <3FC648B5-2B7F-4585-9615-207A44B730A9@yesql.se> Cc: Heikki Linnakangas , robertmhaas@gmail.com, tsunakawa.takay@jp.fujitsu.com, tgl@sss.pgh.pa.us, ishii@sraoss.co.jp, pgsql-hackers@postgresql.org From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: Date: Tue, 8 Nov 2016 11:37:58 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <3FC648B5-2B7F-4585-9615-207A44B730A9@yesql.se> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 10/31/16 12:11 PM, Daniel Gustafsson wrote: > I took a small stab at doing some cleaning of the Perl scripts, mainly around > using the more modern (well, modern as in +15 years old) form for open(..), > avoiding global filehandles for passing scalar references and enforcing use > strict. Some smaller typos and fixes were also included. It seems my Perl has > become a bit rusty so I hope the changes make sense. The produced files are > identical with these patches applied, they are merely doing cleaning as opposed > to bugfixing. > > The attached patches are against the 0001-0006 patches from Heikki and you in > this series of emails, the separation is intended to make them easier to read. Cool. See also here: https://www.postgresql.org/message-id/55E52225.4040305%40gmx.net -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers