Content-Type: multipart/alternative;
 boundary="------------yHhZ0CUx0Yus0Eq0TI4R2BEo"
Message-ID: <bb90fc3a-141a-4244-9def-e265034f0a56@postgrespro.ru>
Date: Mon, 16 Dec 2024 18:42:07 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: DOCS: pg_createsubscriber wrong link?
To: Amit Kapila <amit.kapila16@gmail.com>, Peter Smith
 <smithpb2250@gmail.com>, Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAHut+PtnA4DB_pcv4TDr4NjUSM1=P2N_cuZx5DX09k7LVmaqUA@mail.gmail.com>
 <CAA4eK1KkWW01X-CA6S3y6dRA0DeAg1hYP+uMdnRMEuD84wNW3g@mail.gmail.com>
Content-Language: en-US, ru-RU
From: Pavel Luzanov <p.luzanov@postgrespro.ru>
In-Reply-To: <CAA4eK1KkWW01X-CA6S3y6dRA0DeAg1hYP+uMdnRMEuD84wNW3g@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/bb90fc3a-141a-4244-9def-e265034f0a56%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------yHhZ0CUx0Yus0Eq0TI4R2BEo
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 16.12.2024 13:56, Amit Kapila wrote:
> On Fri, Dec 13, 2024 at 10:58 AM Peter Smith<smithpb2250@gmail.com>  wrote:
>> While reviewing the pg_createsubscriber [1] docs I found a potentially
>> wrong linkend.
>>
>> This sentence:
>> "For smaller databases, initial data synchronization is recommended."
>>
>> links to [2] ("29.4.5. Initial Data Synchronization").
>>
>> This seems to have been deliberately changed (commit [3])
>>
> Yeah, the change made by commit 84db9a0eb1 is wrong and your latest
> patch in this thread looks good to me. I am adding Daniel and the
> original author to see if they think differently.

It looks like my mistake.
I missed that "Initial Data Synchronization" section is a subsection
of "Row filters". There is no hidden reason other than matching
the link name with the subsection name and my inattention.

v2 of proposed patch looks good to me.

-- 
Pavel Luzanov
Postgres Professional:https://postgrespro.com

--------------yHhZ0CUx0Yus0Eq0TI4R2BEo
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    On 16.12.2024 13:56, Amit Kapila wrote:<br>
    <blockquote type="cite"
cite="mid:CAA4eK1KkWW01X-CA6S3y6dRA0DeAg1hYP+uMdnRMEuD84wNW3g@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">On Fri, Dec 13, 2024 at 10:58 AM Peter Smith <a class="moz-txt-link-rfc2396E" href="mailto:smithpb2250@gmail.com">&lt;smithpb2250@gmail.com&gt;</a> wrote:
</pre>
      <blockquote type="cite">
        <pre class="moz-quote-pre" wrap="">
While reviewing the pg_createsubscriber [1] docs I found a potentially
wrong linkend.

This sentence:
"For smaller databases, initial data synchronization is recommended."

links to [2] ("29.4.5. Initial Data Synchronization").

This seems to have been deliberately changed (commit [3])

</pre>
      </blockquote>
      <pre class="moz-quote-pre" wrap="">
Yeah, the change made by commit 84db9a0eb1 is wrong and your latest
patch in this thread looks good to me. I am adding Daniel and the
original author to see if they think differently.</pre>
    </blockquote>
    <pre>
It looks like my mistake.
I missed that "Initial Data Synchronization" section is a subsection
of "Row filters". There is no hidden reason other than matching
the link name with the subsection name and my inattention.

v2 of proposed patch looks good to me.

</pre>
    <pre class="moz-signature" cols="72">-- 
Pavel Luzanov
Postgres Professional: <a class="moz-txt-link-freetext" href="https://postgrespro.com">https://postgrespro.com</a></pre>
  </body>
</html>

--------------yHhZ0CUx0Yus0Eq0TI4R2BEo--