Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8L27-0005F7-8r for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2019 08:32:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h8L25-0005Q4-P6 for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2019 08:32:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8L25-0005Px-HE for pgsql-hackers@lists.postgresql.org; Mon, 25 Mar 2019 08:32:37 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h8L23-0001Jh-Db for pgsql-hackers@postgresql.org; Mon, 25 Mar 2019 08:32:37 +0000 Received: from Davids-MacBook.local (unknown [197.226.239.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id C2BF15466D; Mon, 25 Mar 2019 08:32:31 +0000 (UTC) Subject: Re: Re: allow online change primary_conninfo To: Michael Paquier Cc: Sergei Kornilov , Andres Freund , Kyotaro HORIGUCHI , "pgsql-hackers@postgresql.org" References: <4926831544698308@iva3-294f9af87d55.qloud-c.yandex.net> <20181214075542.GG2921@paquier.xyz> <20190131125837.6gtbdslj5atasuoz@alap3.anarazel.de> <6789441548940402@sas1-fb8a605c4548.qloud-c.yandex.net> <20190203105241.4hbq4cyl4hkrgnzq@alap3.anarazel.de> <17843631549197218@iva5-d3020dc3459d.qloud-c.yandex.net> <20190216035316.6q23okurzacergea@alap3.anarazel.de> <7431841550317835@sas1-fb8a605c4548.qloud-c.yandex.net> <20190217192720.qphwrraj66rht5lj@alap3.anarazel.de> <10224751551523791@myt3-c7e5d17fe013.qloud-c.yandex.net> <20190304031918.GH1999@paquier.xyz> From: David Steele Message-ID: Date: Mon, 25 Mar 2019 12:32:21 +0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190304031918.GH1999@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Michael, On 3/4/19 7:19 AM, Michael Paquier wrote: > On Sat, Mar 02, 2019 at 01:49:51PM +0300, Sergei Kornilov wrote: >> This might be not the right way, but I can't think of a better way >> to not switch to a different method than split of lastSourceFailed >> processing and starting new source. Something like refactoring in >> first attached patch. I move RequestXLogStreaming logic from >> lastSourceFailed processing and add new pendingRestartSource >> indicator. > > OK. This needs a rather close lookup, and I am not actually sure that > you even need pendingRestartSource. Please let me a couple of days > before coming back to you on 0001. > >> Second patch is mostly the same as previous version but uses new >> pendingRestartSource mechanism instead of lastSourceFailed. > > This, on the other hand, looks like the implementation we are looking > for based on the discussions which happened until now to have the > startup process handle the shutdown and restart of the WAL receiver. Do you know when you'll have a chance to revisit this? Regards, -- -David david@pgmasters.net