Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tJTrG-003H5u-Dq for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Dec 2024 08:38:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tJTrD-00Auyj-Fa for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Dec 2024 08:38:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tJTrD-00AuyZ-1W for pgsql-hackers@lists.postgresql.org; Fri, 06 Dec 2024 08:38:40 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tJTrB-001KQk-6n for pgsql-hackers@lists.postgresql.org; Fri, 06 Dec 2024 08:38:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1733474315; bh=HXnYhRfUdR9HQGAE0If0Mklhrtth7X+d88ky+HHvDyA=; h=Date:From:To:Subject:Message-ID:From; b=pNWi3IO5WYxLncNGIbYPQNVNvEJrWed23oNU77+zMMTI84Y7qT56Tawoc36wUqNiT msJruiHtuuH0qvQL2wLUHMr+v0va9qOSMj5NrWeVSUUlWrITKFCfeLtDrX+jOMXOwi N962O44N8U1ldHT1NnXFhW6aGNftq0Hfl3GkxUp6ntGcckuTkPT7X5BL87US5wHdRh 1kgYRUUv5xCkrakz56l1MxibrcULDiMr5cBo0ZvNeIeW5IZOP41++8pSxwYRgLTTei sQ+9ASa2gJX1RfHCUWZ2oW7otyEw1kjnI7pBqQdiqHuQLE9UNYZdAj/0mGhN76Mtaa SBsg9B+Cw8sNQ== Received: from mail.postgrespro.ru (webmail-slave-mstn.l.postgrespro.ru [192.168.2.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: t.aliev@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id CB1B55FEE7; Fri, 6 Dec 2024 11:38:35 +0300 (MSK) MIME-Version: 1.0 Date: Fri, 06 Dec 2024 15:38:35 +0700 From: Tofig Aliev To: pgsql-hackers@lists.postgresql.org, sawada.mshk@gmail.com Subject: Fix tiny memory leaks Message-ID: X-Sender: t.aliev@postgrespro.ru Organization: Postgres Professional Content-Type: multipart/mixed; boundary="=_5ce688988033fb1dec72fcbcb6b9b64c" X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2024/12/06 07:38:00 #26942492 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_5ce688988033fb1dec72fcbcb6b9b64c Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi, hackers! There is a memory leak in functions check_application_name() and check_cluster_name(). Functions are located in src/backend/commands/variable.c The leak can be triggered using SQL command: SET application_name=new_name; You can run pgbench with this command for a long time by passing this command in file via '-f' flag. regards, Tofig --=_5ce688988033fb1dec72fcbcb6b9b64c Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-tiny-memory-leaks.patch Content-Disposition: attachment; filename=0001-Fix-tiny-memory-leaks.patch; size=1019 RnJvbSBhODAxZDAzYzU3ODE5ZDNkZTE4MTk2N2Q3MjI2MGNiNDJiYmNmNmEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb2ZpZyBBbGlldiA8dC5hbGlldkBwb3N0Z3Jlc3Byby5ydT4K RGF0ZTogRnJpLCA2IERlYyAyMDI0IDE0OjU4OjM4ICswNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IHRpbnkgbWVtb3J5IGxlYWtzCgpNZW1vcnkgZm9yICgqbmV3dmFsKSBhbGxvY2F0ZWQgZWFybGll cgppbiB0aGUgcGFyc2VfYW5kX3ZhbGlkYXRlX3ZhbHVlKCkgbWV0aG9kLgpTaW5jZSB0aGlzIG1l dGhvZCByZS1hbGxvY2F0ZXMgbWVtb3J5LAppdCBpcyBuZWNlc3NhcnkgdG8gZnJlZSB0aGUgcHJl dmlvdXNseSBhbGxvY2F0ZWQgbWVtb3J5LgotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL3Zhcmlh YmxlLmMgfCA0ICsrKysKIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy92YXJpYWJsZS5jIGIvc3JjL2JhY2tlbmQvY29tbWFu ZHMvdmFyaWFibGUuYwppbmRleCAwZWNmZjk0ZDBlLi4yYzgwNTllOGQ4IDEwMDY0NAotLS0gYS9z cmMvYmFja2VuZC9jb21tYW5kcy92YXJpYWJsZS5jCisrKyBiL3NyYy9iYWNrZW5kL2NvbW1hbmRz L3ZhcmlhYmxlLmMKQEAgLTEwOTIsNiArMTA5Miw4IEBAIGNoZWNrX2FwcGxpY2F0aW9uX25hbWUo Y2hhciAqKm5ld3ZhbCwgdm9pZCAqKmV4dHJhLCBHdWNTb3VyY2Ugc291cmNlKQogCQlyZXR1cm4g ZmFsc2U7CiAJfQogCisJZ3VjX2ZyZWUoKm5ld3ZhbCk7CisKIAlwZnJlZShjbGVhbik7CiAJKm5l d3ZhbCA9IHJldDsKIAlyZXR1cm4gdHJ1ZTsKQEAgLTExMjgsNiArMTEzMCw4IEBAIGNoZWNrX2Ns dXN0ZXJfbmFtZShjaGFyICoqbmV3dmFsLCB2b2lkICoqZXh0cmEsIEd1Y1NvdXJjZSBzb3VyY2Up CiAJCXJldHVybiBmYWxzZTsKIAl9CiAKKwlndWNfZnJlZSgqbmV3dmFsKTsKKwogCXBmcmVlKGNs ZWFuKTsKIAkqbmV3dmFsID0gcmV0OwogCXJldHVybiB0cnVlOwotLSAKMi40My4wCgo= --=_5ce688988033fb1dec72fcbcb6b9b64c--