Reply-To: jesper.pedersen@redhat.com
Subject: Re: POC: converting Lists into arrays
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <david.rowley@2ndquadrant.com>,
 Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <481.1551390571@sss.pgh.pa.us> <24783.1551568303@sss.pgh.pa.us>
 <20190303043424.itzy3ge52xrkpmpr@alap3.anarazel.de>
 <437.1551637744@sss.pgh.pa.us>
 <CA+TgmoZM4c=v0ifR++i09JFtNtnqTq_HkFmbFjwWqbUJffOLmA@mail.gmail.com>
 <12684.1551723095@sss.pgh.pa.us>
 <20190304190612.vgqqsowzkrh22623@alap3.anarazel.de>
 <26464.1551734920@sss.pgh.pa.us>
 <20190304221101.hdg4vj5fo4eewh3b@alap3.anarazel.de>
 <CAKJS1f-pNfoUJrmU8vgD1WrKLqs9WxOVLQ0RpSWu9h6W9RnypA@mail.gmail.com>
 <20190304235402.nod3gbotk2qtd4nh@alap3.anarazel.de>
 <CAKJS1f-yS201hAAmnxcLb2aeTYNZ_A9R1JNXF6hTVXjhHYN7rQ@mail.gmail.com>
 <1131.1551746172@sss.pgh.pa.us> <14626.1558745627@sss.pgh.pa.us>
 <29297.1558799327@sss.pgh.pa.us>
 <f078ce63-9e04-0f3e-d200-d7ee66279abe@redhat.com>
 <25178.1562006685@sss.pgh.pa.us>
From: Jesper Pedersen <jesper.pedersen@redhat.com>
Organization: Red Hat
Message-ID: <bbe340c9-76fb-c66d-8a14-73168f0b89b9@redhat.com>
Date: Mon, 1 Jul 2019 15:18:02 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <25178.1562006685@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 7/1/19 2:44 PM, Tom Lane wrote:
> Yup, here's a rebase against HEAD (and I also find that check-world shows
> no problems).

Thanks - no further comments.

>  This is pretty much of a pain to maintain, since it changes
> the API for lnext() which is, um, a bit invasive.  I'd like to make a
> decision pretty quickly on whether we're going to do this, and either
> commit this patch or abandon it.
> 

IMHO it is an improvement over the existing API.

>> There is some unneeded MemoryContext stuff in async.c's
>> pg_listening_channels() which should be cleaned up.
> 
> Yeah, there's a fair amount of follow-on cleanup that could be undertaken
> afterwards, but I've wanted to keep the patch's footprint as small as
> possible for the moment.  Assuming we pull the trigger, I'd then go look
> at removing the planner's duplicative lists+arrays for RTEs and such as
> the first cleanup step.  But thanks for the pointer to async.c, I'll
> check that too.
> 

Yeah, I only called out the async.c change, as that function isn't 
likely to change in any of the follow up patches.

Best regards,
  Jesper