Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQXKP-0004FI-Hg for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 17:04:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oQXKO-0007il-DO for pgsql-hackers@arkaria.postgresql.org; Tue, 23 Aug 2022 17:04:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQXKO-0007ib-37 for pgsql-hackers@lists.postgresql.org; Tue, 23 Aug 2022 17:04:36 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oQXKM-0002Sm-00 for pgsql-hackers@postgresql.org; Tue, 23 Aug 2022 17:04:35 +0000 Received: by mail-pl1-x629.google.com with SMTP id g8so9466126plq.11 for ; Tue, 23 Aug 2022 10:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timescale.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=pqwM+5afPcg7F8hJkygtBWofALKXYv9WxNCvYrcLevw=; b=jBthQoItt4iAGJJdU6Je99nDbQ9Yiu0/Z2Yqn5lq9RhPSFiF8APUtL89KH20JlD/NF 4mudRFxzeRIdOnuyKELkQkXPhqCievyNWAz/Tk+tvt43oA+KP/6+TG+rEzgLFWhRWrLH 4j+Sl3Ut38MS2VVLug8mRxrUXV57U0hUu06PAcoKGGFxJdQ1GLRfbfNFBNeeWYCVhAFa O74L18sR41hFqVWK+Qx4MdEZDPzEy7vxYdEMVzBPC/Ym+0thG1PTiL2LSQmm0Y48FRnQ hxSeYAyXQ5T+Z6eVf07Xp8L0Qb8cx0gjNcHHoPUmDFW9qiP/bO0p4/kBxU59tKYW+mls ik9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=pqwM+5afPcg7F8hJkygtBWofALKXYv9WxNCvYrcLevw=; b=W59iby1QLLQXbmKAOtJ4akxiAo77XCEUMv7er9foIzvCW+wA0tDnBex4qONu6gzcG0 uFnVhUKoVAzw9PKrtW+TxX4XA+o3JztHKKG9v9jRP/f4xOEvKgouoKigDRuTPqx6XueE FhYXFu0ndNPssyzBrBIkF47oTJHAP95jmMk8h1q7y+8zWWk0ZmI+Bzzu2cTC/UUWNI16 qVwF4n6MR/HDZM9ZjiQ1B1WPAMz6xS3t0T6iof5B6lRbyjaNlxJcUHJUMmFm/NuPegTt oRUPuAHKm9PcrkdePZAnjAYsp+GrBhqsUWdwekAvqBNo/iK+ELvAl75XEjfBloQORfrp /yDg== X-Gm-Message-State: ACgBeo0PiAdAjnc4VLOUUIbm6XhMhqjabzsW5fEDNHm0fsWst7BjYQW6 kdN+YGLOtvi3yJ2mfpEDa0AWTg== X-Google-Smtp-Source: AA6agR756gyWrzVmxwRvcnnxGxAv2xPLxLJtgQ+Ky6EclxfFuBxIddu1SY1/ZMfNRqxJc4H3ZtMFMA== X-Received: by 2002:a17:90a:c1:b0:1f4:f757:6b48 with SMTP id v1-20020a17090a00c100b001f4f7576b48mr4113803pjd.56.1661274272079; Tue, 23 Aug 2022 10:04:32 -0700 (PDT) Received: from [192.168.1.21] ([50.39.205.221]) by smtp.gmail.com with ESMTPSA id d9-20020a170902654900b0016cdbb22c28sm10806604pln.0.2022.08.23.10.04.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 10:04:31 -0700 (PDT) Message-ID: Date: Tue, 23 Aug 2022 10:04:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers Content-Language: en-US To: "Drouvot, Bertrand" , Michael Paquier Cc: Joe Conway , Robert Haas , Tom Lane , "sfrost@snowman.net" , "rjuju123@gmail.com" , "pgsql-hackers@postgresql.org" , "andres@anarazel.de" References: <2a1e2717-8c68-3f9e-1e02-32da71deb327@amazon.com> <127bd019-04f0-313c-551c-d949cdc4ad50@amazon.com> <520bd3ce-334b-b9c2-2130-858fb04ce56f@amazon.com> <2541c086-e370-d114-69a7-b48b05b25471@amazon.com> From: Jacob Champion In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 8/23/22 01:53, Drouvot, Bertrand wrote: > That sounds all good to me, except a typo for the author in the commit > message: s/Jocob/Jacob/ Thanks, I missed that on my readthrough! :D Patch looks good to me, too, with one question: > @@ -2688,6 +2689,7 @@ InitProcessGlobals(void) > MyProcPid = getpid(); > MyStartTimestamp = GetCurrentTimestamp(); > MyStartTime = timestamptz_to_time_t(MyStartTimestamp); > + memset(&MyClientConnectionInfo, 0, sizeof(MyClientConnectionInfo)); > > /* > * Set a different global seed in every process. We want something When can we rely on static initialization, and when can't we? Is there a concern that the memory could have been polluted from before the postmaster's fork? Thanks, --Jacob