Content-Type: multipart/alternative;
 boundary="------------eVrhltvEb8lmrNtrh09wj9u0"
Message-ID: <bc03e76e-15d6-744e-db53-2e4417b5fe05@dunslane.net>
Date: Tue, 24 Oct 2023 09:11:47 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: More new SQL/JSON item methods
Content-Language: en-US
To: Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAM2+6=XjTyqrrqHAOj80r0wVQxJSxc0iyib9bPC55uFO9VKatg@mail.gmail.com>
 <6d4feb29-6ced-a7b0-2c15-42d3e8e201f7@eisentraut.org>
 <CAM2+6=XTW1COd+56ekjP=CUceZyrgyrcBge_z0ZRkCgVwcGHQg@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <CAM2+6=XTW1COd+56ekjP=CUceZyrgyrcBge_z0ZRkCgVwcGHQg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/bc03e76e-15d6-744e-db53-2e4417b5fe05%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------eVrhltvEb8lmrNtrh09wj9u0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 2023-10-19 Th 02:06, Jeevan Chalke wrote:
> Thanks, Peter for the comments.
>
> On Fri, Oct 6, 2023 at 5:13 PM Peter Eisentraut <peter@eisentraut.org> 
> wrote:
>
>     On 29.08.23 09:05, Jeevan Chalke wrote:
>     > v1-0001-Implement-jsonpath-.bigint-.integer-and-.number-m.patch
>     >
>     > This commit implements jsonpath .bigint(), .integer(), and .number()
>     > methods.  The JSON string or a numeric value is converted to the
>     > bigint, int4, and numeric type representation.
>
>     A comment that applies to all of these: These add various keywords,
>     switch cases, documentation entries in some order.  Are we happy with
>     that?  Should we try to reorder all of that for better
>     maintainability
>     or readability?
>
>
> Yeah, that's the better suggestion. While implementing these methods, 
> I was confused about where to put them exactly and tried keeping them 
> in some logical place.
> I think once these methods get in, we can have a follow-up patch 
> reorganizing all of these.


I think it would be better to organize things how we want them before 
adding in more stuff.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------eVrhltvEb8lmrNtrh09wj9u0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2023-10-19 Th 02:06, Jeevan Chalke
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAM2+6=XTW1COd+56ekjP=CUceZyrgyrcBge_z0ZRkCgVwcGHQg@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div>Thanks, Peter for the comments.</div>
        <br>
        <div class="gmail_quote">
          <div dir="ltr" class="gmail_attr">On Fri, Oct 6, 2023 at
            5:13 PM Peter Eisentraut &lt;<a
              href="mailto:peter@eisentraut.org" moz-do-not-send="true"
              class="moz-txt-link-freetext">peter@eisentraut.org</a>&gt;
            wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">On 29.08.23 09:05, Jeevan
            Chalke wrote:<br>
            &gt;
            v1-0001-Implement-jsonpath-.bigint-.integer-and-.number-m.patch<br>
            &gt; <br>
            &gt; This commit implements jsonpath .bigint(), .integer(),
            and .number()<br>
            &gt; methods.  The JSON string or a numeric value is
            converted to the<br>
            &gt; bigint, int4, and numeric type representation.<br>
            <br>
            A comment that applies to all of these: These add various
            keywords, <br>
            switch cases, documentation entries in some order.  Are we
            happy with <br>
            that?  Should we try to reorder all of that for better
            maintainability <br>
            or readability?<br>
          </blockquote>
          <div><br>
          </div>
          Yeah, that's the better suggestion. While implementing these
          methods, I was confused about where to put them exactly and
          tried keeping them in some logical place.<br>
          <div>I think once these methods get in, we can have a
            follow-up patch reorganizing all of these.</div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>I think it would be better to organize things how we want them
      before adding in more stuff.</p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><br>
    </p>
    <pre class="moz-signature" signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------eVrhltvEb8lmrNtrh09wj9u0--