Content-Type: multipart/mixed; boundary="------------G5EnD8GJ0d4Ejzhlxoa2cZPe"
Message-ID: <bc089939-a889-4fd4-bad8-42cc071cd58e@pgbackrest.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Improve checks for GUC recovery_target_xid
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
 =?UTF-8?Q?H=C3=BCseyin_Demir?= <huseyin.d3r@gmail.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
References: <f14463ab-990b-4ae9-a177-998d2677aae0@pgbackrest.org>
 <CAHGQGwEnakTrosMp3Y=Trya4MTC-h8Lqx3FDU1mOALRQ0rz59Q@mail.gmail.com>
 <9e8b7ee9-4a16-477a-baa5-0cdf37a04798@pgbackrest.org>
 <CAHGQGwG44vZbSoBmg076G+xkR6n=Tj2=q+fVkfP7yEsyF1daFA@mail.gmail.com>
 <c2e97e35-1227-4351-8faa-fa95208f6cf9@pgbackrest.org>
 <aakAmNjKyBWRU1vR@paquier.xyz>
 <e6a27751-8c91-4bff-ba07-2e97de99e34f@pgbackrest.org>
 <CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
Content-Language: en-US
From: David Steele <david@pgbackrest.org>
In-Reply-To: 
 <CAHGQGwEYYad_=fiBkt8HZ=aknXoCUx=2cL7UwSQSYM3nozHMyg@mail.gmail.com>
Date: Thu,  5 Mar 2026 08:15:29 +0000 (UTC)
Archived-At: 
 <https://www.postgresql.org/message-id/bc089939-a889-4fd4-bad8-42cc071cd58e%40pgbackrest.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------G5EnD8GJ0d4Ejzhlxoa2cZPe
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 3/5/26 12:03, Fujii Masao wrote:
> On Thu, Mar 5, 2026 at 1:21 PM David Steele <david@pgbackrest.org> wrote:
>> The prior standby is not running because of the invalid config. I
>> figured it was better to start clean but when I update the
>> recovery_target_timeline tests I was planning to use the same standby
>> for all the new tests.
> 
> Alternatively, we can use $node_primary, since ALTER SYSTEM SET with
> invalid recovery_target_timeline or recovery_target_xid does not
> affect the primary.

Well, as it turns out I was using the primary after all because I copied 
your example and forgot to update the host. Seems weird to set these 
GUCs on the primary but as long as we get the expected errors I don't 
suppose it matters.

Regards,
-David
--------------G5EnD8GJ0d4Ejzhlxoa2cZPe
Content-Type: text/plain; charset=UTF-8; name="recovery-target-xid-v4.patch"
Content-Disposition: attachment; filename="recovery-target-xid-v4.patch"
Content-Transfer-Encoding: base64

RnJvbSA3N2ZkZjdiMzY1ZDk4ODdlYTUyNTIyMjQ4YmEyZDVkNTc1ODI1ZjRiIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBTdGVlbGUgPGRhdmlkQHBnbWFzdGVycy5u
ZXQ+CkRhdGU6IFRodSwgNSBNYXIgMjAyNiAwODoxNDozNiArMDAwMApTdWJqZWN0OiBJbXBy
b3ZlIGNoZWNrcyBmb3IgR1VDIHJlY292ZXJ5X3RhcmdldF94aWQKCkN1cnJlbnRseSBjaGVj
a19yZWNvdmVyeV90YXJnZXRfeGlkKCkgY29udmVydHMgaW52YWxpZCB2YWx1ZXMgdG8gMC4g
U28sCmZvciBleGFtcGxlLCB0aGUgZm9sbG93aW5nIGNvbmZpZ3VyYXRpb24gYWRkZWQgdG8g
cG9zdGdyZXNxbC5jb25mCmZvbGxvd2VkIGJ5IGEgc3RhcnR1cDoKCnJlY292ZXJ5X3Rhcmdl
dF94aWQgPSAnYm9ndXMnCnJlY292ZXJ5X3RhcmdldF94aWQgPSAnMS4xJwpyZWNvdmVyeV90
YXJnZXRfeGlkID0gJzAnCgouLi4gZG9lcyBub3QgZ2VuZXJhdGUgYW4gZXJyb3IgYnV0IHJl
Y292ZXJ5IGRvZXMgbm90IGNvbXBsZXRlLiBUaGVyZSBhcmUKbWFueSB2YWx1ZXMgdGhhdCBj
YW4gcHJldmVudCByZWNvdmVyeSBmcm9tIGNvbXBsZXRpbmcgYnV0IHdlIHNob3VsZCBhdAps
ZWFzdCBjYXRjaCBvYnZpb3VzIG1pc2NvbmZpZ3VyYXRpb24gYnkgdGhlIHVzZXIuCgpUaGUg
b3JpZ2luIG9mIHRoZSBwcm9ibGVtIGlzIHRoYXQgd2UgZG8gbm90IHBlcmZvcm0gYSByYW5n
ZSBjaGVjayBpbiB0aGUKR1VDIHZhbHVlIHBhc3NlZC1pbiBmb3IgcmVjb3ZlcnlfdGFyZ2V0
X3hpZC4gVGhpcyBjb21taXQgaW1wcm92ZXMgdGhlCnNpdHVhdGlvbiBieSB1c2luZyBhZGRp
bmcgZW5kIGNoZWNraW5nIHRvIHN0cnRvdTY0KCkgYW5kIGJ5IHByb3ZpZGluZwpzdHJpY3Rl
ciByYW5nZSBjaGVja3MuIFNvbWUgdGVzdCBjYXNlcyBhcmUgYWRkZWQgZm9yIHRoZSBjYXNl
cyBvZiBhbgppbmNvcnJlY3Qgb3IgYSBsb3dlci1ib3VuZCB0aW1lbGluZSB2YWx1ZSwgY2hl
Y2tpbmcgdGhlIHNhbml0eSBvZiB0aGUKcmVwb3J0cyBiYXNlZCBvbiB0aGUgY29udGVudHMg
b2YgdGhlIHNlcnZlciBsb2dzLgoKQWRkIGEgY29tbWVudCB0aGF0IHRydW5jYXRpb24gb2Yg
dGhlIGlucHV0IHZhbHVlIGlzIGV4cGVjdGVkIHNpbmNlIHVzZXJzCndpbGwgZ2VuZXJhbGx5
IGJlIHVzaW5nIHRoZSBvdXRwdXQgZnJvbSBwZ19jdXJyZW50X3hhY3RfaWQoKSAob3IKc2lt
aWxhcikgdG8gc2V0IHJlY292ZXJ5X3RhcmdldF94aWQgKGp1c3QgYXMgb3VyIHRlc3RzIGRv
KS4KCkFsc28gdXBkYXRlIHRoZSBkb2N1bWVudGF0aW9uIGZvciByZWNvdmVyeV90YXJnZXRf
eGlkIHRvIGNsYXJpZnkgdXNhZ2UuCi0tLQogZG9jL3NyYy9zZ21sL2NvbmZpZy5zZ21sICAg
ICAgICAgICAgICAgICAgICB8IDE1ICsrKysrKysrKysKIHNyYy9iYWNrZW5kL2FjY2Vzcy90
cmFuc2FtL3hsb2dyZWNvdmVyeS5jICAgfCAzMSArKysrKysrKysrKysrKysrKysrLS0KIHNy
Yy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5X3RhcmdldHMucGwgfCAyMiArKysrKysr
KysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNjYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv
bnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwgYi9kb2Mvc3Jj
L3NnbWwvY29uZmlnLnNnbWwKaW5kZXggZjY3MGUyZDRjMzEuLjk0OWI4NmU0ZTcwIDEwMDY0
NAotLS0gYS9kb2Mvc3JjL3NnbWwvY29uZmlnLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL2Nv
bmZpZy5zZ21sCkBAIC00MzM0LDYgKzQzMzQsMjEgQEAgcmVzdG9yZV9jb21tYW5kID0gJ2Nv
cHkgIkM6XFxzZXJ2ZXJcXGFyY2hpdmVkaXJcXCVmIiAiJXAiJyAgIyBXaW5kb3dzCiAgICAg
ICAgIFRoZSBwcmVjaXNlIHN0b3BwaW5nIHBvaW50IGlzIGFsc28gaW5mbHVlbmNlZCBieQog
ICAgICAgICA8eHJlZiBsaW5rZW5kPSJndWMtcmVjb3ZlcnktdGFyZ2V0LWluY2x1c2l2ZSIv
Pi4KICAgICAgICA8L3BhcmE+CisKKyAgICAgICA8cGFyYT4KKyAgICAgICAgVGhlIHZhbHVl
IGNhbiBiZSBzcGVjaWZpZWQgYXMgZWl0aGVyIGEgMzItYml0IHRyYW5zYWN0aW9uIElEIG9y
IGEgNjQtYml0CisgICAgICAgIHRyYW5zYWN0aW9uIElEIChjb25zaXN0aW5nIG9mIGFuIGVw
b2NoIGFuZCBhIDMyLWJpdCBJRCksIHN1Y2ggYXMgdGhlCisgICAgICAgIHZhbHVlIHJldHVy
bmVkIGJ5IDxmdW5jdGlvbj5wZ19jdXJyZW50X3hhY3RfaWQoKTwvZnVuY3Rpb24+LiBXaGVu
IGEKKyAgICAgICAgNjQtYml0IHRyYW5zYWN0aW9uIElEIGlzIHByb3ZpZGVkLCBvbmx5IGl0
cyAzMi1iaXQgdHJhbnNhY3Rpb24gSUQKKyAgICAgICAgcG9ydGlvbiBpcyB1c2VkIGFzIHRo
ZSByZWNvdmVyeSB0YXJnZXQuIEZvciBleGFtcGxlLCB0aGUgdmFsdWVzCisgICAgICAgIDQy
OTQ5NjgyOTYgKGVwb2NoIDEpIGFuZCA4NTg5OTM1NTkyIChlcG9jaCAyKSBib3RoIHJlZmVy
IHRvIHRoZSBzYW1lCisgICAgICAgIDMyLWJpdCB0cmFuc2FjdGlvbiBJRCwgMTAwMC4KKyAg
ICAgICA8L3BhcmE+CisKKyAgICAgICA8cGFyYT4KKyAgICAgICAgVGhlIGVmZmVjdGl2ZSB0
cmFuc2FjdGlvbiBJRCAodGhlIDMyLWJpdCBwb3J0aW9uKSBtdXN0IGJlIGdyZWF0ZXIgdGhh
bgorICAgICAgICBvciBlcXVhbCB0byAzLgorICAgICAgIDwvcGFyYT4KICAgICAgIDwvbGlz
dGl0ZW0+CiAgICAgIDwvdmFybGlzdGVudHJ5PgogCmRpZmYgLS1naXQgYS9zcmMvYmFja2Vu
ZC9hY2Nlc3MvdHJhbnNhbS94bG9ncmVjb3ZlcnkuYyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy90
cmFuc2FtL3hsb2dyZWNvdmVyeS5jCmluZGV4IGVjZDY2ZmQ4NmE0Li5mZDAzNDVhNjVmOCAx
MDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMK
KysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5zYW0veGxvZ3JlY292ZXJ5LmMKQEAgLTUx
MDgsMTEgKzUxMDgsMzggQEAgY2hlY2tfcmVjb3ZlcnlfdGFyZ2V0X3hpZChjaGFyICoqbmV3
dmFsLCB2b2lkICoqZXh0cmEsIEd1Y1NvdXJjZSBzb3VyY2UpCiAJewogCQlUcmFuc2FjdGlv
bklkIHhpZDsKIAkJVHJhbnNhY3Rpb25JZCAqbXlleHRyYTsKKwkJY2hhcgkJICAqZW5kcDsK
KwkJY2hhciAJCSAgKnZhbDsKIAogCQllcnJubyA9IDA7Ci0JCXhpZCA9IChUcmFuc2FjdGlv
bklkKSBzdHJ0b3U2NCgqbmV3dmFsLCBOVUxMLCAwKTsKLQkJaWYgKGVycm5vID09IEVJTlZB
TCB8fCBlcnJubyA9PSBFUkFOR0UpCisKKwkJLyoKKwkJICogQ29uc3VtZSBsZWFkaW5nIHdo
aXRlc3BhY2UgdG8gZGV0ZXJtaW5lIGlmIG51bWJlciBpcyBuZWdhdGl2ZQorCQkgKi8KKwkJ
dmFsID0gKm5ld3ZhbDsKKworCQl3aGlsZSAoaXNzcGFjZSgodW5zaWduZWQgY2hhcikqdmFs
KSkKKwkJCXZhbCsrOworCisJCS8qCisJCSAqIFRoaXMgY2FzdCB3aWxsIHJlbW92ZSB0aGUg
ZXBvY2gsIGlmIGFueQorCQkgKi8KKwkJeGlkID0gKFRyYW5zYWN0aW9uSWQpIHN0cnRvdTY0
KHZhbCwgJmVuZHAsIDApOworCisJCWlmICgqZW5kcCAhPSAnXDAnIHx8IGVycm5vID09IEVJ
TlZBTCB8fCBlcnJubyA9PSBFUkFOR0UgfHwgKnZhbCA9PSAnLScpCisJCXsKKwkJCUdVQ19j
aGVja19lcnJkZXRhaWwoIlwiJXNcIiBpcyBub3QgYSB2YWxpZCBudW1iZXIuIiwKKwkJCQkJ
CQkJInJlY292ZXJ5X3RhcmdldF94aWQiKTsKIAkJCXJldHVybiBmYWxzZTsKKwkJfQorCisJ
CWlmICh4aWQgPCBGaXJzdE5vcm1hbFRyYW5zYWN0aW9uSWQpCisJCXsKKwkJCUdVQ19jaGVj
a19lcnJkZXRhaWwoIlwiJXNcIiB3aXRob3V0IGVwb2NoIG11c3QgYmUgZ3JlYXRlciB0aGFu
IG9yIGVxdWFsIHRvICV1LiIsCisJCQkJCQkJCSJyZWNvdmVyeV90YXJnZXRfeGlkIiwKKwkJ
CQkJCQkJRmlyc3ROb3JtYWxUcmFuc2FjdGlvbklkKTsKKwkJCXJldHVybiBmYWxzZTsKKwkJ
fQogCiAJCW15ZXh0cmEgPSAoVHJhbnNhY3Rpb25JZCAqKSBndWNfbWFsbG9jKExPRywgc2l6
ZW9mKFRyYW5zYWN0aW9uSWQpKTsKIAkJaWYgKCFteWV4dHJhKQpkaWZmIC0tZ2l0IGEvc3Jj
L3Rlc3QvcmVjb3ZlcnkvdC8wMDNfcmVjb3ZlcnlfdGFyZ2V0cy5wbCBiL3NyYy90ZXN0L3Jl
Y292ZXJ5L3QvMDAzX3JlY292ZXJ5X3RhcmdldHMucGwKaW5kZXggZTBkZjFhMjM0MjMuLjRl
MzZlM2EzZmI1IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWNvdmVyeS90LzAwM19yZWNvdmVy
eV90YXJnZXRzLnBsCisrKyBiL3NyYy90ZXN0L3JlY292ZXJ5L3QvMDAzX3JlY292ZXJ5X3Rh
cmdldHMucGwKQEAgLTI0MCw0ICsyNDAsMjYgQEAgb2soISRyZXMsICdpbnZhbGlkIHRpbWVs
aW5lIHRhcmdldCAodXBwZXIgYm91bmQgY2hlY2spJyk7CiAkbG9nX3N0YXJ0ID0KICAgJG5v
ZGVfc3RhbmRieS0+d2FpdF9mb3JfbG9nKCJtdXN0IGJlIGJldHdlZW4gMSBhbmQgNDI5NDk2
NzI5NSIsICRsb2dfc3RhcnQpOwogCisjIEludmFsaWQgcmVjb3ZlcnlfdGFyZ2V0X3hpZCB0
ZXN0cworbXkgKCRyZXN1bHQsICRzdGRvdXQsICRzdGRlcnIpID0gJG5vZGVfcHJpbWFyeS0+
cHNxbCgncG9zdGdyZXMnLAorCSJBTFRFUiBTWVNURU0gU0VUIHJlY292ZXJ5X3RhcmdldF94
aWQgVE8gJ2JvZ3VzJyIpOworbGlrZSgKKwkkc3RkZXJyLAorCXFyL2lzIG5vdCBhIHZhbGlk
IG51bWJlci8sCisJImludmFsaWQgcmVjb3ZlcnlfdGFyZ2V0X3hpZCAoYm9ndXMgdmFsdWUp
Iik7CisKKygkcmVzdWx0LCAkc3Rkb3V0LCAkc3RkZXJyKSA9ICRub2RlX3ByaW1hcnktPnBz
cWwoJ3Bvc3RncmVzJywKKwkiQUxURVIgU1lTVEVNIFNFVCByZWNvdmVyeV90YXJnZXRfeGlk
IFRPICctMSciKTsKK2xpa2UoCisJJHN0ZGVyciwKKwlxci9pcyBub3QgYSB2YWxpZCBudW1i
ZXIvLAorCSJpbnZhbGlkIHJlY292ZXJ5X3RhcmdldF94aWQgKG5lZ2F0aXZlKSIpOworCiso
JHJlc3VsdCwgJHN0ZG91dCwgJHN0ZGVycikgPSAkbm9kZV9wcmltYXJ5LT5wc3FsKCdwb3N0
Z3JlcycsCisJIkFMVEVSIFNZU1RFTSBTRVQgcmVjb3ZlcnlfdGFyZ2V0X3hpZCBUTyAnMCci
KTsKK2xpa2UoCisJJHN0ZGVyciwKKwlxci93aXRob3V0IGVwb2NoIG11c3QgYmUgZ3JlYXRl
ciB0aGFuIG9yIGVxdWFsIHRvIDMvLAorCSJpbnZhbGlkIHJlY292ZXJ5X3RhcmdldF94aWQg
KGxvd2VyIGJvdW5kIGNoZWNrKSIpOworCiBkb25lX3Rlc3RpbmcoKTsKLS0gCjIuMzQuMQoK


--------------G5EnD8GJ0d4Ejzhlxoa2cZPe--