Feedback-ID: ie0a040ee:Fastmail
Message-ID: <bc0ddf01-d54f-4a9b-9cf9-a3bf02731fde@eisentraut.org>
Date: Tue, 9 Jan 2024 17:41:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Adding a pg_get_owned_sequence function?
Content-Language: en-US
To: Nathan Bossart <nathandbossart@gmail.com>,
 =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
Cc: vignesh C <vignesh21@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-hackers@postgresql.org
References: <87jzwcsasv.fsf@wibble.ilmari.org>
 <4970adf1-cdb0-9ae5-d405-e9c3395d9931@eisentraut.org>
 <2797313.1694529622@sss.pgh.pa.us> <87v8cfo32v.fsf@wibble.ilmari.org>
 <20231024162929.GA871220@nathanxps13>
 <CALDaNm0_nn-LXSJCXQ6EYiGKjVO8fVO8AemgEVZFQPPdx0=fkg@mail.gmail.com>
 <87a5pfn4o5.fsf@wibble.ilmari.org> <20240108210847.GA2796792@nathanxps13>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <20240108210847.GA2796792@nathanxps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/bc0ddf01-d54f-4a9b-9cf9-a3bf02731fde%40eisentraut.org>
Precedence: bulk

On 08.01.24 22:08, Nathan Bossart wrote:
> I think these are reasonable concerns, but with this patch, we now have the
> following functions:
> 
> 	pg_get_identity_sequence(table regclass, column name) -> regclass
> 	pg_get_serial_sequence(table text, column text) -> text
> 
> If we only look at the names, it sure sounds like the first one only works
> for identity columns, and the second only works for serial columns.  But
> both work for identity_and_  serial.  The real differences between the two
> are the parameter and return types.  Granted, this is described in the
> documentation updates, but IMHO this is a kind-of bizarre state to end up
> in.

Yeah, that's really weird.

Would it work to change the signature of pg_get_serial_sequence to

     pg_get_serial_sequence(table anyelement, column text) -> anyelement

and then check inside the function code whether text or regclass was passed?