Message-ID: <bc73f8dc-07ab-499e-b36d-8fc8c98faa13@tantorlabs.com>
Date: Thu, 26 Feb 2026 11:57:26 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Hash-based MCV matching for large IN-lists
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Tatsuya Kawata <kawatatatsuya0913@gmail.com>,
 David Geier <geidav.pg@gmail.com>, Chengpeng Yan
 <chengpeng_yan@outlook.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
References: <7db341e0-fbc6-4ec5-922c-11fdafe7be12@tantorlabs.com>
 <c5c7cf37-218d-405a-8dde-520aa313830a@gmail.com>
 <988e3168-6096-488a-bb42-787e1e8c21a4@tantorlabs.com>
 <21FF6A0B-886F-4132-B6A6-0F4E934B4CEE@Outlook.com>
 <8ee9d903-bb13-434c-8145-b3769bf2b3cb@tantorlabs.com>
 <ff7d491d-f084-4935-8417-c0b7285cdd89@gmail.com>
 <CAHza6qdAH99C0xa27YDTixiNVFa99j90QYquUPAxL0JwahmggA@mail.gmail.com>
 <9e3054ae-1c5d-46dd-9b6a-7fb67764b076@tantorlabs.com>
 <CAN4CZFPb+iqQkby4AGvZSvL2OkwQ+S9CVvmJiQ=u6cckWPetqA@mail.gmail.com>
 <9067a807-f130-4631-8df4-076c6d7e43b6@tantorlabs.com>
Content-Language: en-US
In-Reply-To: <9067a807-f130-4631-8df4-076c6d7e43b6@tantorlabs.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/bc73f8dc-07ab-499e-b36d-8fc8c98faa13%40tantorlabs.com>
Precedence: bulk

On 2/26/26 01:45, Ilia Evdokimov wrote:

> About op_is_reserved. It seems we should assign op_is_reserved = true, 
> because we don't reverse types like eqjoinsel_semi(). If IN-list 
> smaller than MCV-list we reverse it by fmgr_info(hash_mcv ? hashLeft : 
> hashRight, &hash_proc). Thanks for this remark.
>
I guess I rushed to conclusions. This assignment op_is_reversed = true 
was incorrect. During lookups, simplehash passes: key0 as the value 
stored in the hash table, key1 as the probe value. Since MCV entries 
correspond to the variable's statistics, the correct argument order 
depends on which side we build the hash table on. If we hash MCV values 
(hash_mcv = true), then key0 = MCV value, key1 = IN-list value, so we 
must call operator(key0, key1). If we hash IN-list elements (hash_mcv = 
fasle), then key0 = IN-list value, key1 = MCV value and we must call 
operator(key1, key0). Therefore the correct assignment is 
hashContext.op_is_reversed = hash_mcv.

If you have another suggestions to v6 patches, send them, and I'll fix 
them with hashContext.op_is_reversed = hash_mcv.

-- 
Best regards,
Ilia Evdokimov,
Tantor Labs LLC,
https://tantorlabs.com/