Subject: Re: SELECT INTO deprecation
To: Michael Paquier <michael@paquier.xyz>
References: <96dc0df3-e13a-a85d-d045-d6e2c85218da@enterprisedb.com>
 <20201202175836.GX16415@tamriel.snowman.net>
 <1672926.1606941346@sss.pgh.pa.us> <X8gpP9GL7R5AsF3E@paquier.xyz>
 <8e05fc79-abca-dd3f-4d48-8aaae9525a8f@enterprisedb.com>
 <1723856.1607009655@sss.pgh.pa.us>
 <a71c0215-3ab1-abab-babe-2778b17aa1d7@enterprisedb.com>
 <737048bf-de51-3fd4-bbcc-89f6d2bd2c4f@enterprisedb.com>
 <20201215221325.GA14807@momjian.us>
 <b2f854c2-f780-c739-064c-cb856e9e213f@enterprisedb.com>
 <X9q0qXzF7c+clssU@paquier.xyz>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
 Stephen Frost <sfrost@snowman.net>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Organization: EnterpriseDB
Message-ID: <bd018f4a-4ae9-386e-2cea-3464df62f980@enterprisedb.com>
Date: Sat, 30 Jan 2021 11:29:44 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <X9q0qXzF7c+clssU@paquier.xyz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-12-17 02:30, Michael Paquier wrote:
> On Wed, Dec 16, 2020 at 06:07:08PM +0100, Peter Eisentraut wrote:
>> Right, we would very likely not add it now.  But it doesn't seem to cause a
>> lot of ongoing maintenance burden, so if there is a use case, it's not
>> unreasonable to keep it around.  I have no other motive here, I was just
>> curious.
> 
>  From the point of view of the code, this would simplify the grammar
> rules of SELECT, which is a good thing.  And this would also simplify
> some code in the rewriter where we create some CreateTableAsStmt
> on-the-fly where an IntoClause is specified, but my take is that this
> is not really a burden when it comes to long-term maintenance.  And
> the git history tells, at least it seems to me so, that this is not
> manipulated much.

I have committed my small documentation patch that points out 
compatibility with other implementations.