Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRSIE-0001Eo-Tw for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Dec 2017 00:31:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRSID-0004u0-8X for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Dec 2017 00:31:29 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eRSIC-0004th-Rn for pgsql-hackers@lists.postgresql.org; Wed, 20 Dec 2017 00:31:29 +0000 Received: from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eRSIA-0001KV-4o for pgsql-hackers@postgresql.org; Wed, 20 Dec 2017 00:31:27 +0000 Received: by mail-wr0-x231.google.com with SMTP id y21so20861406wrc.1 for ; Tue, 19 Dec 2017 16:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TfzslvDnbNf6MgIymLLbo9/dLW40Mu04lZMEDz+bdW4=; b=HNPxRqWBLHyQlOWDMseQE1luVRteP5/Q9Ujz6+PRZNxzPxcMeQ7zueBddaEV7Op7eB IYRKYdyTE2KjqkhpMnQRvAKWibdxNcP57u8P5Xn7dBqA7iKNZNqka1GYfoIbNtLb4E5e GV2acwAc13B+gC7OXbM+2xwvEYF518r7aXcc/MQqE3xOVamXddqCwjpJWgGA7taYQZyG fK/IWAfv7pOnX7N94GlJIinezSPh+IbIdPBqRtIkOJ3mJ1lzzV9kf0ldnwwTFKgkXX9k VHN0Qt5ET6wCrTtoKYO2Bvth3RB9FHp4NVZ+tle1kzE7Q+6hncO4L7qCM+URZ8YuCSzD azMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TfzslvDnbNf6MgIymLLbo9/dLW40Mu04lZMEDz+bdW4=; b=Amik1wSt4PV4dcc53hwr1OD2YPRWc4xGZzN1U1l0lPN5VQb5W7VHy9T/egPjY2nEF6 1MO+bLjfYZDJdvcOu0wqTVLda9HJk6aiZ/j4NUBDo+lgp1YcX35hPzR/Xg0tT7cWJu8L 7dnPGmwS1hxC3MSJ+N65yjGhoWF4uIdEskZy0uPsKNqZkd9+rdrcRvEDyb00ScBp3SG3 NedpcZRoXSXzOhHRTkqrYWL+tH7slFSGwYLTwF2J+jxoFvKCztBjp8c3eFMymf46t24w fLj0k6sqioOWvgfLafdVS+lcPlnDsWJRBk62FwaJPRvSXl4rwIAai7R+ck1Aa1OuF6qX rxGA== X-Gm-Message-State: AKGB3mIEnk5taDfUaKB4veLHLnORJZrT8NTERVF6lVf4w8l0Wf6uhYKZ 9Yw8jg8ANI6dNXgxW64JamStciphGLv3ifkMUqNoS86pfc6RJZRmhG7bfTDVqT8Bsfnp+LzdewF nc05P7CfRoJi6l+ixl2hpBqJELWoN0iUhCevd4hFTdm9KbFEh78srJSXu++54v+DD/bNQdBbGm9 RPRsjvQfh2 X-Google-Smtp-Source: ACJfBos2NRgkIY6VcX/iPwzBEjt/jwRjjGUtA9kreESvozLVeKtURkwuyIQcdRA1/DhwZ3Q8kALjaw== X-Received: by 10.223.164.200 with SMTP id h8mr7066530wrb.227.1513729882532; Tue, 19 Dec 2017 16:31:22 -0800 (PST) Received: from [10.137.2.19] (ip-78-102-97-226.net.upcbroadband.cz. [78.102.97.226]) by smtp.gmail.com with ESMTPSA id q74sm4847046wmg.22.2017.12.19.16.31.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Dec 2017 16:31:21 -0800 (PST) Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists To: Mark Dilger Cc: Adrien Nayrat , Pg Hackers References: <31ee8686-6d62-7f10-4129-7580ec74a710@dalibo.com> <340ffd44-2d67-d39d-e54f-5a97a842cd3a@2ndquadrant.com> <67EAB5B3-F9FB-4753-8102-4D77DCFFFCD4@gmail.com> <63aa9ad9-cebd-a842-ea50-7f99b94443cd@2ndquadrant.com> <0938F717-F4A0-4568-83B4-80A19887EA25@gmail.com> <933aab0d-fd36-9494-e0eb-79ebc4f57ef5@2ndquadrant.com> <7F76E900-9A20-4640-A431-83B0602C3213@gmail.com> From: Tomas Vondra Message-ID: Date: Wed, 20 Dec 2017 01:31:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7F76E900-9A20-4640-A431-83B0602C3213@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi, On 12/19/2017 08:17 PM, Mark Dilger wrote: > > I tested your latest patches on my mac os x laptop and got one test > failure due to the results of 'explain' coming up differently. For the record, > I followed these steps: > > cd postgresql/ > git pull > # this got my directory up to 8526bcb2df76d5171b4f4d6dc7a97560a73a5eff with no local changes > patch -p 1 < ../0001-multivariate-MCV-lists.patch > patch -p 1 < ../0002-multivariate-histograms.patch > ./configure --prefix=/Users/mark/master/testinstall --enable-cassert --enable-tap-tests --enable-depend && make -j4 && make check-world > Yeah, those steps sounds about right. Apparently this got broken by ecc27d55f4, although I don't quite understand why - but it works fine before. Can you try if it works fine on 9f4992e2a9 and fails with ecc27d55f4? regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services