Message-ID: <bd843dc2-12be-8b4b-c260-3d3b85b52a2b@enterprisedb.com>
Date: Wed, 23 Mar 2022 21:53:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.7.0
Subject: Re: [PATCH] add relation and block-level filtering to pg_waldump
Content-Language: en-US
To: Thomas Munro <thomas.munro@gmail.com>,
 David Christensen <david.christensen@crunchydata.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <lzzgmgm6e5.fsf@veeddrois.attlocal.net>
 <CALj2ACXjZRWXvUhvUh7xJeRJd7i40KXdS7p6eHHq+q4+xUNf9w@mail.gmail.com>
 <lzwnhiai4i.fsf@veeddrois.attlocal.net>
 <CA+hUKGL6Oh86gBFT0fwLz7=fOpFWm4-fu6Xo9X9VcOKuJ6t9ow@mail.gmail.com>
 <CA+hUKG+i5mp1cxQ0B_04Pq6BJB_k=KfL0b2fdAQtKrGapapmbg@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CA+hUKG+i5mp1cxQ0B_04Pq6BJB_k=KfL0b2fdAQtKrGapapmbg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/bd843dc2-12be-8b4b-c260-3d3b85b52a2b%40enterprisedb.com>
Precedence: bulk

On 21.03.22 05:55, Thomas Munro wrote:
> [04:30:50.630] pg_waldump.c:963:26: error: format ‘%u’ expects
> argument of type ‘unsigned int *’, but argument 3 has type ‘ForkNumber
> *’ [-Werror=format=]
> [04:30:50.630] 963 | if (sscanf(optarg, "%u",
> &config.filter_by_relation_forknum) != 1 ||
> [04:30:50.630] | ~^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [04:30:50.630] | | |
> [04:30:50.630] | | ForkNumber *
> [04:30:50.630] | unsigned int *
> 
> And now that this gets to the CompilerWarnings CI task, it looks like
> GCC doesn't like an enum as a scanf %u destination (I didn't see that
> warning locally when I compiled the above fixup because clearly Clang
> is cool with it...).  Probably needs a temporary unsigned int to
> sscanf into first.

That's because ForkNum is a signed type.  You will probably succeed if 
you use "%d" instead.