Subject: Re: backend type in log_line_prefix?
To: Alvaro Herrera <alvherre@2ndquadrant.com>
References: <20200310180731.GA15183@alvherre.pgsql>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <bd9a336e-1c99-e3dd-8bec-07f2c41723ba@2ndquadrant.com>
Date: Fri, 13 Mar 2020 22:24:02 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200310180731.GA15183@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-10 19:07, Alvaro Herrera wrote:
> I like these patches; the first two are nice cleanup.
> 
> My only gripe is that pgstat_get_backend_desc() is not really a pgstat
> function; I think it should have a different name with a prototype in
> miscadmin.h (next to the enum's new location, which I would put
> someplace near the "pmod.h" comment rather than where you put it;
> perhaps just above the AuxProcType definition), and implementation
> probably in miscinit.c.

I have committed the refactoring patches with adjustments along these 
lines.  The patch with the log_line_prefix and csvlog enhancements is 
still under discussion.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services