Feedback-ID: ie0a040ee:Fastmail
Message-ID: <bdf8f5bc-ea45-687a-7a37-807ebbd4674f@eisentraut.org>
Date: Mon, 28 Aug 2023 08:44:25 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: Convert encrypted SSL test keys to PKCS#8 format
Content-Language: en-US
To: Jacob Champion <jchampion@timescale.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <64de784b-8833-e055-3bd4-7420e6675351@eisentraut.org>
 <CAAWbhmh8GMZvhGy097cHiy584KUb9ee7Gs0x+gD8+w0hryJW+A@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CAAWbhmh8GMZvhGy097cHiy584KUb9ee7Gs0x+gD8+w0hryJW+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/bdf8f5bc-ea45-687a-7a37-807ebbd4674f%40eisentraut.org>
Precedence: bulk

On 22.08.23 21:02, Jacob Champion wrote:
> On Tue, Aug 22, 2023 at 1:07 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I have attached two patches, one to update the generation rules, and one
>> where I have converted the existing test files.  (I didn't generate them
>> from scratch, so for example
>> src/test/modules/ssl_passphrase_callback/server.crt that corresponds to
>> one of the keys does not need to be updated.)
> 
> Looks good from here. I don't have a FIPS setup right now, but the new
> files pass tests on OpenSSL 1.0.2u, 1.1.1v, 3.0.2-0ubuntu1.10, and
> LibreSSL 3.8. Tests continue to pass after a full clean and rebuild of
> the sslfiles.

Committed, thanks.