Feedback-ID: i131946ab:Fastmail
Message-ID: <be1205f8-de95-8d69-bcc4-6c769c703f5f@enterprisedb.com>
Date: Fri, 25 Nov 2022 17:13:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.2
Subject: Re: Non-decimal integer literals
Content-Language: en-US
To: David Rowley <dgrowleyml@gmail.com>
Cc: John Naylor <john.naylor@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <b239564c-cad0-b23e-c57e-166d883cb97d@enterprisedb.com>
 <c42cb38a-ac42-dd92-2935-dce3b9806e26@enterprisedb.com>
 <CA+TgmoZv2Q11P1JbF+ziu1b8vsBpcjfPqXsHMR0hJqSTeLP1xQ@mail.gmail.com>
 <bef9c869-e773-f792-fde2-d7555add2879@enterprisedb.com>
 <CA+TgmoZRJzBe6yKeBpQ2auHndeV-bzygSY=gr0A0KixZ2giKNg@mail.gmail.com>
 <2317133.1643155358@sss.pgh.pa.us>
 <97aa22d7-b80f-efa1-f368-3dbf73a15980@enterprisedb.com>
 <CAFBsxsGcgqJ_KO-1=jCUJKK2z5rCh2qsf7=VgNWzTvakLMDyBQ@mail.gmail.com>
 <bc462aff-675b-86e2-46e3-7eaf5ce3e75f@enterprisedb.com>
 <071c40f2-15cf-5db3-8799-dbac041bb881@enterprisedb.com>
 <CAFBsxsG4m9qK=vyLAj2DGo3vZ6AC0vRxA4gWtExH5RGP=sPo_Q@mail.gmail.com>
 <b70b15fc-7f8d-5370-21fc-4ec3c154aef3@enterprisedb.com>
 <791aee01-f488-0706-2694-08c5b57a3bdd@enterprisedb.com>
 <CAApHDvr6m8Sipff_MjqyQ8HLeDA3LB5x9zE1oMBPBLxFwTUKQw@mail.gmail.com>
 <068f0344-ccce-c623-3cfe-d09752db158d@enterprisedb.com>
 <CAApHDvoqToAG_At7gBZNSD1PaadRfS40gP3JraGBY76As-t5Ow@mail.gmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: 
 <CAApHDvoqToAG_At7gBZNSD1PaadRfS40gP3JraGBY76As-t5Ow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/be1205f8-de95-8d69-bcc4-6c769c703f5f%40enterprisedb.com>
Precedence: bulk

On 24.11.22 10:13, David Rowley wrote:
> On Thu, 24 Nov 2022 at 21:35, Peter Eisentraut
> <peter.eisentraut@enterprisedb.com> wrote:
>> My code follows the style used for parsing the decimal integers.
>> Keeping that consistent is valuable I think.  I think the proposed
>> change makes the code significantly harder to understand.  Also, what
>> you are suggesting here would amount to an attempt to make parsing
>> hexadecimal integers even faster than parsing decimal integers.  Is that
>> useful?
> 
> Isn't it being faster one of the major use cases for this feature?

Never thought about it that way.

> I
> remember many years ago and several jobs ago when working with SQL
> Server being able to speed up importing data using hexadecimal
> DATETIMEs. I can't think why else you might want to represent a
> DATETIME as a hexstring, so I assumed this was a large part of the use
> case for INTs in PostgreSQL. Are you telling me that better
> performance is not something anyone will want out of this feature?

This isn't about datetimes but about integers.