Message-ID: <be219c8a903f9c8a190c503cd5a6d084a56fd9a5.camel@gmail.com>
Subject: Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative
 implementations?)
From: "Jonathan Gonzalez V." <jonathan.abdiel@gmail.com>
To: Jacob Champion <jacob.champion@enterprisedb.com>, Zsolt Parragi
	 <zsolt.parragi@percona.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Chao Li
	 <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAOYmi+=Pr7AAdkcKXyLw3ycxcrjGKsOV2CTYVV2PKYQw9ecG0Q@mail.gmail.com>
References: 
	<CAOYmi+mrGg+n_X2MOLgeWcj3v_M00gR8uz_D7mM8z=dX1JYVbg@mail.gmail.com>
	 <3720B2E1-0B96-4063-8D63-B5AE6AFEA159@gmail.com>
	 <CAOYmi+mwzS4xfgomL1Lte+W1hRk+zahhZLnRMDJ8nYxoHUWt_w@mail.gmail.com>
	 <CAOYmi+mEU_q9sr1PMmE-4rLwFN=OjyndDwFZvpsMU3RNJLrM9g@mail.gmail.com>
	 <CAN4CZFPwdH_GMrappThju=t4m5n95Dse6ecTNwN=h4GpZLOMng@mail.gmail.com>
	 <CAOYmi+m-hphbx=CRfGSdcrHi-jL3OrZGJMTAPOYp=OK253hBTA@mail.gmail.com>
	 <CAOYmi+nnYr_Oe=KH2ZW6Ld88eZWv5P-s5ZtWOEh2KsPtMqOzbg@mail.gmail.com>
	 <CAOYmi+nCg5upBVOo_UCSjMfO=YMkZXcSEsgaADKXqerr5wahZQ@mail.gmail.com>
	 <CAOYmi+nRmt+K+ZVNztKFv=LuasDCCSsXLihZB6BEkVeroW8EvA@mail.gmail.com>
	 <CAN4CZFOMv=0Y1PZ8uw3xgJmEqt4D1dr1-yOq9jjZYTARZp7H9Q@mail.gmail.com>
	 <CAOYmi+mLaohk3FLbH9fKGmzN7yFGHs2Zefdyp31wbL1130puiA@mail.gmail.com>
	 <CAOYmi+=Pr7AAdkcKXyLw3ycxcrjGKsOV2CTYVV2PKYQw9ecG0Q@mail.gmail.com>
Autocrypt: addr=jonathan.abdiel@gmail.com; prefer-encrypt=mutual;
 keydata=mQINBF1Rbm8BEADc2lW3toboDjMLry1spo/hxUiMKlA+CDCMwXPZPvyB4TGCQAVYnU+gS
 NgBJ8H7CF8ghllm9OYeqdRoRvr1unQN5RUShUWTsLhznUu5KV0KfhFbEjQyH7lDeVCzMRNr5r27QT
 RrmycqAacistMqtjfnsG/j8+HQU9tLrOdnhsxIRUZN/guHBEwx3LVp77lf9HMWabnSgGQVOqhUzA6
 P97j8oWRwQNDZjHFVf5k4HMHJRp8OzcvXUOSa+ynH33xBsrLPDza0X6y7pZlfYbmjXdwU/XKSd7oB
 4BeChFbrmdilIeSAGKLAHURH9jKeRxDt9pzYMvsIiK9UZlThnEgAVM2IqQzhnzd4jxG13Hi8HZ82O
 2Ng4n36kVh5uz0NoIGJ6Guw9R+gqHHxbeSdt8S0P+2VO80UTX+hF7OPbLjE7w8wsTt37Ekp+jRxUs
 RooShDvnUENiw+TkyPszUZ0k9BZmfwcaC3++WDYyWvGK20wty3ZZMjl69SDdQXQaRu8E59leIpKw6
 p8HBBAGZgytVPUN61w52r9dgX9RW0ujBrEztRNWPaDauedKGCXrL678mq7KwYW6Rg+y9orvZJPLUq
 Z7/m8RJUaeuJdz2LJ2bioUJ2BaPX7YxXdqMm9LZWknzy/pyF8iZHXD5D3H+WNJROlcQ6TQNLqUB11
 KRK0koNeqiNbwARAQABtDlKb25hdGhhbiBHb256YWxleiBWLiA8am9uYXRoYW4uZ29uemFsZXpAZW
 50ZXJwcmlzZWRiLmNvbT6JAlQEEwEKAD4CGwMCHgECF4AFCwkIBwMFFQoJCAsFFgIDAQAWIQQSbD6
 5ytnQRUDy/MNDze8Kc6UcxQUCaY2PJAUJDh1UNQAKCRBDze8Kc6UcxXl0D/9GitE44UsOyJKtRR/Q
 T45vrSkg+OsHFQQTTJmAZf+jzeMMvW9PDHnG9aX+JEM8vDl6EL6X3Q2sf7/Yi4XX7FneiNNpBJGml
 Ak7DsNQRwP6wnD5AOteDztBFm5QMJTqoVOqQn3/WtFUuJfPEd9fNaUh8DUhXXScKEqSqBSr+bZE1/
 fVF/i5nCSwlOTXVIPaVGB2Q92eGfXQnwSK2pxV5+VBP6oiW3bTf1HwD+NpKEAWDJ2utc4OAXmLuGU
 ZdiaxuUwud0xTgHxBPoei2C9SsuJ7VjlqYXUN2EgFdAysH3Gx9hHVEDE/dG2kq6K72hG2ze5Zzp2u
 Xg3QZVcTN90WWTblhFyB/dGm5iBCClPHqyhSCFdYrclEY/4kPafl3WLiKkRZyb2GZ96uLu8LYt9/F
 sLsc3HR3i3rGQ0XIdiUcbaSG4OE7rJDGV+hTfu7xxPzy1Wc4bclqmdya5g4I0u5saM9NBEYpPc5E9
 Bb/w8F+QQZ6XVITGUxgdr0K3anflleAANqtNGpW5pQE5ukRKpqcl1YK8PkuxdHf/RjbB3RSx3h6qw
 NTQqlZWmzk6fotgFfgD1EK8brCIRYMJutWvAiDQ+AWrfGdEGx0ZrbjEqR/67DTNJXMEOIDPc/eVvD
 qe5F7IvxrFu06EEC6E97K6aTHfm339RlE4+DpqLrjnls/vIJ/LQwSm9uYXRoYW4gR29uemFsZXogV
 i4gPGpvbmF0aGFuLmFiZGllbEBnbWFpbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUKCQ
 gLBRYCAwEAFiEEEmw+ucrZ0EVA8vzDQ83vCnOlHMUFAmmNjyUFCQ4dVDUACgkQQ83vCnOlHMVwJQ/
 9GAxjP7q/ZU/ZmZ1kBdeAzsL0AZLGkXnkDCdIrXS9NB1gR63bjLzIFvyAKpofRuJkKex1ZorDeXmd
 DrIXCcZTRFSxq13X81z4QANFWMe/a7MTG0f7b0t7FTfmjq4QeC8zcbuj3zS4dvBMGH2QdOSrttnnz
 ogTAnVK0tg8dF+8mWQ6fHoepch0Zlcbb1nnMGdcEdq6D9kwpYQWhD64dFmou+NrG8cFAbskmEqSbu
 FjmQIjPY9yhYhMtJzB32eCkcSXrpEQiEDhy/2YVyzQ/xPnSLgPa1n6J04DbsO38GFADhT6oJowunj
 8WGbN7e1XJr2qAo/pnmqdfn4eEXIPSgfQhIRT4Z/JwR/IljYHD5HJZUA5DTU1zDTEjuOe8YCFkIoi
 QPM07QHeMTP4oyqAEoxv/CTJNDMRt7hx8zvo5OmAg8BmUDX46kwkRlAfNVM01BFnYHiREuW/8mF9H
 fQH8sEiKOfkq0ZyHtuuQ4HXh6MyrfPP2mUzcphG87/bl/rEQIDLqseBqVEc+sfg9zoLezqM7EmfG0
 9dnDH9d1JwhM9UW5TPl7yJq1Zd7nv6DdLog/Cdgdqu6ZroTrv2Vp+jdgmimgZYaWnB2iaj6fNz/w+
 HsitfS+7V+yRUou3+hH5JNkWpGibVosOeYgK8PHMRzqNRl9m859rcrXM/iWYqUFacVXm0N0pvbmF0
 aGFuIEdvbnphbGV6IFYgPGpvbmF0aGFuLmdvbnphbGV6QDJuZHF1YWRyYW50LmNvbT6JAlQEEwEKA
 D4CGwMCHgECF4AFCwkIBwMFFQoJCAsFFgIDAQAWIQQSbD65ytnQRUDy/MNDze8Kc6UcxQUCaY2PJQ
 UJDh1UNQAKCRBDze8Kc6UcxeQaEADHYERzaodpec8m2ZNF04gj9Ra3udvurrpab4598TeKwNsODvZ
 ASMY0fjATtnduEirypa0mS3jMK51XVFz7WUxqm/zccWGCivzn4+Zl8yqhn0Exf57ORACQeB5UJ0UU
 Fl/8Z1LxEe0uS0XiUnS8tfpS/LxP0PkT+gNIS0Tqo1IMZD30ANt4wfrrnR8Bzy2E6/5J0vNtKhpNm
 bdwAT5lwaM0bc+o6IKIaSTpoEdaF1XnW8ThOs2nxhmIQmaFNM48GqeKny65shxYDmn58e093v5T2U
 1QrUUhFt6sAapbSLvekNWBCNlqE6dwDcuYSA53Shn/bX4kLoMX4yk6pfCIr9j+wLShq0mVRznBM+J
 WTF5NtUoD4NvYTXdOfdsnbfDdUFRQDqsDOpl8gsQW3N5Rc54jAAd+W6bgP05GeoiwM+SmedNlJiSQ
 NnMw0vtV8u2B2AVgCD8UvOZP3mLUiTmHymD2HmXIXhOn+O7l5fymNMrCYv5ihAMsA20RExVfZ+I37
 Qt+uJcsPSf7lvcWSJkoB0oktwnq9UUxYF0FNyFfaPGfCKxRvBeVD8qcZpOTWh9pTy0urM31MIaZPh
 MkBrl4WZ2pXqzkkqGn6daY9g5/4oPgazAmqRSfxdDmAbG08STMMvqimaIc2DHYZTRjNKBDvO7Xmef
 plnv3mXrjZZoDBMglnQ==
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="=-K1/6eXz3MFUxXa0QAC8S"
Date: Fri, 13 Mar 2026 08:18:57 +0100
MIME-Version: 1.0
User-Agent: Evolution 3.56.2-4 
Archived-At: 
 <https://www.postgresql.org/message-id/be219c8a903f9c8a190c503cd5a6d084a56fd9a5.camel%40gmail.com>
Precedence: bulk


--=-K1/6eXz3MFUxXa0QAC8S
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello!

On Tue, 2026-03-10 at 09:32 -0700, Jacob Champion wrote:
> On Fri, Mar 6, 2026 at 4:27=E2=80=AFPM Jacob Champion
> <jacob.champion@enterprisedb.com> wrote:
> > I'll cherry-pick some of the -1 handling backwards in the patchset
> > to
> > handle this.
>=20
> Done in v7-0001. Some of the improvements in the WIP patch were also
> cherry-picked, and I fixed a stray comment bug. -0001 and -0002 are
> next up for commit.
>=20

While rebasing this patch[1] I notice that the test where wailing, that
was due to the following missing dependency in the test, small patch
here:

```
diff --git a/src/test/modules/oauth_validator/meson.build
b/src/test/modules/oauth_validator/meson.build
index 915603cbd29..7e52aef7829 100644
--- a/src/test/modules/oauth_validator/meson.build
+++ b/src/test/modules/oauth_validator/meson.build
@@ -97,6 +97,6 @@ tests +=3D {
       'cert_dir': meson.project_source_root() / 'src/test/ssl/ssl',
       'flow_module_path': oauth_flow.full_path(),
     },
-    'deps': [oauth_hook_client],
+    'deps': [oauth_hook_client,oauth_flow],
   },
 }
```


Regards!
[1]
https://www.postgresql.org/message-id/flat/16a91d02795cb991963326a902afa764=
e4d721db.camel@gmail.com
--=20
Jonathan Gonzalez V.=20
EDB: https://www.enterprisedb.com

--=-K1/6eXz3MFUxXa0QAC8S
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEEmw+ucrZ0EVA8vzDQ83vCnOlHMUFAmmzumAACgkQQ83vCnOl
HMW75Q/+LBfksn2Ml7OXs32yL7QDoH7+/wfegFl8eocLgGZju7E1nMSDCDbt110t
XHIoE5hS+iVrg8OpVOm0yZ3mVisnQO2MYe7lN9ToZC73V71Tp4KapE9rdsRNuGpl
Uae0bCOoqlbNSkNg+U/RZ0IbaFvRdwqUIpJUQwLIrDJUkmJ2H1rmm2v21M9O2GrE
7u53lSQkJg5x31uHz5idKw/1v9qtcJhJ08DhAuvZU3VMycOzEH6PFyirjJzUdyld
wnIhTs7np6GybP7yjolnuhvFDJF1qnzDFPE/PJ2lKc0rRoOAhDriAyJsuSdOb9O0
oZxPrAFuE2ncctcSlPDzfBvbQvE4+1ejycmjEQfKCSM/+aZZ8Kt/scanCEhVSRVE
LNW1uqxwoVyg+YgTrfaORAJKfqenDFopqw6CcKUiFYpoav3gbCPlepl0D5C4R8jK
Z+Offl1z3Ht/fQFx8IeC0d6IjOoZKLVV7A9ajSXD/Djz/AFF7Mm5j09deHsqAr4V
ndJI8g10f+kodr8BqFeDcC3CkETYYzYFyXPC2yOBzX5GFKnJd5nCBi3vFHYrk+rU
aHZ+SLWQ1uQohqFmVgUJKj+OH6BXiqi4AmYt2Yc3+PnlRzcTh7upoUXnMg9wDxe2
49VIJ/9PKy3Lif1y7Hva5ZrEfRnaVc9ahK/Z19GUJ13MK7OCYc0=
=xeFD
-----END PGP SIGNATURE-----

--=-K1/6eXz3MFUxXa0QAC8S--