Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1essO1-0001GL-QR for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Mar 2018 15:50:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1essO0-0006LM-L2 for pgsql-hackers@arkaria.postgresql.org; Mon, 05 Mar 2018 15:50:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1essM3-0001Hj-Qx for pgsql-hackers@lists.postgresql.org; Mon, 05 Mar 2018 15:48:47 +0000 Received: from mail-wr0-x22c.google.com ([2a00:1450:400c:c0c::22c]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1essLz-0004ih-NJ for pgsql-hackers@lists.postgresql.org; Mon, 05 Mar 2018 15:48:46 +0000 Received: by mail-wr0-x22c.google.com with SMTP id w77so17787578wrc.6 for ; Mon, 05 Mar 2018 07:48:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ms7DtlLPAFNGZyfmc0Sr1/GKWGpIkzvSKPAP9KwRQwM=; b=SQJlbVjaYQpW9s0a0tAuFzylvqk4IcgLaFWckU1rMfpieaQTxtYGVf1zcKcYJyFRpt 2HY91OTyIR2WsyP7dpn6AYlNkA30aerqdP6kCqDYd26cJQOqmwOsW4glyTSb65+Av9+r ClOxEIsZZigHRmCxm6NbzlsHvt+u1+9RHaq3KeviINk4qFULy9SJZrFA/VcwzK9+4jwJ 4RfJRMZ0m8XnD4XntL//oXE5tAfNZOC5hZ0zSI1m1y0oPs26lDWb7jRJZdj3ybe9G8/E k1NXQFv7YuWLFIWpT0o/W13M5Y7l+klkU7d9fZ0p403a+oQxbXLcgn3RZtiSGqKfCDol Nodg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ms7DtlLPAFNGZyfmc0Sr1/GKWGpIkzvSKPAP9KwRQwM=; b=TQ2NopKYkW1yxCxcpAvybWJKGQr/Srx1ZatCSh8X1ZpzJKM9jshYRSY3nw/iFfe3QF Ak5trdGdjwupBKtsBDdk05HEm5Yiy/z9lqvz3p02zif0tVjXskWGAiXjWVQePKMYbL1L 0RnDl2h0wSDfv+j40AX08q/K2xZUdaUVIZUetjKR9R1SSRpE6g8CaP3+E6wWjf4pqqcJ yNTCq+4KTzRnIcLhMS+lAvi1dptA/qDZeAtgNFitMfgQzsZZtKJDPGitS/nL9PleRry7 E35XmiB6ImJG1DyLUjJdiRpA81PoiB/ljBAXxblFjwfFmK/cx1w3TXuiD4gbOxwDzTOs z0iA== X-Gm-Message-State: APf1xPBTzEJSPvWCFLA3B/IeJe9PNuAAKR+1+0dtqHAUFUuvyZ23GnGv 7dKlUZJh55Ukhy/TlRGe9cahMxAJxCY0zuGquxgJtMsGqvNmYamKZiol/9OmLZpFiHPCLjUcy1o G3ZOR6jvv/mhRNZsXL92pQl/AjInuqbtK2ebTkHKNLEoHujQoF5AxOE+/8ZBFt2tZ5FN+iSA8J6 l6IPJ4/q/sXNgpnbDpoA== X-Google-Smtp-Source: AG47ELsNWrVM1Y4bfACRGYPRSTmO5CEtoSTIuGvoKyFGAj9nYFwyLbu+UwNykPoJ5Q1pN7VTrZ5L6g== X-Received: by 10.223.190.141 with SMTP id i13mr12550206wrh.235.1520264922156; Mon, 05 Mar 2018 07:48:42 -0800 (PST) Received: from [10.8.8.75] ([185.94.189.190]) by smtp.gmail.com with ESMTPSA id z197sm13087599wmz.24.2018.03.05.07.48.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Mar 2018 07:48:41 -0800 (PST) Subject: Re: PATCH: psql tab completion for SELECT To: Edmund Horner Cc: pgsql-hackers@lists.postgresql.org References: <882D6617-FA16-4C56-8FE0-884BCBBE5A4C@anarazel.de> <2738.1516234038@sss.pgh.pa.us> <3a919958-e508-3b66-686f-44a7937fb6e7@2ndquadrant.com> <24314.1520190408@sss.pgh.pa.us> <13e049ac-ae0f-02a1-8979-69fd56dd31d6@2ndquadrant.com> From: Vik Fearing Organization: 2ndQuadrant France Message-ID: Date: Mon, 5 Mar 2018 16:48:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 03/05/2018 11:33 AM, Edmund Horner wrote: > On 5 March 2018 at 21:46, Vik Fearing wrote: >> Tab completion on functions in SELECT (a subset of this thread's patch) >> is quite important to me personally. I will work on this in the coming >> days. > > It's something I've missed numerous times in the last few months at > work. I guess I should really be running a psql with my own > preliminary patches applied; but I'm only a novice pgsql-hacker, and > easily default to using the official one. > > If you are going to work on a patch just for functions, you should > probably make it a SchemaQuery. I did not find a way to support > schema-qualified functions in a query that also returned column names. I meant that I was going to work on your patch, with you, to quickly get this in v11. -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support