Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oR9Q5-0005Oz-Vm for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Aug 2022 09:45:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oR9Q4-0004ty-SZ for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Aug 2022 09:45:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oR9Q3-0004tp-Kh for pgsql-hackers@lists.postgresql.org; Thu, 25 Aug 2022 09:45:00 +0000 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oR9Pz-0001nD-Tb for pgsql-hackers@lists.postgresql.org; Thu, 25 Aug 2022 09:44:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1661420696; x=1692956696; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to; bh=5529IfPtc86SDJKbgFCRoww3z1wxMYEFzsCrQ/4+qXY=; b=CxcPyPYMRUSmiXCZ9+VVba7aqs53bFsTyvD3Y/NwDIUzQ1ZNnBWTWGBZ HN7Y+J9YHpZiYuPnCeJaIY70/ttpYwkcjdMHeJw3875LLZKsyAcBrlL8o Ngert9indUM5ESZZh7CxzmrTJ0tDoNfLbgY8G0K9P6rmyd1mwRFCkyFFT M=; X-Amazon-filename: v3-0001-pgstat_drop_relation-for-indexes.patch X-IronPort-AV: E=Sophos;i="5.93,262,1654560000"; d="scan'208";a="237302735" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-pdx-2a-7d84505d.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2022 09:44:44 +0000 Received: from EX13D03EUC003.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan2.pdx.amazon.com [10.236.137.194]) by email-inbound-relay-pdx-2a-7d84505d.us-west-2.amazon.com (Postfix) with ESMTPS id BF79A10046E; Thu, 25 Aug 2022 09:44:42 +0000 (UTC) Received: from [192.168.24.219] (10.43.161.228) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Thu, 25 Aug 2022 09:44:39 +0000 Content-Type: multipart/mixed; boundary="------------Dfo8OGUymzWRiM0fb8XeU8pw" Message-ID: Date: Thu, 25 Aug 2022 11:44:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: pg_stat_have_stats() returns true for dropped indexes (or for index creation transaction rolled back) Content-Language: en-US To: Kyotaro Horiguchi CC: , References: <51bbf286-2b4a-8998-bd12-eaae4b765d99@amazon.com> <20220822173654.y4h2smhc4kpkvoeg@awork3.anarazel.de> <61a95a06-cf88-cd15-0412-172717943e18@amazon.com> <20220825.114727.330127256246111733.horikyota.ntt@gmail.com> From: "Drouvot, Bertrand" In-Reply-To: <20220825.114727.330127256246111733.horikyota.ntt@gmail.com> X-Originating-IP: [10.43.161.228] X-ClientProxiedBy: EX13D13UWB002.ant.amazon.com (10.43.161.21) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --------------Dfo8OGUymzWRiM0fb8XeU8pw Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Hi, On 8/25/22 4:47 AM, Kyotaro Horiguchi wrote: > Good catch, and thanks for the patch! > > (The file name would correctly be v2-0001-...:) > > At Tue, 23 Aug 2022 09:58:03 +0200, "Drouvot, Bertrand" wrote in >> Agree it's better to move it to heap_create(): it's done in the new >> version attached. > +1 (not considering stats splitting) > >> We'll see later on if it needs to be duplicated for the table/index >> split work. > The code changes looks good to me. Thanks for looking at it! > +-- pg_stat_have_stats returns true for table creation inserting data > +-- pg_stat_have_stats returns true for committed index creation > + > > Not sure we need this, as we check that already in the same file. (In > other words, if we failed this, the should have failed earlier.) That's right. > Maybe > we only need check for drop operations Looking closer at it, I think we are already good for the drop case on the tables (by making direct use of the pg_stat_get_* functions on the before dropped oid). So I think we can remove all the "table" new checks: new patch attached is doing so. On the other hand, for the index case, I think it's better to keep the "committed index creation one". Indeed, to check that the drop behaves correctly I think it's better in "the same test" to ensure we've had the desired result before the drop (I mean having pg_stat_have_stats() returning false after a drop does not really help if we are not 100% sure it was returning true for the exact same index before the drop). > We have other variable-numbered stats kinds > FUNCTION/REPLSLOT/SUBSCRIPTION. Don't we need the same for these? I don't think we need more tests for the FUNCTION case (as it looks to me it is already covered in stat.sql by the pg_stat_get_function_calls() calls on the dropped functions oids). For SUBSCRIPTION, i think this is covered in 026_stats.pl: # Subscription stats for sub1 should be gone is( $node_subscriber->safe_psql(         $db, qq(SELECT pg_stat_have_stats('subscription', 0, $sub1_oid))),     qq(f),     qq(Subscription stats for subscription '$sub1_name' should be removed.)); For REPLSLOT, I agree that we can add one test: I added it in contrib/test_decoding/sql/stats.sql. It relies on pg_stat_have_stats() (as relying on pg_stat_replication_slots and/or pg_stat_get_replication_slot() would not help that much for this test given that the slot has been removed from ReplicationSlotCtl) Attaching v3-0001 (with the right "numbering" this time ;-) ) Regards, -- Bertrand Drouvot Amazon Web Services: https://aws.amazon.com --------------Dfo8OGUymzWRiM0fb8XeU8pw Content-Type: text/plain; charset="UTF-8"; name="v3-0001-pgstat_drop_relation-for-indexes.patch" Content-Disposition: attachment; filename="v3-0001-pgstat_drop_relation-for-indexes.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9zdGF0cy5vdXQg Yi9jb250cmliL3Rlc3RfZGVjb2RpbmcvZXhwZWN0ZWQvc3RhdHMub3V0CmluZGV4IDc4ZDM2 NDI5YzguLjQ1MjZjN2U4N2YgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9l eHBlY3RlZC9zdGF0cy5vdXQKKysrIGIvY29udHJpYi90ZXN0X2RlY29kaW5nL2V4cGVjdGVk L3N0YXRzLm91dApAQCAtMTM5LDYgKzEzOSwxNCBAQCBTRUxFQ1Qgc2xvdF9uYW1lIEZST00g cGdfc3RhdF9yZXBsaWNhdGlvbl9zbG90czsKIAogQ09NTUlUOwogRFJPUCBUQUJMRSBzdGF0 c190ZXN0OworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgdHJ1ZSBmb3IgcmVncmVz c2lvbl9zbG90X3N0YXRzMQorLS0gSXRzIGluZGV4IGlzIDEgaW4gUmVwbGljYXRpb25TbG90 Q3RsLT5yZXBsaWNhdGlvbl9zbG90cworc2VsZWN0IHBnX3N0YXRfaGF2ZV9zdGF0cygncmVw bHNsb3QnLCAwLCAxKTsKKyBwZ19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0tLS0t LS0tLQorIHQKKygxIHJvdykKKwogU0VMRUNUIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgn cmVncmVzc2lvbl9zbG90X3N0YXRzMScpLAogICAgIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xv dCgncmVncmVzc2lvbl9zbG90X3N0YXRzMicpLAogICAgIHBnX2Ryb3BfcmVwbGljYXRpb25f c2xvdCgncmVncmVzc2lvbl9zbG90X3N0YXRzMycpOwpAQCAtMTQ3LDMgKzE1NSwxMCBAQCBT RUxFQ1QgcGdfZHJvcF9yZXBsaWNhdGlvbl9zbG90KCdyZWdyZXNzaW9uX3Nsb3Rfc3RhdHMx JyksCiAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgCiAoMSByb3cpCiAKKy0tIHBnX3N0YXRfaGF2ZV9zdGF0cyByZXR1cm5zIGZhbHNl IGZvciByZWdyZXNzaW9uX3Nsb3Rfc3RhdHMxCitzZWxlY3QgcGdfc3RhdF9oYXZlX3N0YXRz KCdyZXBsc2xvdCcsIDAsIDEpOworIHBnX3N0YXRfaGF2ZV9zdGF0cyAKKy0tLS0tLS0tLS0t LS0tLS0tLS0tCisgZgorKDEgcm93KQorCmRpZmYgLS1naXQgYS9jb250cmliL3Rlc3RfZGVj b2Rpbmcvc3FsL3N0YXRzLnNxbCBiL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9zcWwvc3RhdHMu c3FsCmluZGV4IDYzMDM3MWYxNDcuLjAzNjAzOWI5NjYgMTAwNjQ0Ci0tLSBhL2NvbnRyaWIv dGVzdF9kZWNvZGluZy9zcWwvc3RhdHMuc3FsCisrKyBiL2NvbnRyaWIvdGVzdF9kZWNvZGlu Zy9zcWwvc3RhdHMuc3FsCkBAIC01MSw2ICs1MSwxMiBAQCBTRUxFQ1Qgc2xvdF9uYW1lIEZS T00gcGdfc3RhdF9yZXBsaWNhdGlvbl9zbG90czsKIENPTU1JVDsKIAogRFJPUCBUQUJMRSBz dGF0c190ZXN0OworCistLSBwZ19zdGF0X2hhdmVfc3RhdHMgcmV0dXJucyB0cnVlIGZvciBy ZWdyZXNzaW9uX3Nsb3Rfc3RhdHMxCistLSBJdHMgaW5kZXggaXMgMSBpbiBSZXBsaWNhdGlv blNsb3RDdGwtPnJlcGxpY2F0aW9uX3Nsb3RzCitzZWxlY3QgcGdfc3RhdF9oYXZlX3N0YXRz KCdyZXBsc2xvdCcsIDAsIDEpOwogU0VMRUNUIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCgn cmVncmVzc2lvbl9zbG90X3N0YXRzMScpLAogICAgIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xv dCgncmVncmVzc2lvbl9zbG90X3N0YXRzMicpLAogICAgIHBnX2Ryb3BfcmVwbGljYXRpb25f c2xvdCgncmVncmVzc2lvbl9zbG90X3N0YXRzMycpOworLS0gcGdfc3RhdF9oYXZlX3N0YXRz IHJldHVybnMgZmFsc2UgZm9yIHJlZ3Jlc3Npb25fc2xvdF9zdGF0czEKK3NlbGVjdCBwZ19z dGF0X2hhdmVfc3RhdHMoJ3JlcGxzbG90JywgMCwgMSk7CmRpZmYgLS1naXQgYS9zcmMvYmFj a2VuZC9jYXRhbG9nL2hlYXAuYyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvaGVhcC5jCmluZGV4 IDliMDM1NzllNmUuLjlhODBjY2RjY2QgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NhdGFs b2cvaGVhcC5jCisrKyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvaGVhcC5jCkBAIC00MDMsNiAr NDAzLDkgQEAgaGVhcF9jcmVhdGUoY29uc3QgY2hhciAqcmVsbmFtZSwKIAkJcmVjb3JkRGVw ZW5kZW5jeU9uVGFibGVzcGFjZShSZWxhdGlvblJlbGF0aW9uSWQsIHJlbGlkLAogCQkJCQkJ CQkJIHJlbHRhYmxlc3BhY2UpOwogCisJLyogZW5zdXJlIHRoYXQgc3RhdHMgYXJlIGRyb3Bw ZWQgaWYgdHJhbnNhY3Rpb24gYWJvcnRzICovCisJcGdzdGF0X2NyZWF0ZV9yZWxhdGlvbihy ZWwpOworCiAJcmV0dXJuIHJlbDsKIH0KIApAQCAtMTQ3Nyw5ICsxNDgwLDYgQEAgaGVhcF9j cmVhdGVfd2l0aF9jYXRhbG9nKGNvbnN0IGNoYXIgKnJlbG5hbWUsCiAJaWYgKG9uY29tbWl0 ICE9IE9OQ09NTUlUX05PT1ApCiAJCXJlZ2lzdGVyX29uX2NvbW1pdF9hY3Rpb24ocmVsaWQs IG9uY29tbWl0KTsKIAotCS8qIGVuc3VyZSB0aGF0IHN0YXRzIGFyZSBkcm9wcGVkIGlmIHRy YW5zYWN0aW9uIGFib3J0cyAqLwotCXBnc3RhdF9jcmVhdGVfcmVsYXRpb24obmV3X3JlbF9k ZXNjKTsKLQogCS8qCiAJICogb2ssIHRoZSByZWxhdGlvbiBoYXMgYmVlbiBjYXRhbG9nZWQs IHNvIGNsb3NlIG91ciByZWxhdGlvbnMgYW5kIHJldHVybgogCSAqIHRoZSBPSUQgb2YgdGhl IG5ld2x5IGNyZWF0ZWQgcmVsYXRpb24uCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jYXRh bG9nL2luZGV4LmMgYi9zcmMvYmFja2VuZC9jYXRhbG9nL2luZGV4LmMKaW5kZXggZDcxOTJm MzVlMy4uNjFmMWQzOTI2YSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9pbmRl eC5jCisrKyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvaW5kZXguYwpAQCAtMjMyNSw2ICsyMzI1 LDkgQEAgaW5kZXhfZHJvcChPaWQgaW5kZXhJZCwgYm9vbCBjb25jdXJyZW50LCBib29sIGNv bmN1cnJlbnRfbG9ja19tb2RlKQogCWlmIChSRUxLSU5EX0hBU19TVE9SQUdFKHVzZXJJbmRl eFJlbGF0aW9uLT5yZF9yZWwtPnJlbGtpbmQpKQogCQlSZWxhdGlvbkRyb3BTdG9yYWdlKHVz ZXJJbmRleFJlbGF0aW9uKTsKIAorCS8qIGVuc3VyZSB0aGF0IHN0YXRzIGFyZSBkcm9wcGVk IGlmIHRyYW5zYWN0aW9uIGNvbW1pdHMgKi8KKwlwZ3N0YXRfZHJvcF9yZWxhdGlvbih1c2Vy SW5kZXhSZWxhdGlvbik7CisKIAkvKgogCSAqIENsb3NlIGFuZCBmbHVzaCB0aGUgaW5kZXgn cyByZWxjYWNoZSBlbnRyeSwgdG8gZW5zdXJlIHJlbGNhY2hlIGRvZXNuJ3QKIAkgKiB0cnkg dG8gcmVidWlsZCBpdCB3aGlsZSB3ZSdyZSBkZWxldGluZyBjYXRhbG9nIGVudHJpZXMuIFdl IGtlZXAgdGhlCmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRz Lm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0CmluZGV4IDZiMjMz ZmY0YzAuLjk0NzU4MjI0ZGMgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0 ZWQvc3RhdHMub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0 CkBAIC03ODMsNiArNzgzLDExMCBAQCBTRUxFQ1QgcGdfc3RhdF9oYXZlX3N0YXRzKCdkYXRh YmFzZScsIChTRUxFQ1Qgb2lkIEZST00gcGdfZGF0YWJhc2UgV0hFUkUgZGF0bmFtZQogIHQK ICgxIHJvdykKIAorLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgdHJ1ZSBmb3IgY29t bWl0dGVkIGluZGV4IGNyZWF0aW9uCitDUkVBVEUgdGFibGUgc3RhdHNfdGVzdF90YWIxIGFz IHNlbGVjdCBnZW5lcmF0ZV9zZXJpZXMoMSwxMCkgYTsKK0NSRUFURSBpbmRleCBzdGF0c190 ZXN0X2lkeDEgb24gc3RhdHNfdGVzdF90YWIxKGEpOworU0VMRUNUIG9pZCBBUyBkYm9pZCBm cm9tIHBnX2RhdGFiYXNlIHdoZXJlIGRhdG5hbWUgPSBjdXJyZW50X2RhdGFiYXNlKCkgXGdz ZXQKK1NFTEVDVCAnc3RhdHNfdGVzdF9pZHgxJzo6cmVnY2xhc3M6Om9pZCBBUyBzdGF0c190 ZXN0X2lkeDFfb2lkIFxnc2V0CitTRVQgZW5hYmxlX3NlcXNjYW4gVE8gb2ZmOworc2VsZWN0 IGEgZnJvbSBzdGF0c190ZXN0X3RhYjEgd2hlcmUgYSA9IDM7CisgYSAKKy0tLQorIDMKKygx IHJvdykKKworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQs IDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKKyBwZ19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0t LS0tLS0tLS0tLS0tLQorIHQKKygxIHJvdykKKworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJl dHVybnMgZmFsc2UgZm9yIGRyb3BwZWQgaW5kZXggd2l0aCBzdGF0cworU0VMRUNUIHBnX3N0 YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lk KTsKKyBwZ19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0tLS0tLS0tLQorIHQKKygx IHJvdykKKworRFJPUCBpbmRleCBzdGF0c190ZXN0X2lkeDE7CitTRUxFQ1QgcGdfc3RhdF9o YXZlX3N0YXRzKCdyZWxhdGlvbicsIDpkYm9pZCwgOnN0YXRzX3Rlc3RfaWR4MV9vaWQpOwor IHBnX3N0YXRfaGF2ZV9zdGF0cyAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tCisgZgorKDEgcm93 KQorCistLSBwZ19zdGF0X2hhdmVfc3RhdHMgcmV0dXJucyBmYWxzZSBmb3Igcm9sbGVkIGJh Y2sgaW5kZXggY3JlYXRpb24KK0JFR0lOOworQ1JFQVRFIGluZGV4IHN0YXRzX3Rlc3RfaWR4 MSBvbiBzdGF0c190ZXN0X3RhYjEoYSk7CitTRUxFQ1QgJ3N0YXRzX3Rlc3RfaWR4MSc6OnJl Z2NsYXNzOjpvaWQgQVMgc3RhdHNfdGVzdF9pZHgxX29pZCBcZ3NldAorc2VsZWN0IGEgZnJv bSBzdGF0c190ZXN0X3RhYjEgd2hlcmUgYSA9IDM7CisgYSAKKy0tLQorIDMKKygxIHJvdykK KworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0 c190ZXN0X2lkeDFfb2lkKTsKKyBwZ19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0t LS0tLS0tLQorIHQKKygxIHJvdykKKworUk9MTEJBQ0s7CitTRUxFQ1QgcGdfc3RhdF9oYXZl X3N0YXRzKCdyZWxhdGlvbicsIDpkYm9pZCwgOnN0YXRzX3Rlc3RfaWR4MV9vaWQpOworIHBn X3N0YXRfaGF2ZV9zdGF0cyAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tCisgZgorKDEgcm93KQor CistLSBwZ19zdGF0X2hhdmVfc3RhdHMgcmV0dXJucyB0cnVlIGZvciByZWluZGV4IENPTkNV UlJFTlRMWQorQ1JFQVRFIGluZGV4IHN0YXRzX3Rlc3RfaWR4MSBvbiBzdGF0c190ZXN0X3Rh YjEoYSk7CitTRUxFQ1QgJ3N0YXRzX3Rlc3RfaWR4MSc6OnJlZ2NsYXNzOjpvaWQgQVMgc3Rh dHNfdGVzdF9pZHgxX29pZCBcZ3NldAorc2VsZWN0IGEgZnJvbSBzdGF0c190ZXN0X3RhYjEg d2hlcmUgYSA9IDM7CisgYSAKKy0tLQorIDMKKygxIHJvdykKKworU0VMRUNUIHBnX3N0YXRf aGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsK KyBwZ19zdGF0X2hhdmVfc3RhdHMgCistLS0tLS0tLS0tLS0tLS0tLS0tLQorIHQKKygxIHJv dykKKworUkVJTkRFWCBpbmRleCBDT05DVVJSRU5UTFkgc3RhdHNfdGVzdF9pZHgxOworLS0g ZmFsc2UgZm9yIHByZXZpb3VzIG9pZAorU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVs YXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKKyBwZ19zdGF0X2hhdmVf c3RhdHMgCistLS0tLS0tLS0tLS0tLS0tLS0tLQorIGYKKygxIHJvdykKKworLS0gdHJ1ZSBm b3IgbmV3IG9pZAorU0VMRUNUICdzdGF0c190ZXN0X2lkeDEnOjpyZWdjbGFzczo6b2lkIEFT IHN0YXRzX3Rlc3RfaWR4MV9vaWQgXGdzZXQKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMo J3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CisgcGdfc3RhdF9o YXZlX3N0YXRzIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyB0CisoMSByb3cpCisKKy0tIHBn X3N0YXRfaGF2ZV9zdGF0cyByZXR1cm5zIHRydWUgZm9yIGEgcm9sbGVkIGJhY2sgZHJvcCBp bmRleCB3aXRoIHN0YXRzCitCRUdJTjsKK1NFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3Jl bGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7CisgcGdfc3RhdF9oYXZl X3N0YXRzIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyB0CisoMSByb3cpCisKK0RST1AgaW5k ZXggc3RhdHNfdGVzdF9pZHgxOworUk9MTEJBQ0s7CitTRUxFQ1QgcGdfc3RhdF9oYXZlX3N0 YXRzKCdyZWxhdGlvbicsIDpkYm9pZCwgOnN0YXRzX3Rlc3RfaWR4MV9vaWQpOworIHBnX3N0 YXRfaGF2ZV9zdGF0cyAKKy0tLS0tLS0tLS0tLS0tLS0tLS0tCisgdAorKDEgcm93KQorCist LSBwdXQgZW5hYmxlX3NlcXNjYW4gYmFjayB0byBvbgorU0VUIGVuYWJsZV9zZXFzY2FuIFRP IG9uOwogLS0gZW5zdXJlIHRoYXQgc3RhdHMgYWNjZXNzb3JzIGhhbmRsZSBOVUxMIGlucHV0 IGNvcnJlY3RseQogU0VMRUNUIHBnX3N0YXRfZ2V0X3JlcGxpY2F0aW9uX3Nsb3QoTlVMTCk7 CiAgcGdfc3RhdF9nZXRfcmVwbGljYXRpb25fc2xvdCAKZGlmZiAtLWdpdCBhL3NyYy90ZXN0 L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbCBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNx bAppbmRleCAwOTZmMDBjZThiLi4xYzM0MGZmYzAzIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9y ZWdyZXNzL3NxbC9zdGF0cy5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMu c3FsCkBAIC0zOTAsNiArMzkwLDUwIEBAIFNFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ3ph cGhvZCcsIDAsIDApOwogU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygnZGF0YWJhc2UnLCAo U0VMRUNUIG9pZCBGUk9NIHBnX2RhdGFiYXNlIFdIRVJFIGRhdG5hbWUgPSBjdXJyZW50X2Rh dGFiYXNlKCkpLCAxKTsKIFNFTEVDVCBwZ19zdGF0X2hhdmVfc3RhdHMoJ2RhdGFiYXNlJywg KFNFTEVDVCBvaWQgRlJPTSBwZ19kYXRhYmFzZSBXSEVSRSBkYXRuYW1lID0gY3VycmVudF9k YXRhYmFzZSgpKSwgMCk7CiAKKy0tIHBnX3N0YXRfaGF2ZV9zdGF0cyByZXR1cm5zIHRydWUg Zm9yIGNvbW1pdHRlZCBpbmRleCBjcmVhdGlvbgorQ1JFQVRFIHRhYmxlIHN0YXRzX3Rlc3Rf dGFiMSBhcyBzZWxlY3QgZ2VuZXJhdGVfc2VyaWVzKDEsMTApIGE7CitDUkVBVEUgaW5kZXgg c3RhdHNfdGVzdF9pZHgxIG9uIHN0YXRzX3Rlc3RfdGFiMShhKTsKK1NFTEVDVCBvaWQgQVMg ZGJvaWQgZnJvbSBwZ19kYXRhYmFzZSB3aGVyZSBkYXRuYW1lID0gY3VycmVudF9kYXRhYmFz ZSgpIFxnc2V0CitTRUxFQ1QgJ3N0YXRzX3Rlc3RfaWR4MSc6OnJlZ2NsYXNzOjpvaWQgQVMg c3RhdHNfdGVzdF9pZHgxX29pZCBcZ3NldAorU0VUIGVuYWJsZV9zZXFzY2FuIFRPIG9mZjsK K3NlbGVjdCBhIGZyb20gc3RhdHNfdGVzdF90YWIxIHdoZXJlIGEgPSAzOworU0VMRUNUIHBn X3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFf b2lkKTsKKworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgZmFsc2UgZm9yIGRyb3Bw ZWQgaW5kZXggd2l0aCBzdGF0cworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRp b24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKK0RST1AgaW5kZXggc3RhdHNf dGVzdF9pZHgxOworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJv aWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKKworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJl dHVybnMgZmFsc2UgZm9yIHJvbGxlZCBiYWNrIGluZGV4IGNyZWF0aW9uCitCRUdJTjsKK0NS RUFURSBpbmRleCBzdGF0c190ZXN0X2lkeDEgb24gc3RhdHNfdGVzdF90YWIxKGEpOworU0VM RUNUICdzdGF0c190ZXN0X2lkeDEnOjpyZWdjbGFzczo6b2lkIEFTIHN0YXRzX3Rlc3RfaWR4 MV9vaWQgXGdzZXQKK3NlbGVjdCBhIGZyb20gc3RhdHNfdGVzdF90YWIxIHdoZXJlIGEgPSAz OworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0 c190ZXN0X2lkeDFfb2lkKTsKK1JPTExCQUNLOworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0 cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKKworLS0gcGdf c3RhdF9oYXZlX3N0YXRzIHJldHVybnMgdHJ1ZSBmb3IgcmVpbmRleCBDT05DVVJSRU5UTFkK K0NSRUFURSBpbmRleCBzdGF0c190ZXN0X2lkeDEgb24gc3RhdHNfdGVzdF90YWIxKGEpOwor U0VMRUNUICdzdGF0c190ZXN0X2lkeDEnOjpyZWdjbGFzczo6b2lkIEFTIHN0YXRzX3Rlc3Rf aWR4MV9vaWQgXGdzZXQKK3NlbGVjdCBhIGZyb20gc3RhdHNfdGVzdF90YWIxIHdoZXJlIGEg PSAzOworU0VMRUNUIHBnX3N0YXRfaGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpz dGF0c190ZXN0X2lkeDFfb2lkKTsKK1JFSU5ERVggaW5kZXggQ09OQ1VSUkVOVExZIHN0YXRz X3Rlc3RfaWR4MTsKKy0tIGZhbHNlIGZvciBwcmV2aW91cyBvaWQKK1NFTEVDVCBwZ19zdGF0 X2hhdmVfc3RhdHMoJ3JlbGF0aW9uJywgOmRib2lkLCA6c3RhdHNfdGVzdF9pZHgxX29pZCk7 CistLSB0cnVlIGZvciBuZXcgb2lkCitTRUxFQ1QgJ3N0YXRzX3Rlc3RfaWR4MSc6OnJlZ2Ns YXNzOjpvaWQgQVMgc3RhdHNfdGVzdF9pZHgxX29pZCBcZ3NldAorU0VMRUNUIHBnX3N0YXRf aGF2ZV9zdGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsK KworLS0gcGdfc3RhdF9oYXZlX3N0YXRzIHJldHVybnMgdHJ1ZSBmb3IgYSByb2xsZWQgYmFj ayBkcm9wIGluZGV4IHdpdGggc3RhdHMKK0JFR0lOOworU0VMRUNUIHBnX3N0YXRfaGF2ZV9z dGF0cygncmVsYXRpb24nLCA6ZGJvaWQsIDpzdGF0c190ZXN0X2lkeDFfb2lkKTsKK0RST1Ag aW5kZXggc3RhdHNfdGVzdF9pZHgxOworUk9MTEJBQ0s7CitTRUxFQ1QgcGdfc3RhdF9oYXZl X3N0YXRzKCdyZWxhdGlvbicsIDpkYm9pZCwgOnN0YXRzX3Rlc3RfaWR4MV9vaWQpOworCist LSBwdXQgZW5hYmxlX3NlcXNjYW4gYmFjayB0byBvbgorU0VUIGVuYWJsZV9zZXFzY2FuIFRP IG9uOwogCiAtLSBlbnN1cmUgdGhhdCBzdGF0cyBhY2Nlc3NvcnMgaGFuZGxlIE5VTEwgaW5w dXQgY29ycmVjdGx5CiBTRUxFQ1QgcGdfc3RhdF9nZXRfcmVwbGljYXRpb25fc2xvdChOVUxM KTsK --------------Dfo8OGUymzWRiM0fb8XeU8pw--