Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0mss-007pih-B1 for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Nov 2023 18:02:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r0msp-006dKS-Io for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Nov 2023 18:02:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0msp-006dKK-8H for pgsql-hackers@lists.postgresql.org; Wed, 08 Nov 2023 18:02:31 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r0msm-005OKK-Tm for pgsql-hackers@postgresql.org; Wed, 08 Nov 2023 18:02:30 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50930f126b1so8984800e87.3 for ; Wed, 08 Nov 2023 10:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699466547; x=1700071347; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jUqRc76WUSJwAR7gcMp/3UigcWddBhgpJEJnaadkLcY=; b=gCUFExdT9TGVIFwID/eNzAGFhCE/siCiUlO5LBSLZJ2psQ7JJxFNaWYtNglbqaWqC4 fh5RmkPA4mRXMZkcA8pypu4mu0gSNLxSDaMDJjFD3JInoRBfnLm27QwvEZ6O0HGFBXdN P86ZoKLgL4W9iAnSq59JhnnCCSU27lsN7K93vYDvqBmeLMpz4gBYMcqKVdBkGs/36nxz IZnp3q+HUJwWUJExfxrrNcAtZmJtdE+KEldEhcONAW2HOMez/dHLo+PlGAoVZCS9GqME II9UxyZCuhJa0dbDb4lphLsswfUcOEN0xzPCZXAae8KBTOrvaDIn3y08TQ3l026XhhRn tZ7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699466547; x=1700071347; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jUqRc76WUSJwAR7gcMp/3UigcWddBhgpJEJnaadkLcY=; b=QSQwqstVnu2RHpAGTHFP9rfa1njzgy0F8X8Is9PGNkjXEM/gULqtxBOs4OugVrZcNq EhzN6SvGucjxLBr66q6aXyZBCJK5f8b16FcKbNmyOGwCvN1vw6ZeVEQgQvE3OztbiER0 e69nKlE0h747nZ6XxHPZxmk1trF4JXSytW+6Xldc+SQ+AY//WkFVo+Ais4h/YXQtJSdj t636kY12d7G/3ylhso+LFYOBFY4rJ2mAXF97FBaopbIq6OhwUaN1wA98luhz9uI407mQ 4f9oOtkc1zk9d5/n8djvmi+qJQ0n0JAeRkthLpVdLxImYoWa2Mn6948CiwRz7YseYYrw vUtw== X-Gm-Message-State: AOJu0YxRX9KNUC0NaOm7rS3Iej+8MR/ltPSM/Ugg/ME/PcehIIPTJMCh MkxYDzlbzdrMcQIHnKMPYys= X-Google-Smtp-Source: AGHT+IF/4Afm8OzMDzAuwA9m88kWhV23/hCOhmfTHWv/zYMtYINVXYcmSJhx5rAy2HPOvuKUUOSV8g== X-Received: by 2002:a19:691c:0:b0:4fb:7559:aea3 with SMTP id e28-20020a19691c000000b004fb7559aea3mr1704731lfc.39.1699466547203; Wed, 08 Nov 2023 10:02:27 -0800 (PST) Received: from [1.0.0.7] ([178.155.28.40]) by smtp.gmail.com with ESMTPSA id 28-20020ac25f5c000000b005056422d204sm732935lfz.158.2023.11.08.10.00.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 10:00:53 -0800 (PST) Message-ID: Date: Wed, 8 Nov 2023 21:00:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: ResourceOwner refactoring Content-Language: en-US To: Heikki Linnakangas , Peter Eisentraut , Andres Freund Cc: Aleksander Alekseev , "pgsql-hackers@postgresql.org" , Julien Rouhaud , Robert Haas References: <2e10b71b-352e-b97b-1e47-658e2669cecb@iki.fi> <20221101001523.lsgmohl6fjwppbgx@awork3.anarazel.de> <9a3245db-ca03-4a47-5706-73404cfe5108@iki.fi> <20221101154251.64vyq7wy6w7aykrn@awork3.anarazel.de> <527af829-4a03-03b0-121c-46ff79c61887@iki.fi> <20230710191446.pn5ltm73t2i3xtxz@awork3.anarazel.de> <20607b96-b275-4a57-8509-29a3ed320d3f@iki.fi> <48b16f57-4204-4bd2-ab42-fb24144649c4@eisentraut.org> <9cb1277d-aee4-6511-44ee-7924676f7756@gmail.com> <599c6674-d40b-4b31-9251-c5c073ff9fdc@iki.fi> From: Alexander Lakhin In-Reply-To: <599c6674-d40b-4b31-9251-c5c073ff9fdc@iki.fi> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello Heikki, 08.11.2023 14:37, Heikki Linnakangas wrote: > > Fixed these, and pushed. Thanks everyone for reviewing! > Please look at a new assertion failure, I've managed to trigger with this script: CREATE TABLE t( i01 int, i02 int, i03 int, i04 int, i05 int, i06 int, i07 int, i08 int, i09 int, i10 int, i11 int, i12 int, i13 int, i14 int, i15 int, i16 int, i17 int, i18 int, i19 int, i20 int, i21 int, i22 int, i23 int, i24 int, i25 int, i26 int ); CREATE TABLE tp PARTITION OF t FOR VALUES IN (1); (gdb) bt ... #5  0x0000560dd4e42f77 in ExceptionalCondition (conditionName=0x560dd5059fbc "owner->narr == 0", fileName=0x560dd5059e31 "resowner.c", lineNumber=362) at assert.c:66 #6  0x0000560dd4e93cbd in ResourceOwnerReleaseAll (owner=0x560dd69cebd0, phase=RESOURCE_RELEASE_BEFORE_LOCKS, printLeakWarnings=false) at resowner.c:362 #7  0x0000560dd4e92e22 in ResourceOwnerReleaseInternal (owner=0x560dd69cebd0, phase=RESOURCE_RELEASE_BEFORE_LOCKS, isCommit=false, isTopLevel=true) at resowner.c:725 #8  0x0000560dd4e92d42 in ResourceOwnerReleaseInternal (owner=0x560dd69ce3f8, phase=RESOURCE_RELEASE_BEFORE_LOCKS, isCommit=false, isTopLevel=true) at resowner.c:678 #9  0x0000560dd4e92cdb in ResourceOwnerRelease (owner=0x560dd69ce3f8, phase=RESOURCE_RELEASE_BEFORE_LOCKS, isCommit=false, isTopLevel=true) at resowner.c:652 #10 0x0000560dd47316ef in AbortTransaction () at xact.c:2848 #11 0x0000560dd47329ac in AbortCurrentTransaction () at xact.c:3339 #12 0x0000560dd4c37284 in PostgresMain (dbname=0x560dd69779f0 "regression", username=0x560dd69779d8 "law") at postgres.c:4370 ... Best regards, Alexander