Message-ID: <be8ae03d-9eb3-4adb-beb8-3b356b3c68bb@postgrespro.ru>
Date: Fri, 24 Nov 2023 08:05:14 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: POC, WIP: OR-clause support for indexes
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>, pgsql-hackers@postgresql.org
Cc: Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>,
 "Finnerty, Jim" <jfinnert@amazon.com>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Ranier Vilela <ranier.vf@gmail.com>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>,
 Alexander Korotkov <aekorotkov@gmail.com>
References: <567ED6CA.2040504@sigaev.ru>
 <89fb769c-7d45-f0c5-a9b3-b706c9661c57@postgrespro.ru>
 <668892c1-fb11-3a79-ce5e-1c194b7b3263@postgrespro.ru>
 <CAPpHfduJtO0s9E=SHUTzrCD88BH0eik0UNog1_q3XBF2wLmH6g@mail.gmail.com>
 <CA+Tgmob=ebuCHFSw327b55DJzE3JtOuZ5owxob+MgErb4me_Ag@mail.gmail.com>
 <aca9dad7-27ef-4724-8a16-435a45640545@postgrespro.ru>
 <CA+TgmoaA+OXewcifo7ypr1szb_JP6m-qJp+K8iSenOPi9mtrbg@mail.gmail.com>
 <CAH2-Wzkrg_nnh-xvnFZhNKEMJf0hZ0putQaqWhQrezEnb8b+XA@mail.gmail.com>
 <CA+Tgmoa+ywixgrgV2x4QHJgLvre31wJDsx-dC1gXDmtJUgv=Ww@mail.gmail.com>
 <CAPpHfdt58O5jzKMjkScNbGecM5JqfaMfdGLjs4rk5XisfjTNBw@mail.gmail.com>
 <16a7e3aa-24c0-4986-8820-ea2857bd7b6b@postgrespro.ru>
 <421656a9-5df7-41bb-9d58-1c1edbd5dc3e@postgrespro.ru>
 <28c727ba-5260-42a8-88b0-4ecdeeca6ef8@postgrespro.ru>
 <4c1c2c0b-802f-45ae-a7cd-007bfd8957cf@postgrespro.ru>
 <52f0d302-7963-452f-8c5a-f66d261514eb@postgrespro.ru>
 <43ad8a48-b980-410d-a83c-5beebf82a4ed@postgrespro.ru>
 <b5a5b515-6f38-431a-98b8-d30abae62fde@postgrespro.ru>
Content-Language: en-US
From: Alena Rybakina <a.rybakina@postgrespro.ru>
In-Reply-To: <b5a5b515-6f38-431a-98b8-d30abae62fde@postgrespro.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/be8ae03d-9eb3-4adb-beb8-3b356b3c68bb%40postgrespro.ru>
Precedence: bulk

On 23.11.2023 12:23, Andrei Lepikhov wrote:
> I think the usage of nodeToString for the generation of clause hash is 
> too expensive and buggy.
> Also, in the code, you didn't resolve hash collisions. So, I've 
> rewritten the patch a bit (see the attachment).
> One more thing: I propose to enable transformation by default at least 
> for quick detection of possible issues.
> This code changes tests in many places. But, as I see it, it mostly 
> demonstrates the positive effect of the transformation.

On 24.11.2023 06:30, Andrei Lepikhov wrote:

> On 23/11/2023 16:23, Andrei Lepikhov wrote:
>> This code changes tests in many places. But, as I see it, it mostly 
>> demonstrates the positive effect of the transformation.
>
> I found out that the postgres_fdw tests were impacted by the feature. 
> Fix it, because the patch is on the commitfest and passes buildfarm.
> Taking advantage of this, I suppressed the expression evaluation 
> procedure to make regression test changes more clear.

Thank you for your work. You are right, the patch with the current 
changes looks better and works more correctly.

To be honest, I didn't think we could use JumbleExpr in this way.

-- 
Regards,
Alena Rybakina
Postgres Professional