User-Agent: Cyrus-JMAP/3.5.0-alpha0-4458-g51a91c06b2-fm-20211130.004-g51a91c06
Mime-Version: 1.0
Message-Id: <bede4167-8d63-4bd2-9ce6-f0a94d6aa6be@www.fastmail.com>
In-Reply-To: 
 <CAA4eK1+C2Z8bmGT_7xo4T+fZqqTr1i56Hidv9krmaEDUACwGjA@mail.gmail.com>
References: 
 <CAHut+PvSHjUsrrgVeE43hN8AZVPa8VqQ=GH1LYJFSubp2W_dhA@mail.gmail.com>
 <CAHut+PtRdXzPpm3qv3cEYWWfVUkGT84EopEHxwt95eo_cG_3eQ@mail.gmail.com>
 <OS0PR01MB571625D4A5CC1DAB4045B2BB94919@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAHut+Pu1AMDUwBNKeevLKOO2=M6ZBXpddi-s7fhqBpMxMWUQpA@mail.gmail.com>
 <CAFPTHDZgxAbLA98HZkN-JNHoHXSBGtK4eAGQrXam5JQY6Zx7wg@mail.gmail.com>
 <OS0PR01MB61132C0E4FFEE73D34AE9823FB999@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <CAJcOf-d0=Pnv8qpBaN5WM5wtmhT3EJ64crWtfPBtiwtK8iUEwg@mail.gmail.com>
 <CAHut+Pv-D4rQseRO_OzfEz2dQsTKEnKjBCET9Z-iJppyT1XNMQ@mail.gmail.com>
 <CALDaNm2bq-Zab3i5pvuA3UTxHvo3BqPwmgXbyznpw5vz4=fxpA@mail.gmail.com>
 <OS0PR01MB57162EB465A0E6BCFDF9B3F394609@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KZ+N=vfgqeUuZfRLRC+WyNBFvU9Ei7kF-7OPXnTX2WrA@mail.gmail.com>
 <OS0PR01MB5716F2C3904CB807050010A394619@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAA4eK1KVUs2s3PTcTTRj3qdmUzEDG7PQ5Xq_b1J7zMsi2OvE5w@mail.gmail.com>
 <OS0PR01MB57168FD9932E3F42406EB13B94629@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CAJcOf-dz0srExG0NPPgXh5X8eL2uxk7C=cZoGTbf8cNqoRUY6w@mail.gmail.com>
 <CAA4eK1+8UqT5b3Ha42Wt07668yxs9KkKvV5r==vT9KfRUGCs-g@mail.gmail.com>
 <ca8d270d-f930-4d15-9f24-60f95b364173@www.fastmail.com>
 <CAA4eK1+hVXfOSScbf5LUB=5is=wYaC6NBhLxuvetbWQnZRnsVQ@mail.gmail.com>
 <CAHut+PtJnnM8MYQDf7xCyFAp13U_0Ya2dv-UQeFD=ghixFLZiw@mail.gmail.com>
 <49ba49f1-8bdb-40b7-ae9e-f17d88b3afcd@www.fastmail.com>
 <CAA4eK1+C2Z8bmGT_7xo4T+fZqqTr1i56Hidv9krmaEDUACwGjA@mail.gmail.com>
Date: Mon, 06 Dec 2021 09:47:41 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Amit Kapila" <amit.kapila16@gmail.com>
Cc: "Peter Smith" <smithpb2250@gmail.com>,
 "Greg Nancarrow" <gregn4422@gmail.com>,
 "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
 "vignesh C" <vignesh21@gmail.com>,
 "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>,
 "Ajin Cherian" <itsajin@gmail.com>, "Dilip Kumar" <dilipbalaut@gmail.com>,
 "Rahila Syed" <rahilasyed90@gmail.com>,
 "Peter Eisentraut" <peter.eisentraut@enterprisedb.com>,
 =?UTF-8?Q?=C3=96nder_Kalac=C4=B1?= <onderkalaci@gmail.com>,
 japin <japinli@hotmail.com>, "Michael Paquier" <michael@paquier.xyz>,
 "David Steele" <david@pgmasters.net>, "Craig Ringer" <craig@2ndquadrant.com>,
 "Amit Langote" <amitlangote09@gmail.com>,
 "PostgreSQL Hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: row filtering for logical replication
Content-Type: multipart/alternative;
 boundary=bd22b99ebded4e409993e9699a60a2e2
Archived-At: 
 <https://www.postgresql.org/message-id/bede4167-8d63-4bd2-9ce6-f0a94d6aa6be%40www.fastmail.com>
Precedence: bulk

--bd22b99ebded4e409993e9699a60a2e2
Content-Type: text/plain

On Mon, Dec 6, 2021, at 3:44 AM, Amit Kapila wrote:
> I think what you said as (b) is wrong because we want to allow builtin
> immutable functions. See discussion [1].
It was a typo. I mean "non-immutable" function.

> True, but that is the main reason the review and development are being
> done as separate sub-features. I suggest still keeping the similar
> separation till some of the reviews of each of the patches are done,
> otherwise, we need to rethink how to divide for easier review. We need
> to retain the 0005 patch because that handles many problems without
> which the main patch is incomplete and buggy w.r.t replica identity.
IMO we should merge sub-features as soon as we reach consensus. Every new
sub-feature breaks comments, tests and documentation if you want to remove or
rearrange patches. It seems I misread 0005. I agree that it is important. I'll
check it.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--bd22b99ebded4e409993e9699a60a2e2
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Mon, Dec 6, =
2021, at 3:44 AM, Amit Kapila wrote:<br></div><blockquote type=3D"cite" =
id=3D"qt" style=3D""><div>I think what you said as (b) is wrong because =
we want to allow builtin<br></div><div>immutable functions. See discussi=
on [1].<br></div></blockquote><div>It was a typo. I mean "non-immutable"=
 function.<br></div><div><br></div><blockquote type=3D"cite" id=3D"qt" s=
tyle=3D""><div>True, but that is the main reason the review and developm=
ent are being<br></div><div>done as separate sub-features. I suggest sti=
ll keeping the similar<br></div><div>separation till some of the reviews=
 of each of the patches are done,<br></div><div>otherwise, we need to re=
think how to divide for easier review. We need<br></div><div>to retain t=
he 0005 patch because that handles many problems without<br></div><div>w=
hich the main patch is incomplete and buggy w.r.t replica identity.<br><=
/div></blockquote><div>IMO we should merge sub-features as soon as we re=
ach consensus. Every new<br></div><div>sub-feature breaks comments, test=
s and documentation if you want to remove or<br></div><div>rearrange pat=
ches. It seems I misread 0005. I agree that it is important. I'll<br></d=
iv><div>check it.<br></div><div><br></div><div><br></div><div id=3D"sig1=
12409080"><div class=3D"signature">--<br></div><div class=3D"signature">=
Euler Taveira<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D=
"https://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></d=
iv></div><div><br></div></body></html>
--bd22b99ebded4e409993e9699a60a2e2--