Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rx6aR-006PG9-Mi for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Apr 2024 14:48:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rx6aP-00C2Mp-GW for pgsql-hackers@arkaria.postgresql.org; Wed, 17 Apr 2024 14:48:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rx6aN-00C2MX-Ss for pgsql-hackers@lists.postgresql.org; Wed, 17 Apr 2024 14:48:33 +0000 Received: from wfhigh3-smtp.messagingengine.com ([64.147.123.154]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rx6aK-003J8w-Pm for pgsql-hackers@postgresql.org; Wed, 17 Apr 2024 14:48:30 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfhigh.west.internal (Postfix) with ESMTP id 3B2D918000E4 for ; Wed, 17 Apr 2024 10:48:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 17 Apr 2024 10:48:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm2; t=1713365304; x=1713451704; bh=hC HSUd3ucaY7t4/DNwSOZr0MmZ3+4pMKGhDHP7GfMdM=; b=AMvciE10oHzhqJXQeo qEv426E8/YuMLK28PO7whoxBrCSaH+8rsS+8dXNuEzsJJSioqcAVxKRH+NB9nSNo 2/DDKa9nKbQ3ypDhXbdoD852BAJN/T+Na4F9cXUr51qA4F0TFmsi4wPFhAt1Y1Kg 5Nl5KfXxPsLXgDb7AoRCYuOjqh8AggTw1NEdzSvjpiKNbzLwYHIE8JQZwk9pdJRh ciqhSgFOHfU74eSOrT4+CZ2RXFmn8plBubMosL0NwGPjZnhP0plyYyiXUOi668ay hRO0LjuFfGI0AmkZKTMa2LgBZrCpdhlBGfaX+9TCpABofg342C4vvnmbOJyOi8oZ U5zw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1713365304; x=1713451704; bh=hCHSUd3ucaY7t4/DNwSOZr0MmZ3+ 4pMKGhDHP7GfMdM=; b=HXuSEfrxkrgT18ZVmT3Py9p+weGPV0+gFCq2qpQ9DzDJ ALOl0+hKwb+aWMatTNeqmb9qcieKrBUNAaOOr00nTGBasVAIY05Qu5yYY8Iw1MUx 4HgQ1nO+NIRSxETdYiwtE2bQU4BWLJ7RnRUWuAxf5L5OizCfFhaLPzByDjbHu4/d SBVqLIEutwntp1d454umiy4GawOpP5i6aYwqTwoLNZOTN0qNRxHIV4+a7W/ekz90 WWStnO4cpz8QMaxp0i9Oz7ER7dnr3ABtPp7BKD7TPfyUCYcgYnEjhq6o1PV/Bzs+ pi+oOTEYpE4E1Euy3ARSdXYHCFawZlPDB+TcgYI9vg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejkedgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfhuffvtgfgsehtjeertd dtvdejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegv ihhsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepffetvedutdefleejve ekgeefteffueeugefgfeegkedvudelveelheduffdvveehnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruh htrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 17 Apr 2024 10:48:24 -0400 (EDT) Message-ID: Date: Wed, 17 Apr 2024 16:48:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Peter Eisentraut Subject: ecpg_config.h symbol missing with meson To: pgsql-hackers Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I checked the generated ecpg_config.h with make and meson, and the meson one is missing #define HAVE_LONG_LONG_INT 1 This is obviously quite uninteresting, since that is required by C99. But it would be more satisfactory if we didn't have discrepancies like that. Note that we also kept ENABLE_THREAD_SAFETY in ecpg_config.h for compatibility. Fixing this on the meson side would be like diff --git a/src/interfaces/ecpg/include/meson.build b/src/interfaces/ecpg/include/meson.build index 31610fef589..b85486acbea 100644 --- a/src/interfaces/ecpg/include/meson.build +++ b/src/interfaces/ecpg/include/meson.build @@ -12,6 +12,7 @@ ecpg_conf_keys = [ ecpg_conf_data = configuration_data() ecpg_conf_data.set('ENABLE_THREAD_SAFETY', 1) +ecpg_conf_data.set('HAVE_LONG_LONG_INT', 1) foreach key : ecpg_conf_keys if cdata.has(key) Alternatively, we could remove the symbol from the make side.