Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3A4C-0001cr-SJ for pgsql-hackers@arkaria.postgresql.org; Sat, 23 Jan 2021 03:58:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l3A49-0000do-3G for pgsql-hackers@arkaria.postgresql.org; Sat, 23 Jan 2021 03:58:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3A48-0000dh-SJ for pgsql-hackers@lists.postgresql.org; Sat, 23 Jan 2021 03:58:24 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l3A3z-0001HB-OK for pgsql-hackers@lists.postgresql.org; Sat, 23 Jan 2021 03:58:23 +0000 Received: by mail-ed1-x531.google.com with SMTP id f1so8808350edr.12 for ; Fri, 22 Jan 2021 19:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Spcj9FbaQFFwhmcipZoYvMDi63SK3WnlZ3Lw+Nt34WA=; b=H/0vJigg8hR6x2Ws1Q0/yI3l7OU4oPLAZ/xPAwgKCYhQvZRhG5cgs6u4v/WWoBPhJB xoZCYtn6GaIt50lT7GI6qpxdfXO4m/FhQC4DE0mbS+86VzfGkh66SyrNXpIthBrQp6KN 9CWopUgLBURBdrhaSzTK7ULluEq2YKu3i/i+AU3lWdrqDVorCHbPgLNvqI/WWGfjm9Mr QFGYzr/2GR1UFB8kLLBW8x+1Q3FOdh4Giy9kAlAiDEjpR+jCXdhZ4eLErESYEBkHGVIL 6MlPqyk6PWe8oZfei9N9fxp1HTEyJUEcMpgXx8CrUJgUzkMsfpTLJG3ygfaCJYqSOLXZ Ynmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Spcj9FbaQFFwhmcipZoYvMDi63SK3WnlZ3Lw+Nt34WA=; b=eBqZ+LymyHnfW+Zi18q0RvoIrXZeFoeNSOb7blKBZHIhPh58Llp8MPNxBGB3nrusCi Et+B0ug38AC6DPQR2XyQW3d53Ko9g8knxynZ3YLW1VQlQwQUJY47bWEi5iN+Zz2wnXZt oeakfrWPmT7M/9G92qjv7aE2R/5G4Xj6k96zzgDn0zM0aFF8weYByiYQxGcjpiu6dKG7 oU2nmpVyZqZlfPVOfkDfU7JSt3mI0wgfjPifXfzBwznUBzDuQfhOBAVrbbgaqoMqeHQb AiwynFiV3Uai8A6fxOwoExm2MikDh/JMCbCUQcR2zLwLr+xOkJT8tlQ7s5wx/nKw42Cj J1aA== X-Gm-Message-State: AOAM531u0MM1DC5lswkxMh2P/qwwwMNWwUBq3S+Ejs/8nKJJBcIfiiBx 9teEqY81623kdqLZtkDlUVNogfkcqgs+eUmDXk+xKJbjnJ1v9nDYbGOY1i/OH9RhCX59uskhK/E PLUGIAwKrk8osObqnHW2shQBwdRmg0+sproaTRrDA+SGDFl5lOQ24i4WzKpcUKOmsicOWUW1wuL ny9Q/4R6vOTSLPgMtTidMcfABxi5Qrbj6TlOgJgkJNEfvsTLwWdr4g X-Google-Smtp-Source: ABdhPJzWIDlPKE4otQTPYs6scw1f4acQBmi7IoZ7wtBzu7gdgyQXfM8/ZuOh+COQmuiQ7IR2CoKD6w== X-Received: by 2002:a05:6402:b07:: with SMTP id bm7mr5709356edb.104.1611374293230; Fri, 22 Jan 2021 19:58:13 -0800 (PST) Received: from [10.137.0.20] (ip-86-49-253-127.net.upcbroadband.cz. [86.49.253.127]) by smtp.gmail.com with ESMTPSA id x2sm5106869eds.51.2021.01.22.19.58.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 19:58:12 -0800 (PST) Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits To: Tom Lane , Pavan Deolasee Cc: Anastasia Lubennikova , Tomas Vondra , Tatsuo Ishii , lubennikovaav@gmail.com, PostgreSQL Hackers , ibrar.ahmad@gmail.com References: <160382617166.1204.475752573208579406.pgcf@coridan.postgresql.org> <20201028.144653.966121790856478893.t-ishii@sraoss.co.jp> <20201030004252.d63rwclys4bniluu@development> <1d2e0f4a-6ab8-10f1-c177-af97475df001@postgrespro.ru> <20201102144453.tumlk7qhw3gzn2dk@development> <7e6a006f-c59a-93fc-3ddf-f9c661319bc8@2ndquadrant.com> <75f3760f-1077-07c1-aea4-975d5c127d6d@postgrespro.ru> <93b767d6-4cde-7326-8de4-d71d81817c16@postgrespro.ru> <8669d452-d078-bdf9-5a62-6f1acd55f3c6@enterprisedb.com> <58359211-c505-1ee6-c5fd-78db84afb46f@postgrespro.ru> <13a5b2dc-4fe9-d4a6-01df-d2c7bba8fd2c@enterprisedb.com> <692cd1f2-0aba-a959-f142-b9851691b35b@enterprisedb.com> <1254689.1611360614@sss.pgh.pa.us> From: Tomas Vondra Message-ID: Date: Sat, 23 Jan 2021 04:58:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1254689.1611360614@sss.pgh.pa.us> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 1/23/21 1:10 AM, Tom Lane wrote: > Pavan Deolasee writes: >> On Mon, Jan 18, 2021 at 3:02 AM Tomas Vondra >> wrote: >>> Pushed. Thanks everyone for the effort put into this patch. The first >>> version was sent in 2015, so it took quite a bit of time. > >> Thanks Tomas, Anastasia and everyone else who worked on the patch and >> ensured that it gets into the tree. > > Buildfarm results suggest that the test case is unstable under > CLOBBER_CACHE_ALWAYS: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hyrax&dt=2021-01-19%2020%3A27%3A46 > > This might mean an actual bug, or just that the test isn't robust. > Yeah :-( It seems I've committed the v5 patch, not the v7 addressing exactly this issue (which I've actually pointed out and asked to be fixed). Oh well ... I'll get this fixed tomorrow - I have the fix, and I have verified that it passes with CLOBBER_CACHE_ALWAYS, but pushing it at 5AM does not seem like a good idea. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company